Clarification or help needed for a basic check

[Hibou57]

Hi there,

I wished to try Basilisk, and started following this quick start: https://www.basilisk-python.dev/docs/quick-start/

There is an example bad.py to check. This one is OK. But if put this in, instead:

a: int = print2("abc")

... it just does not complain at all and says “All checked. No issues found.”

What am I missing, please?

[MelbourneDeveloper]

Related: #401 adds a returns_implicit_none rule for the definition site — a function that falls off the end of its body without returning, so Python implicitly returns None.

That is the same silent-None failure as the unfixed half of this issue, reached from the other end: #401 catches the None where it is produced, this issue's remaining half catches it where it is consumed (a: int = compute(3) is still silent because no rule consults BidirEngine::synth_call). The two are independent — #401 is pure control-flow analysis and needs no type engine.

Refs #378.

[Hibou57]

Hello,

First, thanks for the long investigation (will try to read it to understand, because it appears interesting). But I believe the issue is me, who don’t know how to use Basilisk properly. I checked multiple files (pure Python files, all annotated, no need for stubs) and tried on purpose to introduces trivial errors, like renaming an import and Basilisk does not catch it, even with all specific options enabled (so using basilisk analysze instead of basilisk check). May be it does not follow imports and I missed it, I don’t know.

Will still keep it installed and may come back to it later.

[MelbourneDeveloper]

No it's not you @Hibou57. There are a bunch of issues that we're working through at the moment. Your issue is actually not a PEP conformance issue from what I can tell. It's a rule that needs to be added because it's a common problem that people have. We're definitely working to add a rule for this. We just have to balance others fixes right now.