diff --git a/product_barcode_required/README.rst b/product_barcode_required/README.rst new file mode 100644 index 00000000000..012ff4845cd --- /dev/null +++ b/product_barcode_required/README.rst @@ -0,0 +1,94 @@ +.. image:: https://odoo-community.org/readme-banner-image + :target: https://odoo-community.org/get-involved?utm_source=readme + :alt: Odoo Community Association + +======================== +Product barcode required +======================== + +.. + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + !! This file is generated by oca-gen-addon-readme !! + !! changes will be overwritten. !! + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + !! source digest: sha256:4750d221317ff0409fadf7204c635d3a826d87904a317d3d34d27bc67bbf512a + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + +.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png + :target: https://odoo-community.org/page/development-status + :alt: Beta +.. |badge2| image:: https://img.shields.io/badge/license-LGPL--3-blue.png + :target: http://www.gnu.org/licenses/lgpl-3.0-standalone.html + :alt: License: LGPL-3 +.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fproduct--attribute-lightgray.png?logo=github + :target: https://github.com/OCA/product-attribute/tree/19.0/product_barcode_required + :alt: OCA/product-attribute +.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png + :target: https://translation.odoo-community.org/projects/product-attribute-19-0/product-attribute-19-0-product_barcode_required + :alt: Translate me on Weblate +.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png + :target: https://runboat.odoo-community.org/builds?repo=OCA/product-attribute&target_branch=19.0 + :alt: Try me on Runboat + +|badge1| |badge2| |badge3| |badge4| |badge5| + +Makes barcode field required, defaults it to product's code. + +**Table of contents** + +.. contents:: + :local: + +Configuration +============= + +Go to "Settings -> General -> Products" and enable "Product variant +barcode required". + +Bug Tracker +=========== + +Bugs are tracked on `GitHub Issues `_. +In case of trouble, please check there if your issue has already been reported. +If you spotted it first, help us to smash it by providing a detailed and welcomed +`feedback `_. + +Do not contact contributors directly about support or help with technical issues. + +Credits +======= + +Authors +------- + +* Camptocamp + +Contributors +------------ + +- Simone Orsi + +Maintainers +----------- + +This module is maintained by the OCA. + +.. image:: https://odoo-community.org/logo.png + :alt: Odoo Community Association + :target: https://odoo-community.org + +OCA, or the Odoo Community Association, is a nonprofit organization whose +mission is to support the collaborative development of Odoo features and +promote its widespread use. + +.. |maintainer-simahawk| image:: https://github.com/simahawk.png?size=40px + :target: https://github.com/simahawk + :alt: simahawk + +Current `maintainer `__: + +|maintainer-simahawk| + +This module is part of the `OCA/product-attribute `_ project on GitHub. + +You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute. diff --git a/product_barcode_required/__init__.py b/product_barcode_required/__init__.py new file mode 100644 index 00000000000..0650744f6bc --- /dev/null +++ b/product_barcode_required/__init__.py @@ -0,0 +1 @@ +from . import models diff --git a/product_barcode_required/__manifest__.py b/product_barcode_required/__manifest__.py new file mode 100644 index 00000000000..aac935f7976 --- /dev/null +++ b/product_barcode_required/__manifest__.py @@ -0,0 +1,19 @@ +# Copyright 2020 Camptocamp SA +# License LGPL-3.0 or later (https://www.gnu.org/licenses/lgpl) +{ + "name": "Product barcode required", + "summary": "Make product barcode required when enabled", + "version": "19.0.1.0.0", + "maintainers": ["simahawk"], + "development_status": "Beta", + "website": "https://github.com/OCA/product-attribute", + "author": "Camptocamp, Odoo Community Association (OCA)", + "license": "LGPL-3", + "installable": True, + "depends": ["product"], + "data": [ + "views/res_config_settings.xml", + "views/product_template_view.xml", + "views/product_view.xml", + ], +} diff --git a/product_barcode_required/i18n/ca.po b/product_barcode_required/i18n/ca.po new file mode 100644 index 00000000000..35bbef64ee0 --- /dev/null +++ b/product_barcode_required/i18n/ca.po @@ -0,0 +1,108 @@ +# Translation of Odoo Server. +# This file contains the translation of the following modules: +# * product_barcode_required +# +msgid "" +msgstr "" +"Project-Id-Version: Odoo Server 13.0\n" +"Report-Msgid-Bugs-To: \n" +"PO-Revision-Date: 2022-03-22 13:17+0000\n" +"Last-Translator: Noel estudillo \n" +"Language-Team: none\n" +"Language: ca\n" +"MIME-Version: 1.0\n" +"Content-Type: text/plain; charset=UTF-8\n" +"Content-Transfer-Encoding: \n" +"Plural-Forms: nplurals=2; plural=n != 1;\n" +"X-Generator: Weblate 4.3.2\n" + +#. module: product_barcode_required +#: model:ir.model,name:product_barcode_required.model_product_barcode_required_mixin +msgid "Barcode required mixin" +msgstr "Es requereix barreja de codi de barres" + +#. module: product_barcode_required +#: model:ir.model,name:product_barcode_required.model_res_company +msgid "Companies" +msgstr "Companyies" + +#. module: product_barcode_required +#: model:ir.model,name:product_barcode_required.model_res_config_settings +msgid "Config Settings" +msgstr "Paràmetres de la configuració" + +#. module: product_barcode_required +#: model:ir.model.fields,field_description:product_barcode_required.field_product_barcode_required_mixin__display_name +#: model:ir.model.fields,field_description:product_barcode_required.field_product_product__display_name +#: model:ir.model.fields,field_description:product_barcode_required.field_product_template__display_name +#: model:ir.model.fields,field_description:product_barcode_required.field_res_company__display_name +#: model:ir.model.fields,field_description:product_barcode_required.field_res_config_settings__display_name +msgid "Display Name" +msgstr "Nom visible" + +#. module: product_barcode_required +#: model:ir.model.fields,field_description:product_barcode_required.field_product_barcode_required_mixin__id +#: model:ir.model.fields,field_description:product_barcode_required.field_product_product__id +#: model:ir.model.fields,field_description:product_barcode_required.field_product_template__id +#: model:ir.model.fields,field_description:product_barcode_required.field_res_company__id +#: model:ir.model.fields,field_description:product_barcode_required.field_res_config_settings__id +msgid "ID" +msgstr "ID" + +#. module: product_barcode_required +#: model:ir.model.fields,field_description:product_barcode_required.field_product_barcode_required_mixin__is_barcode_required +#: model:ir.model.fields,field_description:product_barcode_required.field_product_product__is_barcode_required +#: model:ir.model.fields,field_description:product_barcode_required.field_product_template__is_barcode_required +msgid "Is Barcode Required" +msgstr "es requereix un codi de barres" + +#. module: product_barcode_required +#: model:ir.model.fields,field_description:product_barcode_required.field_product_barcode_required_mixin____last_update +#: model:ir.model.fields,field_description:product_barcode_required.field_product_product____last_update +#: model:ir.model.fields,field_description:product_barcode_required.field_product_template____last_update +#: model:ir.model.fields,field_description:product_barcode_required.field_res_company____last_update +#: model:ir.model.fields,field_description:product_barcode_required.field_res_config_settings____last_update +msgid "Last Modified on" +msgstr "Darrera modificació el" + +#. module: product_barcode_required +#: model_terms:ir.ui.view,arch_db:product_barcode_required.res_config_settings_view_form +msgid "Make barcode required." +msgstr "Feu que sigui necessari un codi de barres." + +#. module: product_barcode_required +#: model:ir.model.fields,help:product_barcode_required.field_res_company__product_variant_barcode_required +#: model:ir.model.fields,help:product_barcode_required.field_res_config_settings__product_variant_barcode_required +msgid "Make variant barcode required" +msgstr "Feu que sigui necessari un codi de barres variant" + +#. module: product_barcode_required +#: model:ir.model,name:product_barcode_required.model_product_product +msgid "Product" +msgstr "Producte" + +#. module: product_barcode_required +#: model:ir.model,name:product_barcode_required.model_product_template +msgid "Product Template" +msgstr "Plantilla de producte" + +#. module: product_barcode_required +#: model:ir.model.fields,field_description:product_barcode_required.field_res_company__product_variant_barcode_required +#: model:ir.model.fields,field_description:product_barcode_required.field_res_config_settings__product_variant_barcode_required +msgid "Product Variant Barcode Required" +msgstr "Es requereix un codi de barres per a la variant del producte" + +#. module: product_barcode_required +#: model_terms:ir.ui.view,arch_db:product_barcode_required.res_config_settings_view_form +msgid "Products barcode" +msgstr "Plantilla de producte" + +#. module: product_barcode_required +#: code:addons/product_barcode_required/models/product_barcode_mixin.py:0 +#, python-format +msgid "" +"These products have no barcode:\n" +"{}" +msgstr "" +"Aquests productes no tenen cap codi de barres:\n" +"{}" diff --git a/product_barcode_required/i18n/es.po b/product_barcode_required/i18n/es.po new file mode 100644 index 00000000000..62a0803dfe1 --- /dev/null +++ b/product_barcode_required/i18n/es.po @@ -0,0 +1,108 @@ +# Translation of Odoo Server. +# This file contains the translation of the following modules: +# * product_barcode_required +# +msgid "" +msgstr "" +"Project-Id-Version: Odoo Server 13.0\n" +"Report-Msgid-Bugs-To: \n" +"PO-Revision-Date: 2024-01-15 14:33+0000\n" +"Last-Translator: Ivorra78 \n" +"Language-Team: none\n" +"Language: es\n" +"MIME-Version: 1.0\n" +"Content-Type: text/plain; charset=UTF-8\n" +"Content-Transfer-Encoding: \n" +"Plural-Forms: nplurals=2; plural=n != 1;\n" +"X-Generator: Weblate 4.17\n" + +#. module: product_barcode_required +#: model:ir.model,name:product_barcode_required.model_product_barcode_required_mixin +msgid "Barcode required mixin" +msgstr "Código de barras requerido mixin" + +#. module: product_barcode_required +#: model:ir.model,name:product_barcode_required.model_res_company +msgid "Companies" +msgstr "Compañías" + +#. module: product_barcode_required +#: model:ir.model,name:product_barcode_required.model_res_config_settings +msgid "Config Settings" +msgstr "Ajustes de configuración" + +#. module: product_barcode_required +#: model:ir.model.fields,field_description:product_barcode_required.field_product_barcode_required_mixin__display_name +#: model:ir.model.fields,field_description:product_barcode_required.field_product_product__display_name +#: model:ir.model.fields,field_description:product_barcode_required.field_product_template__display_name +#: model:ir.model.fields,field_description:product_barcode_required.field_res_company__display_name +#: model:ir.model.fields,field_description:product_barcode_required.field_res_config_settings__display_name +msgid "Display Name" +msgstr "Nombre visible" + +#. module: product_barcode_required +#: model:ir.model.fields,field_description:product_barcode_required.field_product_barcode_required_mixin__id +#: model:ir.model.fields,field_description:product_barcode_required.field_product_product__id +#: model:ir.model.fields,field_description:product_barcode_required.field_product_template__id +#: model:ir.model.fields,field_description:product_barcode_required.field_res_company__id +#: model:ir.model.fields,field_description:product_barcode_required.field_res_config_settings__id +msgid "ID" +msgstr "ID" + +#. module: product_barcode_required +#: model:ir.model.fields,field_description:product_barcode_required.field_product_barcode_required_mixin__is_barcode_required +#: model:ir.model.fields,field_description:product_barcode_required.field_product_product__is_barcode_required +#: model:ir.model.fields,field_description:product_barcode_required.field_product_template__is_barcode_required +msgid "Is Barcode Required" +msgstr "Se requiere código de barras" + +#. module: product_barcode_required +#: model:ir.model.fields,field_description:product_barcode_required.field_product_barcode_required_mixin____last_update +#: model:ir.model.fields,field_description:product_barcode_required.field_product_product____last_update +#: model:ir.model.fields,field_description:product_barcode_required.field_product_template____last_update +#: model:ir.model.fields,field_description:product_barcode_required.field_res_company____last_update +#: model:ir.model.fields,field_description:product_barcode_required.field_res_config_settings____last_update +msgid "Last Modified on" +msgstr "Última modificación el" + +#. module: product_barcode_required +#: model_terms:ir.ui.view,arch_db:product_barcode_required.res_config_settings_view_form +msgid "Make barcode required." +msgstr "Hacer el código de barras requerido." + +#. module: product_barcode_required +#: model:ir.model.fields,help:product_barcode_required.field_res_company__product_variant_barcode_required +#: model:ir.model.fields,help:product_barcode_required.field_res_config_settings__product_variant_barcode_required +msgid "Make variant barcode required" +msgstr "Hacer que se requiera una variante" + +#. module: product_barcode_required +#: model:ir.model,name:product_barcode_required.model_product_product +msgid "Product" +msgstr "Producto" + +#. module: product_barcode_required +#: model:ir.model,name:product_barcode_required.model_product_template +msgid "Product Template" +msgstr "Plantilla de producto" + +#. module: product_barcode_required +#: model:ir.model.fields,field_description:product_barcode_required.field_res_company__product_variant_barcode_required +#: model:ir.model.fields,field_description:product_barcode_required.field_res_config_settings__product_variant_barcode_required +msgid "Product Variant Barcode Required" +msgstr "Código de barras de variante de producto obligatorio" + +#. module: product_barcode_required +#: model_terms:ir.ui.view,arch_db:product_barcode_required.res_config_settings_view_form +msgid "Products barcode" +msgstr "Código de barras de los productos" + +#. module: product_barcode_required +#: code:addons/product_barcode_required/models/product_barcode_mixin.py:0 +#, python-format +msgid "" +"These products have no barcode:\n" +"{}" +msgstr "" +"Estos productos no tienen código de barras:\n" +"{}" diff --git a/product_barcode_required/i18n/it.po b/product_barcode_required/i18n/it.po new file mode 100644 index 00000000000..3dbc15aa60a --- /dev/null +++ b/product_barcode_required/i18n/it.po @@ -0,0 +1,108 @@ +# Translation of Odoo Server. +# This file contains the translation of the following modules: +# * product_barcode_required +# +msgid "" +msgstr "" +"Project-Id-Version: Odoo Server 14.0\n" +"Report-Msgid-Bugs-To: \n" +"PO-Revision-Date: 2023-11-02 16:40+0000\n" +"Last-Translator: mymage \n" +"Language-Team: none\n" +"Language: it\n" +"MIME-Version: 1.0\n" +"Content-Type: text/plain; charset=UTF-8\n" +"Content-Transfer-Encoding: \n" +"Plural-Forms: nplurals=2; plural=n != 1;\n" +"X-Generator: Weblate 4.17\n" + +#. module: product_barcode_required +#: model:ir.model,name:product_barcode_required.model_product_barcode_required_mixin +msgid "Barcode required mixin" +msgstr "Mixin richiesta codice a barre" + +#. module: product_barcode_required +#: model:ir.model,name:product_barcode_required.model_res_company +msgid "Companies" +msgstr "Aziende" + +#. module: product_barcode_required +#: model:ir.model,name:product_barcode_required.model_res_config_settings +msgid "Config Settings" +msgstr "Impostazioni configurazione" + +#. module: product_barcode_required +#: model:ir.model.fields,field_description:product_barcode_required.field_product_barcode_required_mixin__display_name +#: model:ir.model.fields,field_description:product_barcode_required.field_product_product__display_name +#: model:ir.model.fields,field_description:product_barcode_required.field_product_template__display_name +#: model:ir.model.fields,field_description:product_barcode_required.field_res_company__display_name +#: model:ir.model.fields,field_description:product_barcode_required.field_res_config_settings__display_name +msgid "Display Name" +msgstr "Nome visualizzato" + +#. module: product_barcode_required +#: model:ir.model.fields,field_description:product_barcode_required.field_product_barcode_required_mixin__id +#: model:ir.model.fields,field_description:product_barcode_required.field_product_product__id +#: model:ir.model.fields,field_description:product_barcode_required.field_product_template__id +#: model:ir.model.fields,field_description:product_barcode_required.field_res_company__id +#: model:ir.model.fields,field_description:product_barcode_required.field_res_config_settings__id +msgid "ID" +msgstr "ID" + +#. module: product_barcode_required +#: model:ir.model.fields,field_description:product_barcode_required.field_product_barcode_required_mixin__is_barcode_required +#: model:ir.model.fields,field_description:product_barcode_required.field_product_product__is_barcode_required +#: model:ir.model.fields,field_description:product_barcode_required.field_product_template__is_barcode_required +msgid "Is Barcode Required" +msgstr "È richiesto il codice a barre" + +#. module: product_barcode_required +#: model:ir.model.fields,field_description:product_barcode_required.field_product_barcode_required_mixin____last_update +#: model:ir.model.fields,field_description:product_barcode_required.field_product_product____last_update +#: model:ir.model.fields,field_description:product_barcode_required.field_product_template____last_update +#: model:ir.model.fields,field_description:product_barcode_required.field_res_company____last_update +#: model:ir.model.fields,field_description:product_barcode_required.field_res_config_settings____last_update +msgid "Last Modified on" +msgstr "Ultima modifica il" + +#. module: product_barcode_required +#: model_terms:ir.ui.view,arch_db:product_barcode_required.res_config_settings_view_form +msgid "Make barcode required." +msgstr "Rendere il codice a barre richiesto." + +#. module: product_barcode_required +#: model:ir.model.fields,help:product_barcode_required.field_res_company__product_variant_barcode_required +#: model:ir.model.fields,help:product_barcode_required.field_res_config_settings__product_variant_barcode_required +msgid "Make variant barcode required" +msgstr "Rendere il codice a barre variante richiesto" + +#. module: product_barcode_required +#: model:ir.model,name:product_barcode_required.model_product_product +msgid "Product" +msgstr "Prodotto" + +#. module: product_barcode_required +#: model:ir.model,name:product_barcode_required.model_product_template +msgid "Product Template" +msgstr "Modello prodotto" + +#. module: product_barcode_required +#: model:ir.model.fields,field_description:product_barcode_required.field_res_company__product_variant_barcode_required +#: model:ir.model.fields,field_description:product_barcode_required.field_res_config_settings__product_variant_barcode_required +msgid "Product Variant Barcode Required" +msgstr "Codice a barre variante prodoto richiesto" + +#. module: product_barcode_required +#: model_terms:ir.ui.view,arch_db:product_barcode_required.res_config_settings_view_form +msgid "Products barcode" +msgstr "Codice a barre prodotto" + +#. module: product_barcode_required +#: code:addons/product_barcode_required/models/product_barcode_mixin.py:0 +#, python-format +msgid "" +"These products have no barcode:\n" +"{}" +msgstr "" +"Questi prodotti non hanno codice a barre:\n" +"{}" diff --git a/product_barcode_required/i18n/product_barcode_required.pot b/product_barcode_required/i18n/product_barcode_required.pot new file mode 100644 index 00000000000..dcb28e09d43 --- /dev/null +++ b/product_barcode_required/i18n/product_barcode_required.pot @@ -0,0 +1,76 @@ +# Translation of Odoo Server. +# This file contains the translation of the following modules: +# * product_barcode_required +# +msgid "" +msgstr "" +"Project-Id-Version: Odoo Server 18.0\n" +"Report-Msgid-Bugs-To: \n" +"Last-Translator: \n" +"Language-Team: \n" +"MIME-Version: 1.0\n" +"Content-Type: text/plain; charset=UTF-8\n" +"Content-Transfer-Encoding: \n" +"Plural-Forms: \n" + +#. module: product_barcode_required +#: model:ir.model,name:product_barcode_required.model_product_barcode_required_mixin +msgid "Barcode required mixin" +msgstr "" + +#. module: product_barcode_required +#: model:ir.model,name:product_barcode_required.model_res_company +msgid "Companies" +msgstr "" + +#. module: product_barcode_required +#: model:ir.model,name:product_barcode_required.model_res_config_settings +msgid "Config Settings" +msgstr "" + +#. module: product_barcode_required +#: model:ir.model.fields,field_description:product_barcode_required.field_product_barcode_required_mixin__is_barcode_required +#: model:ir.model.fields,field_description:product_barcode_required.field_product_product__is_barcode_required +#: model:ir.model.fields,field_description:product_barcode_required.field_product_template__is_barcode_required +msgid "Is Barcode Required" +msgstr "" + +#. module: product_barcode_required +#: model_terms:ir.ui.view,arch_db:product_barcode_required.res_config_settings_view_form +msgid "Make barcode required." +msgstr "" + +#. module: product_barcode_required +#: model:ir.model.fields,help:product_barcode_required.field_res_company__product_variant_barcode_required +#: model:ir.model.fields,help:product_barcode_required.field_res_config_settings__product_variant_barcode_required +msgid "Make variant barcode required" +msgstr "" + +#. module: product_barcode_required +#: model:ir.model,name:product_barcode_required.model_product_template +msgid "Product" +msgstr "" + +#. module: product_barcode_required +#: model:ir.model,name:product_barcode_required.model_product_product +msgid "Product Variant" +msgstr "" + +#. module: product_barcode_required +#: model:ir.model.fields,field_description:product_barcode_required.field_res_company__product_variant_barcode_required +#: model:ir.model.fields,field_description:product_barcode_required.field_res_config_settings__product_variant_barcode_required +msgid "Product Variant Barcode Required" +msgstr "" + +#. module: product_barcode_required +#: model_terms:ir.ui.view,arch_db:product_barcode_required.res_config_settings_view_form +msgid "Products barcode" +msgstr "" + +#. module: product_barcode_required +#. odoo-python +#: code:addons/product_barcode_required/models/product_barcode_mixin.py:0 +msgid "" +"These products have no barcode:\n" +"{}" +msgstr "" diff --git a/product_barcode_required/models/__init__.py b/product_barcode_required/models/__init__.py new file mode 100644 index 00000000000..cca1a20bfd0 --- /dev/null +++ b/product_barcode_required/models/__init__.py @@ -0,0 +1,5 @@ +from . import res_company +from . import res_config_settings +from . import product_barcode_mixin +from . import product_template +from . import product_product diff --git a/product_barcode_required/models/product_barcode_mixin.py b/product_barcode_required/models/product_barcode_mixin.py new file mode 100644 index 00000000000..aa61622d0f9 --- /dev/null +++ b/product_barcode_required/models/product_barcode_mixin.py @@ -0,0 +1,53 @@ +# Copyright 2020 Camptocamp SA +# @author Simone Orsi +# License LGPL-3.0 or later (https://www.gnu.org/licenses/lgpl) + +from odoo import api, exceptions, fields, models + + +class BarcodeRequiredMixin(models.AbstractModel): + _name = "product.barcode.required.mixin" + _description = "Barcode required mixin" + + is_barcode_required = fields.Boolean(compute="_compute_is_barcode_required") + + @api.onchange("default_code") + def _onchange_code(self): + for rec in self: + if rec.is_barcode_required and rec.default_code: + rec.barcode = rec.default_code + + @api.depends("type", "barcode") + def _compute_is_barcode_required(self): + for rec in self: + rec.is_barcode_required = rec._is_barcode_required() + + def _is_barcode_required(self): + return self._is_barcode_required_enabled() and self._is_barcode_missing() + + def _is_barcode_missing(self): + self.ensure_one() + return self.type != "service" and not self.barcode + + def _is_barcode_required_enabled(self): + return self.env.company.product_variant_barcode_required + + def _check_barcode_required(self): + """Check if barcode required, to be used in your own constraint.""" + if self.env.context.get("_bypass_barcode_required_check"): + return + + # Make error nicer up to 30 records. + failing = [ + x.display_name + for x in self[:30] + if x.is_barcode_required and x.display_name + ] + if failing: + failed_list = "\n * " + "\n * ".join(failing) + raise exceptions.ValidationError( + self.env._( + "These products have no barcode:\n%s", + failed_list, + ) + ) diff --git a/product_barcode_required/models/product_product.py b/product_barcode_required/models/product_product.py new file mode 100644 index 00000000000..f007dd7d3c4 --- /dev/null +++ b/product_barcode_required/models/product_product.py @@ -0,0 +1,28 @@ +# Copyright 2020 Camptocamp SA +# @author Simone Orsi +# License LGPL-3.0 or later (https://www.gnu.org/licenses/lgpl) + +from odoo import api, models + + +class ProductProduct(models.Model): + _name = "product.product" + _inherit = ["product.product", "product.barcode.required.mixin"] + + @api.model_create_multi + def create(self, vals_list): + recs = super().create(vals_list) + # Try to limit exceptions if we can compute the barcode + # when products are created via code. + recs._onchange_code() + # When automatically created from a template + # the barcode is not propagated from the template to the variants, + # thus is pointless to check because it will always fail. + recs._check_barcode_required() + return recs + + def write(self, vals): + res = super().write(vals) + self._onchange_code() + self._check_barcode_required() + return res diff --git a/product_barcode_required/models/product_template.py b/product_barcode_required/models/product_template.py new file mode 100644 index 00000000000..465230aa179 --- /dev/null +++ b/product_barcode_required/models/product_template.py @@ -0,0 +1,26 @@ +# Copyright 2020 Camptocamp SA +# @author Simone Orsi +# License LGPL-3.0 or later (https://www.gnu.org/licenses/lgpl) + +from odoo import api, models + + +class ProductTemplate(models.Model): + _name = "product.template" + _inherit = ["product.template", "product.barcode.required.mixin"] + + @api.model_create_multi + def create(self, vals_list): + return super( + ProductTemplate, self.with_context(_bypass_barcode_required_check=True) + ).create(vals_list) + + def write(self, vals): + return super( + ProductTemplate, self.with_context(_bypass_barcode_required_check=True) + ).write(vals) + + def _is_barcode_required(self): + if self.product_variant_count > 1: + return False + return super()._is_barcode_required() diff --git a/product_barcode_required/models/res_company.py b/product_barcode_required/models/res_company.py new file mode 100644 index 00000000000..408be371f88 --- /dev/null +++ b/product_barcode_required/models/res_company.py @@ -0,0 +1,13 @@ +# Copyright 2020 Camptocamp SA +# @author Simone Orsi +# License LGPL-3.0 or later (https://www.gnu.org/licenses/lgpl) + +from odoo import fields, models + + +class ResCompany(models.Model): + _inherit = "res.company" + + product_variant_barcode_required = fields.Boolean( + help="Make variant barcode required", groups="product.group_product_variant" + ) diff --git a/product_barcode_required/models/res_config_settings.py b/product_barcode_required/models/res_config_settings.py new file mode 100644 index 00000000000..81a3c1a6f62 --- /dev/null +++ b/product_barcode_required/models/res_config_settings.py @@ -0,0 +1,15 @@ +# Copyright 2020 Camptocamp SA +# @author Simone Orsi +# License LGPL-3.0 or later (https://www.gnu.org/licenses/lgpl) + +from odoo import fields, models + + +class ResConfigSettings(models.TransientModel): + _inherit = "res.config.settings" + + product_variant_barcode_required = fields.Boolean( + related="company_id.product_variant_barcode_required", + readonly=False, + groups="product.group_product_variant", + ) diff --git a/product_barcode_required/pyproject.toml b/product_barcode_required/pyproject.toml new file mode 100644 index 00000000000..4231d0cccb3 --- /dev/null +++ b/product_barcode_required/pyproject.toml @@ -0,0 +1,3 @@ +[build-system] +requires = ["whool"] +build-backend = "whool.buildapi" diff --git a/product_barcode_required/readme/CONFIGURE.md b/product_barcode_required/readme/CONFIGURE.md new file mode 100644 index 00000000000..cbdd1c2bd84 --- /dev/null +++ b/product_barcode_required/readme/CONFIGURE.md @@ -0,0 +1,2 @@ +Go to "Settings -\> General -\> Products" and enable "Product variant +barcode required". diff --git a/product_barcode_required/readme/CONTRIBUTORS.md b/product_barcode_required/readme/CONTRIBUTORS.md new file mode 100644 index 00000000000..8e867bf4c36 --- /dev/null +++ b/product_barcode_required/readme/CONTRIBUTORS.md @@ -0,0 +1 @@ +- Simone Orsi \ diff --git a/product_barcode_required/readme/DESCRIPTION.md b/product_barcode_required/readme/DESCRIPTION.md new file mode 100644 index 00000000000..f6ead84e480 --- /dev/null +++ b/product_barcode_required/readme/DESCRIPTION.md @@ -0,0 +1 @@ +Makes barcode field required, defaults it to product's code. diff --git a/product_barcode_required/static/description/icon.png b/product_barcode_required/static/description/icon.png new file mode 100644 index 00000000000..3a0328b516c Binary files /dev/null and b/product_barcode_required/static/description/icon.png differ diff --git a/product_barcode_required/static/description/index.html b/product_barcode_required/static/description/index.html new file mode 100644 index 00000000000..dfef616f911 --- /dev/null +++ b/product_barcode_required/static/description/index.html @@ -0,0 +1,437 @@ + + + + + +README.rst + + + +
+ + + +Odoo Community Association + +
+

Product barcode required

+ +

Beta License: LGPL-3 OCA/product-attribute Translate me on Weblate Try me on Runboat

+

Makes barcode field required, defaults it to product’s code.

+

Table of contents

+ +
+

Configuration

+

Go to “Settings -> General -> Products” and enable “Product variant +barcode required”.

+
+
+

Bug Tracker

+

Bugs are tracked on GitHub Issues. +In case of trouble, please check there if your issue has already been reported. +If you spotted it first, help us to smash it by providing a detailed and welcomed +feedback.

+

Do not contact contributors directly about support or help with technical issues.

+
+
+

Credits

+
+

Authors

+
    +
  • Camptocamp
    • +
+
+
+

Contributors

+ +
+
+

Maintainers

+

This module is maintained by the OCA.

+ +Odoo Community Association + +

OCA, or the Odoo Community Association, is a nonprofit organization whose +mission is to support the collaborative development of Odoo features and +promote its widespread use.

+

Current maintainer:

+

simahawk

+

This module is part of the OCA/product-attribute project on GitHub.

+

You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

+
+
+
+
+ + diff --git a/product_barcode_required/tests/__init__.py b/product_barcode_required/tests/__init__.py new file mode 100644 index 00000000000..fe55ce0ef3c --- /dev/null +++ b/product_barcode_required/tests/__init__.py @@ -0,0 +1 @@ +from . import test_barcode diff --git a/product_barcode_required/tests/test_barcode.py b/product_barcode_required/tests/test_barcode.py new file mode 100644 index 00000000000..205b2191ef8 --- /dev/null +++ b/product_barcode_required/tests/test_barcode.py @@ -0,0 +1,161 @@ +# Copyright 2020 Camptocamp SA +# @author Simone Orsi +# License LGPL-3.0 or later (https://www.gnu.org/licenses/lgpl) +from odoo import exceptions +from odoo.tests import Form + +from odoo.addons.base.tests.common import BaseCommon + + +class TestBarcodeDefault(BaseCommon): + def test_barcode_is_not_required(self): + self.assertFalse(self.env["product.template"]._is_barcode_required_enabled()) + self.assertFalse(self.env["product.product"]._is_barcode_required_enabled()) + + def test_onchange_default_template(self): + """Nothing changes since the constraint is not enabled.""" + form = Form(self.env["product.template"]) + form.name = "Prod A" + form.default_code = "PROD-A" + self.assertFalse(form.barcode) + record = form.save() + self.assertFalse(record.barcode) + + def test_onchange_default_variant(self): + """Nothing changes since the constraint is not enabled.""" + form = Form(self.env["product.product"]) + form.name = "Prod A" + form.default_code = "PROD-A" + self.assertFalse(form.barcode) + record = form.save() + self.assertFalse(record.barcode) + + +class TestBarcodeTemplateRequired(BaseCommon): + @classmethod + def setUpClass(cls): + super().setUpClass() + cls.env.user.group_ids += cls.env.ref("product.group_product_variant") + cls.env.company.product_variant_barcode_required = True + cls.product_attribute = cls.env["product.attribute"].create( + {"name": "Test Attribute"} + ) + cls.product_attribute_value_1 = cls.env["product.attribute.value"].create( + { + "name": "Value 1", + "attribute_id": cls.product_attribute.id, + } + ) + cls.product_attribute_value_2 = cls.env["product.attribute.value"].create( + { + "name": "Value 2", + "attribute_id": cls.product_attribute.id, + } + ) + + def test_barcode_is_required(self): + self.assertTrue(self.env["product.template"]._is_barcode_required_enabled()) + self.assertTrue(self.env["product.product"]._is_barcode_required_enabled()) + + def test_onchange_required_template(self): + """Requirement enabled, default barcode to default_code.""" + form = Form(self.env["product.template"]) + form.name = "Prod A" + form.default_code = "PROD-A" + self.assertEqual(form.barcode, "PROD-A") + record = form.save() + self.assertEqual(record.barcode, "PROD-A") + + def test_required_template(self): + """Requirement enabled, template needs it only if 1 variant is there.""" + tmpl = self.env["product.template"].create({"name": "Foo"}) + self.assertTrue(tmpl.is_barcode_required) + # Add a variant + self.env["product.product"].create( + { + "name": "another test variant", + "barcode": "baz", + "default_code": "yeah", + "product_tmpl_id": tmpl.id, + } + ) + self.assertFalse(tmpl.is_barcode_required) + + def test_onchange_required_variant(self): + """Requirement enabled, default barcode to default_code.""" + form = Form(self.env["product.product"]) + form.name = "Prod A" + form.default_code = "PROD-A" + self.assertEqual(form.barcode, "PROD-A") + record = form.save() + self.assertEqual(record.barcode, "PROD-A") + + def test_validation_create(self): + """Cannot create a record w/out barcode as constraint is enabled.""" + with self.assertRaises(exceptions.ValidationError) as err: + self.env["product.product"].create( + [{"name": "Variant A"}, {"name": "Variant B"}, {"name": "Variant C"}] + ) + self.assertEqual( + err.exception.args[0], + "These products have no barcode:" + "\n\n * Variant A\n * Variant B\n * Variant C", + ) + # Defaults to default_code if not passed explicitly + prod1 = self.env["product.product"].create( + {"name": "Variant A", "default_code": "VAR-A"} + ) + self.assertEqual(prod1.barcode, prod1.default_code) + # pass it at creation, value is kept + prod2 = self.env["product.product"].create( + {"name": "Variant A", "default_code": "VAR-A", "barcode": "VAR-A-XYZ"} + ) + self.assertEqual(prod2.barcode, "VAR-A-XYZ") + + def test_validation_write(self): + """Cannot write a record w/out barcode as constraint is enabled.""" + prod = self.env["product.product"].create( + {"name": "Variant A", "default_code": "VAR-A", "barcode": "VAR-A"} + ) + # If you unset the barcode, it will be rolled back to default_code + prod.barcode = False + self.assertEqual(prod.barcode, "VAR-A") + # Unless you unset both + with self.assertRaises(exceptions.ValidationError) as err: + prod.write({"default_code": False, "barcode": False}) + + self.assertEqual( + err.exception.args[0], "These products have no barcode:\n\n * Variant A" + ) + + def test_create_variant_from_template(self): + """Barcode does not propagate from template to variants.""" + with Form(self.env["product.template"]) as template_form: + template_form.name = "Test Product" + self.assertTrue(template_form.is_barcode_required) + template_form.default_code = "TEST-PRODUCT" + with template_form.attribute_line_ids.new() as line: + line.attribute_id = self.product_attribute + line.value_ids.add(self.product_attribute_value_1) + line.value_ids.add(self.product_attribute_value_2) + + product_template = template_form.save() + + self.assertFalse(product_template.is_barcode_required) + self.assertEqual(len(product_template.product_variant_ids), 2) + + for variant in product_template.product_variant_ids: + self.assertEqual(len(variant.product_template_attribute_value_ids), 1) + self.assertIn( + variant.product_template_attribute_value_ids.product_attribute_value_id, + [self.product_attribute_value_1, self.product_attribute_value_2], + ) + self.assertFalse(variant.barcode) + self.assertTrue(variant.is_barcode_required) + + def test_create_variant_from_template_barcode_error(self): + """Variant created from template should have barcode set to default_code. ?""" + with self.assertRaises(AssertionError): + with Form(self.env["product.template"]) as template_form: + template_form.name = "Test Product Raise Error" + self.assertTrue(template_form.is_barcode_required) diff --git a/product_barcode_required/views/product_template_view.xml b/product_barcode_required/views/product_template_view.xml new file mode 100644 index 00000000000..c7baf3fb08e --- /dev/null +++ b/product_barcode_required/views/product_template_view.xml @@ -0,0 +1,19 @@ + + + + product.template.product.form (from product_barcode_required) + product.template + + + + + product_variant_count > 1 + is_barcode_required + + + + diff --git a/product_barcode_required/views/product_view.xml b/product_barcode_required/views/product_view.xml new file mode 100644 index 00000000000..db98f2b2669 --- /dev/null +++ b/product_barcode_required/views/product_view.xml @@ -0,0 +1,25 @@ + + + + product.product.view.form.easy (from product_barcode_required) + product.product + + + + is_barcode_required + + + + + product.product.form (from product_barcode_required) + product.product + + + + is_barcode_required + + + + diff --git a/product_barcode_required/views/res_config_settings.xml b/product_barcode_required/views/res_config_settings.xml new file mode 100644 index 00000000000..90cf1776971 --- /dev/null +++ b/product_barcode_required/views/res_config_settings.xml @@ -0,0 +1,27 @@ + + + + res.config.settings + + + + +

Products barcode

+
+
+
+ +
+
+
+
+
+ + + +