Skip to content

Add release notarization step#67

Open
jmcte wants to merge 6 commits into
mainfrom
codex/issue-7-release-notarization
Open

Add release notarization step#67
jmcte wants to merge 6 commits into
mainfrom
codex/issue-7-release-notarization

Conversation

@jmcte
Copy link
Copy Markdown
Contributor

@jmcte jmcte commented May 23, 2026

Summary

Adds the release notarization path for APW.app.

Closes #7.

Changes

  • Adds scripts/notarize-native-app.sh to import the Developer ID certificate into a temporary keychain, sign the release CLI and APW.app, submit the app bundle to Apple Notary Service, staple the ticket, and run Gatekeeper assessment.
  • Wires .github/workflows/release.yml to run notarization on tagged releases before packaging the release archive.
  • Keeps Apple credentials optional: incomplete credentials emit a GitHub warning and skip notarization instead of failing unrelated release automation.
  • Removes the unused APPLE_TEAM_ID gate from the script, workflow env, docs, and dry-run test so releases with all actually-used credentials do not skip notarization.
  • Adds a regression check that scripts/notarize-native-app.sh does not require APPLE_TEAM_ID, and separates codesigning inputs from notarytool App Store Connect API key inputs.
  • Retries interrupted UDP send/receive calls in the native daemon test helper after the CI lint workflow exposed an EINTR unwrap in the test path.
  • Adds scripts/test-notarize-native-app.sh and runs it from fast checks to cover missing-required, missing-optional, and dry-run credential paths.
  • Documents the release behavior in installation and bootstrap onboarding docs.

Verification

  • bash -n scripts/notarize-native-app.sh scripts/test-notarize-native-app.sh passed.
  • ./scripts/test-notarize-native-app.sh passed.
  • cargo test --manifest-path rust/Cargo.toml daemon::tests::start_daemon_native_routes_requests_and_tracks_host_disconnect -- --nocapture passed outside the sandbox.
  • cargo clippy --manifest-path rust/Cargo.toml --all-targets -- -D warnings passed.
  • bash scripts/ci/run-fast-checks.sh passed.
  • ruby -e 'require "yaml"; YAML.load_file(".github/workflows/release.yml"); puts "release.yml parses"' passed.
  • git diff --check passed.

Notes

The branch commit was created with --no-gpg-sign because gitsign OAuth is not usable in this non-interactive shell. No Apple credentials or auth material are committed.

@jmcte jmcte requested a review from pheidon as a code owner May 23, 2026 21:23
@athena-omt athena-omt added area:infra Infrastructure, CI, release, governance, scripts, or repo setup. lane:hephaestus Hephaestus build/repo-ops lane. review:athena Athena review governance requested. risk:medium Medium-risk change; normal care required. state:waiting-checks Waiting for CI/check status to settle. status:needs-review PR is ready for Athena review. labels May 23, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f318eac6a0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/notarize-native-app.sh Outdated
Comment on lines +10 to +14
required_env=(
APPLE_DEVELOPER_CERT_P12
APPLE_CERT_PASSWORD
APPLE_TEAM_ID
APPLE_NOTARY_KEY_ID
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove unused APPLE_TEAM_ID from required credentials

Including APPLE_TEAM_ID in required_env causes the script to skip notarization whenever that secret is unset, even though the value is never consumed by signing or notarytool submission in this script. In repos that provide the cert and notary API key material but omit APPLE_TEAM_ID, tagged releases will silently publish without notarization/stapling despite having all actually-used inputs configured.

Useful? React with 👍 / 👎.

@pheidon pheidon added state:needs-repair PR needs repair before review can proceed. codex:P2 Codex Connector P2 finding. priority:P2 Codex Connector P2; blocks execution until Athena validates. and removed state:waiting-checks Waiting for CI/check status to settle. labels May 24, 2026
…-notarization

# Conflicts:
#	scripts/ci/run-fast-checks.sh
@athena-omt athena-omt added the state:waiting-checks Waiting for CI/check status to settle. label May 24, 2026
jmcte added 4 commits May 24, 2026 06:35
Document that notarytool uses App Store Connect API key credentials and add a regression check that the script does not require an unused Apple Team ID variable.
Separate codesigning and notarytool credentials before assembling the required environment list so the notarization contract reflects only actually consumed inputs.
Handle EINTR while sending and receiving UDP datagrams in the native daemon test helper so CI signal delivery does not fail the lint workflow test run.
@jmcte jmcte removed state:waiting-checks Waiting for CI/check status to settle. state:needs-repair PR needs repair before review can proceed. labels May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:infra Infrastructure, CI, release, governance, scripts, or repo setup. codex:P2 Codex Connector P2 finding. lane:hephaestus Hephaestus build/repo-ops lane. priority:P2 Codex Connector P2; blocks execution until Athena validates. review:athena Athena review governance requested. risk:medium Medium-risk change; normal care required. status:needs-review PR is ready for Athena review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: add Apple notarization step to release CI pipeline

3 participants