Skip to content

Remove legacy daemon CLI commands#74

Open
jmcte wants to merge 3 commits into
mainfrom
codex/issue-46-remove-legacy-commands
Open

Remove legacy daemon CLI commands#74
jmcte wants to merge 3 commits into
mainfrom
codex/issue-46-remove-legacy-commands

Conversation

@jmcte
Copy link
Copy Markdown
Contributor

@jmcte jmcte commented May 23, 2026

Summary

  • Removes apw auth, apw pw, apw otp, and apw start from the active Rust CLI command enum and deletes their direct handlers.
  • Updates migration docs and README to state that the legacy daemon commands are removed for the v2.1 cliff.
  • Replaces legacy command parity coverage with removed-command regression checks and updates security regressions to use supported v2 entrypoints.
  • Keeps legacy daemon/client internals compiled for status/parity diagnostics until the separate archive work in Roadmap (v2.1.0): archive browser-bridge, native-host helper, and launchd runtime modes #47.

Closes #46.

Verification

  • cargo fmt --manifest-path rust/Cargo.toml -- --check
  • bash scripts/ci/run-fast-checks.sh
  • cargo clippy --manifest-path rust/Cargo.toml --all-targets -- -D warnings
  • cargo test --manifest-path rust/Cargo.toml --test legacy_parity
  • cargo test --manifest-path rust/Cargo.toml --test security_regressions
  • cargo test --manifest-path rust/Cargo.toml --bin apw
    • passed outside sandbox; sandboxed run hit local socket/temp runtime permission failures
  • git diff --check

Notes

@jmcte jmcte requested a review from pheidon as a code owner May 23, 2026 23:10
@athena-omt athena-omt added area:infra Infrastructure, CI, release, governance, scripts, or repo setup. lane:daedalus Daedalus implementation/forge lane. review:athena Athena review governance requested. risk:medium Medium-risk change; normal care required. state:waiting-checks Waiting for CI/check status to settle. status:needs-review PR is ready for Athena review. labels May 23, 2026
Drop auth, pw, otp, and start from the active Rust CLI, update migration docs, and replace legacy command parity coverage with removed-command regression checks.

Closes #46.
@jmcte jmcte force-pushed the codex/issue-46-remove-legacy-commands branch from edcf56c to e595116 Compare May 23, 2026 23:12
pheidon
pheidon previously approved these changes May 24, 2026
Copy link
Copy Markdown
Contributor

@pheidon pheidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from Pheidon second-pass review. The legacy daemon CLI removal matches the v2 migration docs, replaces parity coverage with removed-command regressions, and CI/Rust checks are green. Merge ordering may need normal conflict handling with adjacent command-removal PRs.

@jmcte jmcte enabled auto-merge (squash) May 24, 2026 01:53
…-legacy-commands

# Conflicts:
#	README.md
#	docs/MIGRATION_AND_PARITY.md
#	docs/NATIVE_MIGRATION.md
#	docs/NATIVE_ONLY_REDESIGN.md
#	rust/src/cli.rs
#	rust/tests/legacy_parity.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:infra Infrastructure, CI, release, governance, scripts, or repo setup. lane:daedalus Daedalus implementation/forge lane. review:athena Athena review governance requested. risk:medium Medium-risk change; normal care required. status:needs-review PR is ready for Athena review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Roadmap (v2.1.0): hard-remove deprecated legacy daemon commands

3 participants