Remove legacy daemon CLI commands#74
Open
jmcte wants to merge 3 commits into
Open
Conversation
Drop auth, pw, otp, and start from the active Rust CLI, update migration docs, and replace legacy command parity coverage with removed-command regression checks. Closes #46.
edcf56c to
e595116
Compare
pheidon
previously approved these changes
May 24, 2026
Contributor
pheidon
left a comment
There was a problem hiding this comment.
Approved from Pheidon second-pass review. The legacy daemon CLI removal matches the v2 migration docs, replaces parity coverage with removed-command regressions, and CI/Rust checks are green. Merge ordering may need normal conflict handling with adjacent command-removal PRs.
…-legacy-commands # Conflicts: # README.md # docs/MIGRATION_AND_PARITY.md # docs/NATIVE_MIGRATION.md # docs/NATIVE_ONLY_REDESIGN.md # rust/src/cli.rs # rust/tests/legacy_parity.rs
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apw auth,apw pw,apw otp, andapw startfrom the active Rust CLI command enum and deletes their direct handlers.Closes #46.
Verification
cargo fmt --manifest-path rust/Cargo.toml -- --checkbash scripts/ci/run-fast-checks.shcargo clippy --manifest-path rust/Cargo.toml --all-targets -- -D warningscargo test --manifest-path rust/Cargo.toml --test legacy_paritycargo test --manifest-path rust/Cargo.toml --test security_regressionscargo test --manifest-path rust/Cargo.toml --bin apwgit diff --checkNotes