Add native app signing preflight#78
Open
jmcte wants to merge 3 commits into
Open
Conversation
Closes #52. Runs native app Swift tests through xcodebuild in the PR macOS lane, signs APW.app with the associated-domain entitlement during bundle construction, and adds an extended-validation preflight that verifies xcodebuild tests, codesign, and embedded entitlements. Also hardens macOS OpenSSL discovery so an x86 Homebrew prefix cannot poison arm64 extended validation.
athena-omt
added
area:infra
pheidon
previously approved these changes
May 24, 2026
Contributor
pheidon
left a comment
pheidon
left a comment
There was a problem hiding this comment.
Approved from Pheidon second-pass review. Native-app signing preflight adds xcodebuild/codesign/entitlement validation, and the full PR Fast CI, Rust, and Native App Swift checks are green.
…-preflight # Conflicts: # docs/bootstrap/onboarding.md # scripts/ci/run-extended-validation.sh
pheidon
approved these changes
May 24, 2026
Contributor
pheidon
left a comment
pheidon
left a comment
There was a problem hiding this comment.
Approved from Pheidon sweep. Signing preflight changes remain scoped to validation scripts/entitlements/docs and all required checks are green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xcodebuildin the PR macOS lane.native-app/APW.entitlementsand signsAPW.appwith thewebcredentials:example.comassociated-domain entitlement during bundle construction.scripts/ci/run-native-app-preflight.shto build/test/sign the native app, verify codesign, and compare the signed associated-domain entitlement block againstnative-app/APW.entitlements.Closes #52.
Verification
xcodebuild -scheme APW-Package -destination platform=macOS -derivedDataPath .xcode-derived testbash -n scripts/ci/run-native-app-preflight.sh scripts/test-native-app-preflight-config.sh scripts/ci/run-fast-checks.shbash scripts/test-native-app-preflight-config.shbash scripts/ci/run-fast-checks.shbash scripts/ci/run-native-app-preflight.sh(outside sandbox; xcodebuild/SwiftPM need user cache access)git diff --checkbash scripts/ci/run-extended-validation.shNotes
xcodebuildand that release preflight now verifies codesign plus associated-domain entitlements before tag/release.