Skip to content

Route fill through native credential broker#82

Open
jmcte wants to merge 3 commits into
mainfrom
codex/issue-13-fill-broker
Open

Route fill through native credential broker#82
jmcte wants to merge 3 commits into
mainfrom
codex/issue-13-fill-broker

Conversation

@jmcte
Copy link
Copy Markdown
Contributor

@jmcte jmcte commented May 24, 2026

Summary

  • routes Swift broker fill requests through the same injected credential broker path as login
  • preserves the request intent in successful broker responses for both login and fill
  • expands Swift coverage for fill failure mapping, non-demo credentials.json isolation, and AuthenticationServices broker routing
  • collapses SDK-specific ASAuthorizationError cases into the stable unknown broker code and documents the wire-contract behavior

Related issue: #13.

This does not complete the notarized hardware validation tracked by #43.

Verification

  • bash scripts/ci/run-fast-checks.sh - passed
  • swift test --package-path native-app - passed, 17 tests
  • bash scripts/build-native-app.sh - passed
  • cargo test --manifest-path rust/Cargo.toml --test native_app_e2e -- --test-threads=1 - passed, 12 tests
  • git diff --check - passed

Notes

  • The sandboxed native_app_e2e run could not bind the fake broker UNIX socket (PermissionError: Operation not permitted). The same suite passed outside the sandbox.

@jmcte jmcte requested a review from pheidon as a code owner May 24, 2026 00:48
@athena-omt athena-omt added area:data Data, schema, storage, privacy, or migration surface. lane:daedalus Daedalus implementation/forge lane. review:athena Athena review governance requested. risk:medium Medium-risk change; normal care required. state:waiting-checks Waiting for CI/check status to settle. status:needs-review PR is ready for Athena review. labels May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:data Data, schema, storage, privacy, or migration surface. lane:daedalus Daedalus implementation/forge lane. review:athena Athena review governance requested. risk:medium Medium-risk change; normal care required. status:needs-review PR is ready for Athena review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants