Add coverage CRAP indicators#46
Merged
Merged
Conversation
pheidon
approved these changes
May 24, 2026
Contributor
pheidon
left a comment
There was a problem hiding this comment.
Approved from Pheidon second-pass review. The coverage indicator helper preserves the existing coverage gate, adds fixture-backed shell regression coverage, and live CI Gate checks are green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Governing Issue
No open GitHub issues exist for
OMT-Global/icloud-clias of the live check on 2026-05-23 (gh issue list --repo OMT-Global/icloud-cli --state open --limit 50returned[]), so this PR is intentionally unlinked.Validation
CI GateCommands run:
bash scripts/ci/test-coverage-indicators.sh- passedbash scripts/ci/check-shell-syntax.sh- passedbash scripts/ci/check-ci-policy.sh- passedbash scripts/check-detect-secrets.sh --all-files- passedbash scripts/check-privacy-fixtures.sh- passedenv CLANG_MODULE_CACHE_PATH=/Users/johnteneyckjr./src/omt-global/icloud-cli/.build/module-cache SWIFTPM_MODULECACHE_OVERRIDE=/Users/johnteneyckjr./src/omt-global/icloud-cli/.build/module-cache swift test --disable-sandbox- passed, 49 testsenv SWIFT_FLAGS=--disable-sandbox bash scripts/ci/check-coverage.sh- passed, source line coverage 68.28% with CRAP indicators emittedenv SWIFT_FLAGS=--disable-sandbox bash scripts/ci/run-mutation-smoke.sh- passed, 4 mutants killedenv CLANG_MODULE_CACHE_PATH=/Users/johnteneyckjr./src/omt-global/icloud-cli/.build/module-cache SWIFTPM_MODULECACHE_OVERRIDE=/Users/johnteneyckjr./src/omt-global/icloud-cli/.build/module-cache swift build --disable-sandbox- passedgit diff --check- passedSkipped:
bash scripts/ci/run-fast-checks.shwas not run end-to-end locally because this host requiresswift --disable-sandbox; the equivalent component checks above were run with the necessary SwiftPM flag.Bootstrap Governance
CONTRIBUTING.md,.github/PULL_REQUEST_TEMPLATE.md, anddocs/bootstrap/onboarding.mdwhen applicableFlow Contract
Flow Merge Readiness
Merge Automation
Notes
gitsigntimed out waiting for browser OAuth, so commit1ceb7b8was created with--no-gpg-sign.