Make LLM extraction optional#90
Open
jmcte wants to merge 1 commit into
Open
Conversation
athena-omt
added
area:ai
pheidon
approved these changes
May 23, 2026
pheidon
left a comment
pheidon
left a comment
There was a problem hiding this comment.
Approved from Pheidon second-pass review. I found no code-level blocker in the optional LLM extraction path, and local fast checks passed (122 tests). Merge should still wait for required GitHub CI to complete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
llmextra so base installs remain deterministic-onlyLLMNotAvailablefailures for missing SDK or missingANTHROPIC_API_KEY--model-ready argument precedence overMAILPLUS_LLM_MODELand the default constantmpi doctorVerification
PYTHONPATH=src python3.12 -m unittest discover -s tests -p 'test_llm_extractor.py' -vPYTHONPATH=src python3.12 -m unittest discover -s tests -p 'test_doctor.py' -vbash scripts/ci/run-fast-checks.shCloses #83.