Document v0.1 scope and integration stubs#91
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 834af0ae43
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return SyncBatch( | ||
| source_name=f"mailplus:{config.user}", | ||
| cursor=cursor, | ||
| next_cursor="123", |
There was a problem hiding this comment.
Update SyncBatch example to avoid invalid next_cursor arg
The worked IMAP stub currently constructs SyncBatch with next_cursor, but SyncBatch only defines source_name, cursor, and messages in src/mailplus_intelligence/sync.py (SyncBatch dataclass). Anyone implementing Phase 2 by following this guide will hit TypeError: __init__() got an unexpected keyword argument 'next_cursor' at runtime, so the integration instructions are not executable as written.
Useful? React with 👍 / 👎.
Summary
mailplus_intelligence.__version__from package metadataVerification
PYTHONPATH=src python3.12 -m unittest discover -s tests -p 'test_runtime.py' -vbash scripts/ci/run-fast-checks.shCloses #85.