Dear @WarmCyan, I am the reviewer of your JOSS submission.
I run into problems after setting up the environment. When running icat.initialize(offline=True), the following errors occur:
One way to reproduce:
git clone https://github.com/ORNL/icat.git
cd icat
conda env create --file environment.yml # to set the right python version in a fresh virtual environment
conda activate icat
conda install pip
pip install icat-iml
conda install jupyter_bokeh # necessary after ModuleNotFoundError
pip install ipywidgets-bokeh # necessary after ModuleNotFoundError
pip install -r requirements.txt # tried that for debugging, didn't help
As a first suggestion, you might want to add ipywidgets-bokehto requirements.txt and jupyter_bokeh to environment.yml (or both to requirements.txt). Secondly, I would recommend to run the setup by yourself from scratch the way I did it, which is quite close to your documentation. Alternatively, you might want to give me feedback where I made something wrong during the setup.
I put the JOSS submission review on hold and try again next weekend. Please tag me here or in the review thread if you have updates or suggestions. Thanks!
Dear @WarmCyan, I am the reviewer of your JOSS submission.
I run into problems after setting up the environment. When running
icat.initialize(offline=True), the following errors occur:One way to reproduce:
As a first suggestion, you might want to add
ipywidgets-bokehto requirements.txt andjupyter_bokehto environment.yml (or both to requirements.txt). Secondly, I would recommend to run the setup by yourself from scratch the way I did it, which is quite close to your documentation. Alternatively, you might want to give me feedback where I made something wrong during the setup.I put the JOSS submission review on hold and try again next weekend. Please tag me here or in the review thread if you have updates or suggestions. Thanks!