Follow JavaScript Best Practices

[Ol-create]

Hi there 👋 , here is a link to review I gave @vigehi on Follow JavaScript Best Practices

Thank you very much 👍

Hi @Ol-create 👋 ,
I just wanted to say well done on the work you've completed so far. I'm really impressed with your progress and dedication to this project. Keep up the great work! 👍

That being said, there are still a few issues that need to be addressed before we can move on to the next phase.
I'm confident that you're up to the task and look forward to seeing your continued progress.

To highlight 🎯

All linters are passing ✔️
Good commit history ✔️
Good PR description ✔️

Required Changes ♻️

Check the comments under the review.

1. Good job so far. You have followed best practices in your index.html file.
   (a) Your code does not contain blank lines, spaces, or indentations.
   (b) Your lines of code are not too long (100 characters or more).
   (c) You have used HTML5 semantic tags properly.
   (d) All HTML elements closed.

2. You have followed best practices in your style.css file.
   (a) Do not use inline styles.
   (b) You do not overuse !important rule in your CSS style definitions.
   (c) I have suggested using the class attribute for multiple elements:

   • I will like you to consider refactoring the following property: "display: flex", "align-items: center",
     - "color: #555" and "justify-content: space-between".
     See for example:
     

     To-Do-List/src/style.css

     Lines 12 to 14 in f1fa375

     	display: flex;
     	justify-content: space-between;
     	align-items: center;

3. You can use forEach to replace for loop in your code:

• It increases the abstraction level.
• It also eliminates the possibility of bugs and makes the code more readable.
  See for example:
  

  To-Do-List/src/modules/eventListeners.js

  Line 87 in f1fa375

  for (let i = 0; i < tasks.activities.length; i += 1) {

4. You have done very in organising your code into smaller reusable components.

• I will like to suggest you rename you source code module extension with .mjs
• An MJS file is a source code file containing an ES Module (ECMAScript Module) for use with a Node.js application.

[Ol-create]

Hi there 👋 , Please don't forget to check this link where I gave review to @vigehi on Follow JavaScript Best Practices

Thank you very much 👍

Happy coding