From dd7a8a6ac285c670d94f009a235f48d8440b92b0 Mon Sep 17 00:00:00 2001 From: Sipke Vriend Date: Wed, 26 Nov 2025 14:57:07 +1000 Subject: [PATCH 01/13] demos: fix type in reference to exit-docker underscore used by mistake causing a missing reference warning Signed-off-by: Sipke Vriend --- demos/docker_images.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/demos/docker_images.rst b/demos/docker_images.rst index 46606b7d..361b5d1b 100644 --- a/demos/docker_images.rst +++ b/demos/docker_images.rst @@ -117,7 +117,7 @@ As part of logging you in, some guidance will be printed on how to run the demos Enjoy! dev@openamp-demo:~$ -To :ref:`exit the docker container` use key combination Ctrl-A x +To :ref:`exit the docker container` use key combination Ctrl-A x on window 0 (left tmux pane) or type exit on window 1 (top right tmux pane). We also recommend reading :ref:`Qemu Tips and Tricks` to help From 3fd95c1b583d39368e0fa4ffcd6910072f0dc8d6 Mon Sep 17 00:00:00 2001 From: Sipke Vriend Date: Wed, 26 Nov 2025 14:58:08 +1000 Subject: [PATCH 02/13] demos: fix location of linux_rpc_demo README file warning indicated that linux_rpc_demo moved location so correct link Signed-off-by: Sipke Vriend --- demos/linux_rpc.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/demos/linux_rpc.rst b/demos/linux_rpc.rst index c7da2de7..349e1631 100644 --- a/demos/linux_rpc.rst +++ b/demos/linux_rpc.rst @@ -106,4 +106,4 @@ This Linux RPC Sample is demonstrated in the following reference implementations :maxdepth: 1 :caption: Demo Compile and Execution Instructions - ../open-amp/apps/examples/linux_rpc_demo/README + ../openamp-system-reference/examples/legacy_apps/examples/linux_rpc_demo/README From 4c9f4b91150e9e294b9c2f8a26a41c7e25795ab2 Mon Sep 17 00:00:00 2001 From: Sipke Vriend Date: Wed, 26 Nov 2025 15:00:15 +1000 Subject: [PATCH 03/13] docs: fix duplicate link name to remove warning 'remoteproc code implimentation' occurred twice likely due to copy paste error, causing a non critical warning but correct anyway to reduce warning count. --- docs/data_structures_content.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/data_structures_content.rst b/docs/data_structures_content.rst index 06e98b81..be92753e 100644 --- a/docs/data_structures_content.rst +++ b/docs/data_structures_content.rst @@ -15,7 +15,7 @@ Virtio Structure for Remoteproc .. doxygenstruct:: remoteproc_virtio :members: -Refer also :openamp_doc_link:`remoteproc_virtio ` documentation and `remoteproc code implementation `_. +Refer also :openamp_doc_link:`remoteproc_virtio ` documentation and `remoteproc_virtio code implementation `_. Virtio Data Structures =========================== From d793c958af4443dc4d79e354cfaf69948eaf0e4d Mon Sep 17 00:00:00 2001 From: Sipke Vriend Date: Wed, 26 Nov 2025 15:53:12 +1000 Subject: [PATCH 04/13] Remove redundant files and associated warning warnings show that these files are not indexed and they seemed to have been orphaned, so remove them. Signed-off-by: Sipke Vriend --- docs/index.rst | 14 -------------- openamp/links.rst | 1 + openamp/meeting_notes.rst | 11 ----------- 3 files changed, 1 insertion(+), 25 deletions(-) delete mode 100644 docs/index.rst delete mode 100644 openamp/meeting_notes.rst diff --git a/docs/index.rst b/docs/index.rst deleted file mode 100644 index af92f905..00000000 --- a/docs/index.rst +++ /dev/null @@ -1,14 +0,0 @@ -.. OpenAMP documentation master file, created by - sphinx-quickstart on Wed Oct 5 10:21:26 2022. - You can adapt this file completely to your liking, but it should at least - contain the root `toctree` directive. - -OpenAMP Libraries User Guide -=========================== - -.. toctree:: - :maxdepth: 1 - :caption: Contents: - - porting_guide - diff --git a/openamp/links.rst b/openamp/links.rst index 5e60742f..8f3cd19f 100644 --- a/openamp/links.rst +++ b/openamp/links.rst @@ -7,6 +7,7 @@ Links Note: Before getting the mailing lists, we used this `OpenAMP Google Group `_. The Google Group is only listed here for reference to older content. Please use the mailing lists. + - The OpenAMP Meeting Notes: https://github.com/OpenAMP/open-amp/wiki/Meeting-Notes - The OpenAMP Source Repositories: https://github.com/OpenAMP - `OpenAMP and Heterogenous Processing Project Webinar (December 2022) `_ - `OpenAMP Elevator Pitch Slideset (2024) `_ diff --git a/openamp/meeting_notes.rst b/openamp/meeting_notes.rst deleted file mode 100644 index 2b4b047a..00000000 --- a/openamp/meeting_notes.rst +++ /dev/null @@ -1,11 +0,0 @@ -.. _meeting-notes-work-label: - -============= -Meeting Notes -============= - -Meeting_Notes_ - -.. _Meeting_Notes: https://github.com/OpenAMP/open-amp/wiki/Meeting-Notes - -TODO - Move notes to google doc drive? It may be arduous to post notes to this page \ No newline at end of file From 867ad4ad69614ac5f2cf53d374f077f9102e28cf Mon Sep 17 00:00:00 2001 From: Sipke Vriend Date: Wed, 26 Nov 2025 15:54:54 +1000 Subject: [PATCH 05/13] docs: add line between sections to remove warning missing empty line causes warning so add it to remove the warning. Signed-off-by: Sipke Vriend --- docs/remoteproc_design.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/remoteproc_design.rst b/docs/remoteproc_design.rst index c304eed6..466ab1b5 100644 --- a/docs/remoteproc_design.rst +++ b/docs/remoteproc_design.rst @@ -38,6 +38,7 @@ State Transition Remote User APIs ---------------- .. _remoteproc_config: + Configure remote ^^^^^^^^^^^^^^^^ From 8f24373805baf85ef206344e990e9346c06b127a Mon Sep 17 00:00:00 2001 From: Sipke Vriend Date: Wed, 26 Nov 2025 15:56:12 +1000 Subject: [PATCH 06/13] overview: correct README file case and link to remove warning link was incorrect as case was wrong. This removes a warning and corrects the link. Signed-off-by: Sipke Vriend --- openamp/overview.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/openamp/overview.rst b/openamp/overview.rst index e73da8cb..56cee204 100644 --- a/openamp/overview.rst +++ b/openamp/overview.rst @@ -261,7 +261,7 @@ RPC client. Libmetal ======== -:doc:`Libmetal <../libmetal/readme>` is a hardware abstraction component, intended to provide for +:doc:`Libmetal <../libmetal/README>` is a hardware abstraction component, intended to provide for portability across different platforms. Vendors porting OpenAMP will provide an implementation of libmetal for their system. From b117bb5e9ded68124c5797ecc2c6c2d0e3e45176 Mon Sep 17 00:00:00 2001 From: Sipke Vriend Date: Wed, 26 Nov 2025 15:57:20 +1000 Subject: [PATCH 07/13] overview: fix duplicate reference/link warnings A few links had duplicate names which results in a warning, so adjust the name to be unique which removes the warning. Signed-off-by: Sipke Vriend --- openamp/overview.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/openamp/overview.rst b/openamp/overview.rst index 56cee204..49f68b42 100644 --- a/openamp/overview.rst +++ b/openamp/overview.rst @@ -319,6 +319,7 @@ There are a few guiding principles, based on the :ref:`project aims`/`Virtio `_ There are a number of project members as outlined in -`OpenAMP Project Page `_ as well as many community members, +`OpenAMP Project About Page `_ as well as many community members, so please join the :ref:`OpenAMP open source project`! + - See https://github.com/OpenAMP/open-amp From 9d0284414a5b0f259bfe8e1540e6f9b83234692c Mon Sep 17 00:00:00 2001 From: Sipke Vriend Date: Wed, 26 Nov 2025 16:00:41 +1000 Subject: [PATCH 08/13] protocol_details: Use unique headings to avoid duplicate reference warning The duplicate headings result in duplicate auto generated references with associated warning, so make them unique to remove this warning. Signed-off-by: Sipke Vriend --- protocol_details/lifecyclemgmt_creation.rst | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/protocol_details/lifecyclemgmt_creation.rst b/protocol_details/lifecyclemgmt_creation.rst index 80376b5f..d84c52dc 100644 --- a/protocol_details/lifecyclemgmt_creation.rst +++ b/protocol_details/lifecyclemgmt_creation.rst @@ -16,8 +16,8 @@ Defining the Resource Table and Creating the Remote ELF Image Creating a remote image through remoteproc begins by defining the resource table and creating the remote ELF image. -Procedure -~~~~~~~~~ +Resource Table Procedure +~~~~~~~~~~~~~~~~~~~~~~~~ 1. Define the :ref:`resource table` structure in the application. The resource table must minimally contain carve-out and VirtIO device information for IPC. @@ -56,8 +56,8 @@ Making Remote Firmware Accessible to the Host After creating the remote firmware’s ELF image, you need to make it accessible to remoteproc in the host context. -Procedure -~~~~~~~~~ +Remote Firmware Procedure +~~~~~~~~~~~~~~~~~~~~~~~~~ 1. If the RTOS- or bare metal-based host software context has a file system, place this firmware ELF image in the file system. From 04d349ac0f4da2423d5cf9264ead88af3ba687a7 Mon Sep 17 00:00:00 2001 From: Sipke Vriend Date: Wed, 26 Nov 2025 16:01:28 +1000 Subject: [PATCH 09/13] protocol_details: add missing :ref: tag warning noted missing :ref: tag, so add it. Signed-off-by: Sipke Vriend --- protocol_details/system_considerations.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/protocol_details/system_considerations.rst b/protocol_details/system_considerations.rst index c2ac3323..e12d0172 100644 --- a/protocol_details/system_considerations.rst +++ b/protocol_details/system_considerations.rst @@ -14,7 +14,7 @@ Determine system topology ------------------------- The OpenAMP framework implicitly assumes a host controller to remote system architecture. The -`topology`for this architecture should be determined; either star, chain, or a combination. The +:ref:`topology` for this architecture should be determined; either star, chain, or a combination. The following figure shows some simple use cases. * Case 1 — A single host controller software context on processor 1 controlling life cycle and From d7d4892d4dbc40cbab0efd3c994a463887d214db Mon Sep 17 00:00:00 2001 From: Sipke Vriend Date: Wed, 26 Nov 2025 16:03:33 +1000 Subject: [PATCH 10/13] protocol_details: remove duplicate tag for rpmsg-protocol-work-label rpmsg-protocol-work-label was used in rpmsg_protocol.rst and rpmsg.rst so change one to remove duplication and associated warning. Signed-off-by: Sipke Vriend --- protocol_details/rpmsg_protocol.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/protocol_details/rpmsg_protocol.rst b/protocol_details/rpmsg_protocol.rst index c96deec6..0a2bd69d 100644 --- a/protocol_details/rpmsg_protocol.rst +++ b/protocol_details/rpmsg_protocol.rst @@ -1,4 +1,4 @@ -.. _rpmsg-protocol-work-label: +.. _rpmsg-layers-work-label: ===================== RPMsg Protocol Layers From 8502eb70dc3af931316d7aac87149e1ae6eeb43f Mon Sep 17 00:00:00 2001 From: Sipke Vriend Date: Wed, 26 Nov 2025 16:06:23 +1000 Subject: [PATCH 11/13] docs: remove duplicate reference to remoteproc_config function warning showed that there were two references to remoteproc_config so remove the alternate. Signed-off-by: Sipke Vriend --- docs/remoteproc_design.rst | 6 ------ 1 file changed, 6 deletions(-) diff --git a/docs/remoteproc_design.rst b/docs/remoteproc_design.rst index 466ab1b5..a9db20f2 100644 --- a/docs/remoteproc_design.rst +++ b/docs/remoteproc_design.rst @@ -39,12 +39,6 @@ Remote User APIs ---------------- .. _remoteproc_config: -Configure remote -^^^^^^^^^^^^^^^^ - -.. doxygenfunction:: remoteproc_config - :project: openamp_doc_embed - Initialize remoteproc instance ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ From 2f7ab58b40553b3a1c88dca6321b80780f046add Mon Sep 17 00:00:00 2001 From: Sipke Vriend Date: Wed, 26 Nov 2025 16:31:29 +1000 Subject: [PATCH 12/13] docs: correct end point release reference warning showed that rpmsg_ns_unbind_cb was reference twice when the second should be the release rpmsg_ept_release_cb function. Signed-off-by: Sipke Vriend --- docs/rpmsg_design.rst | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/rpmsg_design.rst b/docs/rpmsg_design.rst index 8c6f80e3..e1c6d4e2 100644 --- a/docs/rpmsg_design.rst +++ b/docs/rpmsg_design.rst @@ -113,9 +113,9 @@ RPMsg User Defined Callbacks .. doxygentypedef:: rpmsg_ns_unbind_cb :project: openamp_doc_embed -* RPMsg endpoint name service unbind callback. If user defines such callback, - when there is name service destroy arrives, it will call this callback to - notify the user application about the remote has destroyed the service.: +* RPMsg endpoint release callback. If defined by the user, + it will be called when the associated RPMsg endpoint is released, + allowing the user application to safely remove associated allocation.: -.. doxygentypedef:: rpmsg_ns_unbind_cb +.. doxygentypedef:: rpmsg_ept_release_cb :project: openamp_doc_embed From 10df77c36bad00b15c8733556c833a44efcf5bd7 Mon Sep 17 00:00:00 2001 From: Sipke Vriend Date: Wed, 26 Nov 2025 16:31:46 +1000 Subject: [PATCH 13/13] conf: exclude .venv* and _doxygen from source list the README instructions were modified to recommend using a virtual environment which results in sphinx parsing the .venv directory, so add it to exclude_patterns as well as the 'build' folder _doxygen. This removes many unnecessary warnings that were inadvertently introduced. Signed-off-by: Sipke Vriend --- conf.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/conf.py b/conf.py index 54bb6e52..3c336c6f 100644 --- a/conf.py +++ b/conf.py @@ -98,7 +98,7 @@ # List of patterns, relative to source directory, that match files and # directories to ignore when looking for source files. # This pattern also affects html_static_path and html_extra_path. -exclude_patterns = ['_build', 'Thumbs.db', '.DS_Store', '.git'] +exclude_patterns = ['_build', 'Thumbs.db', '.DS_Store', '.git', '.venv*', '_doxygen'] # The name of the Pygments (syntax highlighting) style to use. pygments_style = 'sphinx'