diff --git a/config/bidderinfo.go b/config/bidderinfo.go index ce3eb57e0..4f8f05445 100644 --- a/config/bidderinfo.go +++ b/config/bidderinfo.go @@ -373,6 +373,9 @@ func processBidderAliases(aliasNillableFieldsByBidder map[string]aliasNillableFi } parentBidderInfo := bidderInfos[aliasBidderInfo.AliasOf] + // Note: The aliasBidderInfo.GVLVendorID is intentionally never set to the parent's + // GVLVendorID. Each alias must declare its own GVL Vendor ID, as inheriting from the + // parent is not safe for legal reasons. if aliasBidderInfo.AppSecret == "" { aliasBidderInfo.AppSecret = parentBidderInfo.AppSecret } @@ -391,9 +394,6 @@ func processBidderAliases(aliasNillableFieldsByBidder map[string]aliasNillableFi if aliasBidderInfo.ExtraAdapterInfo == "" { aliasBidderInfo.ExtraAdapterInfo = parentBidderInfo.ExtraAdapterInfo } - if aliasBidderInfo.GVLVendorID == 0 { - aliasBidderInfo.GVLVendorID = parentBidderInfo.GVLVendorID - } if aliasBidderInfo.Maintainer == nil { aliasBidderInfo.Maintainer = parentBidderInfo.Maintainer } diff --git a/config/bidderinfo_test.go b/config/bidderinfo_test.go index 785b85bc6..4142e8984 100644 --- a/config/bidderinfo_test.go +++ b/config/bidderinfo_test.go @@ -255,7 +255,7 @@ func TestProcessBidderInfo(t *testing.T) { }, }, ExtraAdapterInfo: "extra-info", - GVLVendorID: 42, + GVLVendorID: 0, Maintainer: &MaintainerInfo{ Email: "some-email@domain.com", }, @@ -392,6 +392,7 @@ func TestProcessAliasBidderInfo(t *testing.T) { } bidderB := parentWithSyncerKey bidderB.AliasOf = "bidderA" + bidderB.GVLVendorID = 0 bidderB.Syncer = &Syncer{ Key: bidderB.Syncer.Key, } diff --git a/static/bidder-info/adform.yaml b/static/bidder-info/adform.yaml index 6475bb34c..b25507131 100644 --- a/static/bidder-info/adform.yaml +++ b/static/bidder-info/adform.yaml @@ -1,4 +1,5 @@ aliasOf: adf +gvlVendorID: 50 userSync: redirect: url: "https://c1.adform.net/cookie?redirect_url={{.RedirectURL}}" diff --git a/static/bidder-info/admaticde.yaml b/static/bidder-info/admaticde.yaml index 562aa1836..fdd9b6107 100644 --- a/static/bidder-info/admaticde.yaml +++ b/static/bidder-info/admaticde.yaml @@ -1 +1,2 @@ -aliasOf: "admatic" \ No newline at end of file +aliasOf: "admatic" +gvlVendorID: 1281 \ No newline at end of file diff --git a/static/bidder-info/copper6.yaml b/static/bidder-info/copper6.yaml index b4e259ef0..fe3ea47a2 100644 --- a/static/bidder-info/copper6.yaml +++ b/static/bidder-info/copper6.yaml @@ -2,6 +2,7 @@ aliasOf: adtelligent endpoint: "http://ghb.app.copper6.com/pbs/ortb" maintainer: email: "info@copper6.com" +gvlVendorID: 1356 userSync: # Copper6 ssp supports user syncing, but requires configuration by the host. contact this # bidder directly at the email address in this file to ask about enabling user sync. diff --git a/static/bidder-info/epsilon.yaml b/static/bidder-info/epsilon.yaml index cb8318102..4da155b06 100644 --- a/static/bidder-info/epsilon.yaml +++ b/static/bidder-info/epsilon.yaml @@ -1,4 +1,5 @@ aliasOf: conversant +gvlVendorID: 24 userSync: redirect: url: "https://prebid-match.dotomi.com/match/bounce/current?version=1&networkId=72582&gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&gpp={{.GPP}}&gpp_sid={{.GPPSID}}&rurl={{.RedirectURL}}" diff --git a/static/bidder-info/equativ.yaml b/static/bidder-info/equativ.yaml index 7c5214fe4..512da14d5 100644 --- a/static/bidder-info/equativ.yaml +++ b/static/bidder-info/equativ.yaml @@ -1 +1,2 @@ aliasOf: "smartadserver" +gvlVendorID: 45 diff --git a/static/bidder-info/finative.yaml b/static/bidder-info/finative.yaml index e1136c322..9201f4eb3 100644 --- a/static/bidder-info/finative.yaml +++ b/static/bidder-info/finative.yaml @@ -1,2 +1,3 @@ endpoint: "https://b.finative.cloud/cds/rtb/bid?ssp={{.AccountID}}" -aliasOf: "seedingAlliance" \ No newline at end of file +aliasOf: "seedingAlliance" +gvlVendorID: 371 \ No newline at end of file diff --git a/static/bidder-info/freewheel-ssp.yaml b/static/bidder-info/freewheel-ssp.yaml index 43c1ca166..4b79dd12a 100644 --- a/static/bidder-info/freewheel-ssp.yaml +++ b/static/bidder-info/freewheel-ssp.yaml @@ -1,4 +1,5 @@ aliasOf: freewheelssp +gvlVendorID: 285 userSync: iframe: url: "https://ads.stickyadstv.com/pbs-user-sync?gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&gpp={{.GPP}}&gpp_sid={{.GPPSID}}&r={{.RedirectURL}}" diff --git a/static/bidder-info/indicue.yaml b/static/bidder-info/indicue.yaml index 1353424df..0548d0ed5 100644 --- a/static/bidder-info/indicue.yaml +++ b/static/bidder-info/indicue.yaml @@ -2,6 +2,7 @@ aliasOf: adtelligent endpoint: "http://ghb.console.indicue.com/pbs/ortb" maintainer: email: "ops@indicue.com" +gvlVendorID: 410 userSync: # Indicue ssp supports user syncing, but requires configuration by the host. contact this # bidder directly at the email address in this file to ask about enabling user sync. diff --git a/static/bidder-info/janet.yaml b/static/bidder-info/janet.yaml index 97f44a2bd..4a77ef6f4 100644 --- a/static/bidder-info/janet.yaml +++ b/static/bidder-info/janet.yaml @@ -2,6 +2,7 @@ aliasOf: adtelligent endpoint: "http://ghb.bidder.jmgads.com/pbs/ortb" maintainer: email: "info@thejmg.com" +gvlVendorID: 410 userSync: # JANet supports user syncing, but requires configuration by the host. contact this # bidder directly at the email address in this file to ask about enabling user sync. diff --git a/static/bidder-info/magnite.yaml b/static/bidder-info/magnite.yaml index 109c20d03..a0840a14a 100644 --- a/static/bidder-info/magnite.yaml +++ b/static/bidder-info/magnite.yaml @@ -1 +1,2 @@ -aliasOf: "rubicon" \ No newline at end of file +aliasOf: "rubicon" +gvlVendorID: 52 \ No newline at end of file diff --git a/static/bidder-info/monetixads.yaml b/static/bidder-info/monetixads.yaml index 95beda701..32b0d7928 100644 --- a/static/bidder-info/monetixads.yaml +++ b/static/bidder-info/monetixads.yaml @@ -1,3 +1,4 @@ aliasOf: "admatic" maintainer: - email: "team@monetixads.com" \ No newline at end of file + email: "team@monetixads.com" +gvlVendorID: 1281 \ No newline at end of file diff --git a/static/bidder-info/netaddiction.yaml b/static/bidder-info/netaddiction.yaml index 7f6777b4b..70a26fca5 100644 --- a/static/bidder-info/netaddiction.yaml +++ b/static/bidder-info/netaddiction.yaml @@ -1,3 +1,4 @@ aliasOf: "admatic" maintainer: - email: "publishers-support@netaddiction.it" \ No newline at end of file + email: "publishers-support@netaddiction.it" +gvlVendorID: 1281 \ No newline at end of file diff --git a/static/bidder-info/pgam.yaml b/static/bidder-info/pgam.yaml index e0bf4388d..911fa4ef0 100644 --- a/static/bidder-info/pgam.yaml +++ b/static/bidder-info/pgam.yaml @@ -2,6 +2,7 @@ aliasOf: adtelligent endpoint: "http://ghb.pgamssp.com/pbs/ortb" maintainer: email: "ppatel@pgammedia.com" +gvlVendorID: 1353 userSync: # PGAM ssp supports user syncing, but requires configuration by the host. contact this # bidder directly at the email address in this file to ask about enabling user sync. diff --git a/static/bidder-info/pixad.yaml b/static/bidder-info/pixad.yaml index d08230bfb..bc9a6fe69 100644 --- a/static/bidder-info/pixad.yaml +++ b/static/bidder-info/pixad.yaml @@ -1,3 +1,4 @@ aliasOf: "admatic" maintainer: - email: "prebid@pixad.com.tr" \ No newline at end of file + email: "prebid@pixad.com.tr" +gvlVendorID: 1281 \ No newline at end of file diff --git a/static/bidder-info/showheroes-bs.yaml b/static/bidder-info/showheroes-bs.yaml new file mode 100644 index 000000000..7143e05ae --- /dev/null +++ b/static/bidder-info/showheroes-bs.yaml @@ -0,0 +1,2 @@ +aliasOf: "showheroes" +gvlVendorID: 111 \ No newline at end of file diff --git a/static/bidder-info/showheroesBs.yaml b/static/bidder-info/showheroesBs.yaml new file mode 100644 index 000000000..7143e05ae --- /dev/null +++ b/static/bidder-info/showheroesBs.yaml @@ -0,0 +1,2 @@ +aliasOf: "showheroes" +gvlVendorID: 111 \ No newline at end of file diff --git a/static/bidder-info/streamkey.yaml b/static/bidder-info/streamkey.yaml index 20510ceac..463abd64b 100644 --- a/static/bidder-info/streamkey.yaml +++ b/static/bidder-info/streamkey.yaml @@ -2,6 +2,7 @@ aliasOf: adtelligent endpoint: "http://ghb.hb.streamkey.net/pbs/ortb" maintainer: email: "contact@streamkey.tv" +gvlVendorID: 410 capabilities: app: mediaTypes: diff --git a/static/bidder-info/tagoras.yaml b/static/bidder-info/tagoras.yaml index c40aaa2a0..f8f94a456 100644 --- a/static/bidder-info/tagoras.yaml +++ b/static/bidder-info/tagoras.yaml @@ -2,6 +2,7 @@ aliasOf: "vidazoo" endpoint: "https://exchange.tagoras.io/openrtb/" maintainer: email: "prebid@tagoras.io" +gvlVendorID: 1450 userSync: iframe: url: https://sync.tagoras.io/api/user/html/6819bdc3e6bb44545c55f843?pbs=true&gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&redirect={{.RedirectURL}}&gpp={{.GPP}}&gpp_sid={{.GPPSID}} diff --git a/static/bidder-info/ttd.yaml b/static/bidder-info/ttd.yaml index db055e1a7..78ed8c79b 100644 --- a/static/bidder-info/ttd.yaml +++ b/static/bidder-info/ttd.yaml @@ -1 +1,2 @@ aliasOf: thetradedesk +gvlVendorID: 21 diff --git a/static/bidder-info/yahooAdvertising.yaml b/static/bidder-info/yahooAdvertising.yaml index f9f34fbfb..68037fb68 100644 --- a/static/bidder-info/yahooAdvertising.yaml +++ b/static/bidder-info/yahooAdvertising.yaml @@ -1,4 +1,5 @@ aliasOf: yahooAds +gvlVendorID: 25 userSync: # yahooAdvertising supports user syncing, but requires configuration by the host. contact this # bidder directly at the email address in this file to ask about enabling user sync. diff --git a/static/bidder-info/yahoossp.yaml b/static/bidder-info/yahoossp.yaml index 81695624d..132bef5a8 100644 --- a/static/bidder-info/yahoossp.yaml +++ b/static/bidder-info/yahoossp.yaml @@ -1,6 +1,7 @@ aliasOf: yahooAds maintainer: email: "hb-fe-tech@oath.com" +gvlVendorID: 25 userSync: # yahoossp supports user syncing, but requires configuration by the host. contact this # bidder directly at the email address in this file to ask about enabling user sync. diff --git a/static/bidder-info/yobee.yaml b/static/bidder-info/yobee.yaml index 28ce00e79..94023eef0 100644 --- a/static/bidder-info/yobee.yaml +++ b/static/bidder-info/yobee.yaml @@ -1,3 +1,4 @@ aliasOf: "admatic" maintainer: - email: "adops@yobee.it" \ No newline at end of file + email: "adops@yobee.it" +gvlVendorID: 1281 \ No newline at end of file