Skip to content

Upstream PR #4590: Adagio: Enable site capability (#4590) #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
openads-sync-bot wants to merge 1 commit into from
Closed

Upstream PR #4590: Adagio: Enable site capability (#4590) #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/upstream-sync-state.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"last_synced_sha": "e64cf6275f347ba55a39effbd11679abd4e956a6", "updated_at": "2026-02-17T18:41:08Z"}
3 changes: 1 addition & 2 deletions adapters/adagio/adagio.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package adagio

import (
"encoding/json"
"errors"
"fmt"
"net/http"

Expand Down Expand Up @@ -64,7 +63,7 @@ func (a *adapter) MakeBids(internalRequest *openrtb2.BidRequest, externalRequest
}

if len(bidResponse.SeatBid) == 0 {
return nil, []error{errors.New("empty seatbid array")}
return nil, []error{&errortypes.BadServerResponse{Message: "empty seatbid array"}}
}

var errs []error
Expand Down
7 changes: 6 additions & 1 deletion static/bidder-info/adagio.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,9 @@ capabilities:
mediaTypes:
- banner
- video
- native
- native
site:
mediaTypes:
- banner
- video
- native
4 changes: 4 additions & 0 deletions static/bidder-params/adagio.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,12 @@
},
"placement": {
"type": "string",
<<<<<<< HEAD
"description": "Refers to the placement of an adunit in a page. Must not contain any information about the type of device.",
"maxLength": 30
=======
"description": "Refers to the placement of an adunit in a page. See Adagio recommended values: https://prebid.org/dev-docs/bidders/adagio.html#recommended-placement-param-values."
>>>>>>> 42a25c19 (Adagio: Enable site capability (#4590))
},
"site": {
"type": "string",
Expand Down
Loading