From d4c9e5f9c28461f36cf514cc6fd19530416c16f5 Mon Sep 17 00:00:00 2001
From: Muhamed Fazal PS <muhamedfazalps@gmail.com>
Date: Wed, 15 Jul 2026 18:38:56 +0530
Subject: [PATCH] fix: InvalidDatasetError parameter 'format' shadows built-in
 (#70)

---
 openagent_eval/datasets/csv_loader.py   | 2 +-
 openagent_eval/datasets/factory.py      | 2 +-
 openagent_eval/datasets/json_loader.py  | 2 +-
 openagent_eval/datasets/jsonl_loader.py | 2 +-
 openagent_eval/datasets/pdf_loader.py   | 4 ++--
 openagent_eval/exceptions/dataset.py    | 8 ++++----
 6 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/openagent_eval/datasets/csv_loader.py b/openagent_eval/datasets/csv_loader.py
index 4b1a8e4..1e79ae4 100644
--- a/openagent_eval/datasets/csv_loader.py
+++ b/openagent_eval/datasets/csv_loader.py
@@ -65,7 +65,7 @@ def load(self, path: Path) -> Dataset:
             raise InvalidDatasetError(
                 message=f"Invalid CSV format: {e}",
                 dataset_path=str(path),
-                format="csv",
+                frmt="csv",
             ) from e
 
         return self._parse_rows(rows, path)
diff --git a/openagent_eval/datasets/factory.py b/openagent_eval/datasets/factory.py
index 50782d3..6ee7112 100644
--- a/openagent_eval/datasets/factory.py
+++ b/openagent_eval/datasets/factory.py
@@ -59,7 +59,7 @@ def _get_loader(config: DatasetConfig) -> BaseDatasetLoader:
         raise InvalidDatasetError(
             message=f"Unsupported dataset format: '{config.format}'. "
             f"Supported formats: {list(_FORMAT_MAP.keys())}",
-            format=config.format,
+            frmt=config.format,
         )
 
     # Guard against directory paths, which have no usable extension and
diff --git a/openagent_eval/datasets/json_loader.py b/openagent_eval/datasets/json_loader.py
index 74f90ae..fdbc0e0 100644
--- a/openagent_eval/datasets/json_loader.py
+++ b/openagent_eval/datasets/json_loader.py
@@ -63,7 +63,7 @@ def load(self, path: Path) -> Dataset:
             raise InvalidDatasetError(
                 message=f"Invalid JSON in file: {e}",
                 dataset_path=str(path),
-                format="json",
+                frmt="json",
                 line_number=e.lineno,
             ) from e
 
diff --git a/openagent_eval/datasets/jsonl_loader.py b/openagent_eval/datasets/jsonl_loader.py
index 05f016a..957bc7c 100644
--- a/openagent_eval/datasets/jsonl_loader.py
+++ b/openagent_eval/datasets/jsonl_loader.py
@@ -120,7 +120,7 @@ def _parse_lines(self, lines: list[str], path: Path) -> Dataset:
                 raise InvalidDatasetError(
                     message=f"Invalid JSON on line {line_num}: {e}",
                     dataset_path=str(path),
-                    format="jsonl",
+                    frmt="jsonl",
                     line_number=line_num,
                 ) from e
 
diff --git a/openagent_eval/datasets/pdf_loader.py b/openagent_eval/datasets/pdf_loader.py
index 08cfa5d..87a6c8e 100644
--- a/openagent_eval/datasets/pdf_loader.py
+++ b/openagent_eval/datasets/pdf_loader.py
@@ -88,7 +88,7 @@ def load(self, path: Path) -> Dataset:
                     "Install it with: pip install openagent-eval[pdf]"
                 ),
                 dataset_path=str(path),
-                format="pdf",
+                frmt="pdf",
             ) from e
 
         try:
@@ -97,7 +97,7 @@ def load(self, path: Path) -> Dataset:
             raise InvalidDatasetError(
                 message=f"Failed to read PDF: {e}",
                 dataset_path=str(path),
-                format="pdf",
+                frmt="pdf",
             ) from e
 
         raw_items = self._extract_raw(reader, path)
diff --git a/openagent_eval/exceptions/dataset.py b/openagent_eval/exceptions/dataset.py
index ecf4ad5..8d4b24f 100644
--- a/openagent_eval/exceptions/dataset.py
+++ b/openagent_eval/exceptions/dataset.py
@@ -65,7 +65,7 @@ def __init__(
         self,
         message: str,
         dataset_path: str | None = None,
-        format: str | None = None,
+        frmt: str | None = None,
         line_number: int | None = None,
         details: dict | None = None,
     ) -> None:
@@ -79,13 +79,13 @@ def __init__(
             details: Additional context about the error.
         """
         error_details = details or {}
-        if format:
-            error_details["format"] = format
+        if frmt:
+            error_details["format"] = frmt
         if line_number:
             error_details["line_number"] = line_number
 
         super().__init__(message=message, dataset_path=dataset_path, details=error_details)
-        self.format = format
+        self.format = frmt
         self.line_number = line_number