From d4e189d975c8a34c05a06fc6e1d8fdd2858aa9e0 Mon Sep 17 00:00:00 2001 From: Val Alexander <68980965+BunsDev@users.noreply.github.com> Date: Thu, 28 May 2026 04:43:44 -0500 Subject: [PATCH 1/2] fix(browser): cfg-gate BrowserPaneSnapshot import for wasm clippy The `snapshot()` method only references `BrowserPaneSnapshot` inside its `#[cfg(not(target_family = "wasm"))]` block (the wasm branch returns `LeafContents::NetworkLog` since wasm has no WebKit data store to persist), so the unconditional `use crate::app_state::BrowserPaneSnapshot` became an unused import on wasm and tripped `Formatting + Clippy (wasm)` with `-D warnings`. Co-Authored-By: Claude Opus 4.7 (1M context) --- app/src/pane_group/pane/browser_pane.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/src/pane_group/pane/browser_pane.rs b/app/src/pane_group/pane/browser_pane.rs index 5b86ec14..2d4eac2d 100644 --- a/app/src/pane_group/pane/browser_pane.rs +++ b/app/src/pane_group/pane/browser_pane.rs @@ -1,7 +1,9 @@ use url::Url; use warpui::{AppContext, ModelHandle, View, ViewContext, ViewHandle}; -use crate::app_state::{BrowserPaneSnapshot, LeafContents}; +use crate::app_state::LeafContents; +#[cfg(not(target_family = "wasm"))] +use crate::app_state::BrowserPaneSnapshot; use super::{ browser::{BrowserView, BrowserViewEvent}, From a151d57a203fd1464efdc6bd33ce05602a00ad20 Mon Sep 17 00:00:00 2001 From: Val Alexander <68980965+BunsDev@users.noreply.github.com> Date: Fri, 29 May 2026 17:27:14 -0500 Subject: [PATCH 2/2] style(browser): order imports alphabetically by item name Original commit on this branch put `LeafContents` before `BrowserPaneSnapshot`, which failed `cargo fmt --check` on every platform. rustfmt expects the alphabetical order regardless of the intervening `#[cfg]` attribute. Co-Authored-By: Claude Opus 4.7 (1M context) --- app/src/pane_group/pane/browser_pane.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/pane_group/pane/browser_pane.rs b/app/src/pane_group/pane/browser_pane.rs index 2d4eac2d..0fa57534 100644 --- a/app/src/pane_group/pane/browser_pane.rs +++ b/app/src/pane_group/pane/browser_pane.rs @@ -1,9 +1,9 @@ use url::Url; use warpui::{AppContext, ModelHandle, View, ViewContext, ViewHandle}; -use crate::app_state::LeafContents; #[cfg(not(target_family = "wasm"))] use crate::app_state::BrowserPaneSnapshot; +use crate::app_state::LeafContents; use super::{ browser::{BrowserView, BrowserViewEvent},