Skip to content

Invalid tcp_err and udp_err for fragmented packets #2342

@albe19029

Description

@albe19029

Good day. For fragmented packets I found that odp_pktio_stats returns invalid in_errors value. In my case there were no errors, but for every non first packet the value was incremented for every receive fragment packet.

So I checked this error with next odp_packet_has_l4_error method and found that ODP set tcp_err and udp_err.

The problem here:
https://github.com/OpenDataPlane/odp/blob/master/platform/linux-generic/odp_parse.c#L289
https://github.com/OpenDataPlane/odp/blob/master/platform/linux-generic/odp_parse.c#L260

For fragmented TCP or UDP packets we have header only in first fragment, and other fragments don't have header. That is why this check is only valid for first fragment.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions