Column header naming convention is not checked

[chrwm]

When uploading tables to the OEP using the script the column headers are not checked for capital letters and the table is nonetheless added to the DB.

I'm not sure whether this is a bug or problematic.

Example:

https://openenergy-platform.org/dataedit/view/model_draft/wind_turbine_domestic_lod_geoss_tp_oeo

[chrwm]

oem2orm has no checks for the oedb table naming conventions. However, it should be implemented in oem2orm or in the API itself.

[jh-RLI]

The OEP API now checks for id fields and duplicate column names: OpenEnergyPlatform/oeplatform#1032

As far as I know, the API does not check for all table conventions (like capital letters).
@wingechr correct me if I'm wrong :)
The "create table" tool checks for uppercase letters, but other tools like oem2orm do not.
Since this is a compliance issue for the OEP, we should include such checks in the API. We should not trust user input and rely on other developers to implement all checks in their tools.

[chrwm]

The same set of checks should apply for the Wizzard too.

[wingechr]

completely agree. i will have a look at the api side and if necessary implement name checks

[chrwm]

Are there any updates on the issue?
I uploaded a table to test the status: https://openenergy-platform.org/dataedit/view/model_draft/umas_2021_05_18_resources_name_check_2

There're checks, however the error messages are heterogenous and should be improved. Not sure if the checks stem from the OEP API checks rather than sqlalchemy internal.

Implemented checks for columns headers

1. starting col with number - bad/unspecific error message
2. special characters - bad/unspecific error message
3. capital letters - specific error message, but no column specified

[wingechr]

checks could be some regular expression, like [a-z][a-z0-9_]{0,62}