Skip to content

Enable ESLint rules vue/valid-v-for and vue/require-v-for-key #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brianhelba merged 2 commits into from
Jun 5, 2026
Merged

Enable ESLint rules vue/valid-v-for and vue/require-v-for-key #399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7188f26
Enable ESLint rule `vue/valid-v-for`
brianhelba May 20, 2026
af430a9
Enable ESLint rule `vue/require-v-for-key`
brianhelba May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions web/eslint.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@ export default defineConfigWithVueTs(
"vue/valid-v-slot": ["error", { allowModifiers: true }],
// `any` is used everywhere and will be difficult to eliminate
"@typescript-eslint/no-explicit-any": "off",
// Temporary ignores until rules can be fixed
"vue/require-v-for-key": "off",
"vue/valid-v-for": "off",
Comment on lines -23 to -25

@annehaley annehaley Jun 5, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, looks like these were the last ones that needed to be addressed. Tysm for doing all that cleanup!

},
},
skipFormatting,
Expand Down
4 changes: 3 additions & 1 deletion web/src/components/ControlsBar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,7 +570,9 @@ watch(newBasemapStyleJSON, debounce(createNewBasemapPreview, 1000));
</v-window-item>
</v-window>
<v-spacer />
<div v-for="err in jsonErrors">Error: {{ err.message }}</div>
<div v-for="(err, index) in jsonErrors" :key="index">
Error: {{ err.message }}
</div>
<div v-if="!jsonErrors?.length">Map Preview:</div>
<div
id="basemap-preview-new"
Expand Down
8 changes: 7 additions & 1 deletion web/src/components/projects/DatasetSelect.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,12 +170,17 @@ function submitDelete() {
<div class="mb-2 ml-2">
<v-chip
v-for="tag in dataset.tags"
:key="tag"
:text="tag"
variant="outlined"
size="small"
/>
</div>
<div v-for="layer in dataset.layers" class="item-title">
<div
v-for="layer in dataset.layers"
:key="layer.id"
class="item-title"
>
<div style="text-wrap: wrap; align-items: center; width: 100%">
{{ layer.name }}
</div>
Expand Down Expand Up @@ -211,6 +216,7 @@ function submitDelete() {
<div>
<v-chip
v-for="project in getDatasetProjects(datasetToDelete.id)"
:key="project.id"
:text="project.name"
/>
</div>
Expand Down
1 change: 1 addition & 0 deletions web/src/components/projects/DatasetUpload.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,7 @@ watch(open, () => {
<span class="secondary-text">Similar Existing Datasets:</span>
<div
v-for="dataset in similarExisting"
:key="dataset.id"
style="font-size: 0.8rem; margin-left: 10px"
>
{{ dataset.name }}
Expand Down
1 change: 1 addition & 0 deletions web/src/components/projects/ProjectConfig.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,7 @@ watch(
<v-list class="transparent" color="primary" selectable>
<v-list-item
v-for="project in filteredProjects"
:key="project.id"
:title="project.name"
:active="project.id === selectedProject?.id"
@click="() => selectProject(project)"
Expand Down
6 changes: 5 additions & 1 deletion web/src/components/sidebars/ColormapEditor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,11 @@ onMounted(init);
</div>
</div>
<div style="height: 200px; overflow-y: auto">
<div v-for="(marker, index) in markers" class="py-2 marker-row">
<div
v-for="(marker, index) in markers"
:key="index"
class="py-2 marker-row"
>
<v-menu :close-on-content-click="false" open-on-hover location="end">
<template v-slot:activator="{ props }">
<div
Expand Down
7 changes: 6 additions & 1 deletion web/src/components/sidebars/DatasetsPanel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,13 +119,18 @@ function toggleSelected(items: Layer[]) {
<div>
<v-chip
v-for="tag in dataset.tags"
:key="tag"
:text="tag"
variant="outlined"
size="small"
class="ml-3 mb-2"
/>
</div>
<div v-for="layer in dataset.layers" class="item-title">
<div
v-for="layer in dataset.layers"
:key="layer.id"
class="item-title"
>
<div
style="
text-wrap: wrap;
Expand Down
3 changes: 3 additions & 0 deletions web/src/components/sidebars/LayerStyle.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -796,6 +796,7 @@ onMounted(resetCurrentStyle);
v-for="group in currentStyleSpec.colors.filter(
(c) => c.name === currentGroups['color'],
)"
:key="group.name"
>
<tr v-if="currentGroups['color'] !== 'all'">
<td><v-label>Band</v-label></td>
Expand Down Expand Up @@ -1171,6 +1172,7 @@ onMounted(resetCurrentStyle);
v-for="group in currentStyleSpec.colors.filter(
(c) => c.name === currentGroups['color'],
)"
:key="group.name"
>
<tr v-if="currentGroups['color'] !== 'all'">
<td><v-label>Feature Type</v-label></td>
Expand Down Expand Up @@ -1639,6 +1641,7 @@ onMounted(resetCurrentStyle);
v-for="group in currentStyleSpec.sizes.filter(
(c) => c.name === currentGroups['size'],
)"
:key="group.name"
>
<tr>
<td><v-label>Size Choice</v-label></td>
Expand Down
1 change: 1 addition & 0 deletions web/src/components/sidebars/LayersPanel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,7 @@ function setLayerActive(layer: Layer, active: boolean) {
/>
<div
v-for="frame in getLayerCurrentFrames(element)"
:key="frame.id"
style="display: flex; justify-content: space-between"
>
<span> <i>Frame:</i> {{ frame.name }} </span>
Expand Down
6 changes: 5 additions & 1 deletion web/src/components/sidebars/LegendPanel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ function getColorPropsCoverage(layer: Layer) {
{{ layer.name }}
<div
v-for="colormap_preview in getColormapPreviews(layer)"
:key="colormap_preview.name"
class="ml-6"
>
<div v-if="getColormapPreviews(layer).length > 1">
Expand Down Expand Up @@ -171,7 +172,10 @@ function getColorPropsCoverage(layer: Layer) {
/>
</v-expansion-panel-title>
<v-expansion-panel-text>
<div v-for="row in colormap_preview.valueColors">
<div
v-for="(row, index) in colormap_preview.valueColors"
:key="index"
>
<div
v-if="row"
class="d-flex"
Expand Down
3 changes: 3 additions & 0 deletions web/src/components/sidebars/SideBars.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ function togglePanelVisibility(id: string) {
v-for="(panel, index) in panelStore.panelArrangement.filter(
(p) => p.dock == 'left',
)"
:key="panel.id"
:id="panel.id"
:bottom="
index ==
Expand Down Expand Up @@ -194,6 +195,7 @@ function togglePanelVisibility(id: string) {
v-for="item in panelStore.panelArrangement.filter(
(p) => p.closeable,
)"
:key="item.id"
@click="togglePanelVisibility(item.id)"
>
<v-checkbox-btn
Expand All @@ -209,6 +211,7 @@ function togglePanelVisibility(id: string) {
v-for="(panel, index) in panelStore.panelArrangement.filter(
(p) => p.dock == 'right',
)"
:key="panel.id"
:id="panel.id"
:bottom="
index ==
Expand Down