Skip to content

fix: register conversation ID with workspace for completion callback #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jpshackelford wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: register conversation ID with workspace for completion callback #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions openhands/automation/presets/plugin/sdk_main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,10 @@ def event_callback(event) -> None:
delete_on_close=False, # Keep conversation history after completion
)
assert isinstance(conversation, RemoteConversation)

# Register conversation ID with workspace for completion callback
workspace.register_conversation(str(conversation.id))

Comment on lines +303 to +305
Copy link
Copy Markdown
Member

@malhotra5 malhotra5 May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should happen automatically inside the software agent sdk (when a workspace is passed to a conversation creation flow)

Reason is because we can't assume the user will always include this statement, it should be a default behavior

If this isn't working as of today, there is likely a regression inside the SDK

print(f" conversation created: {type(conversation).__name__}")
print(f" plugins loaded: {len(plugin_sources)}")

Expand Down
4 changes: 4 additions & 0 deletions openhands/automation/presets/prompt/sdk_main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,10 @@ def event_callback(event) -> None:
delete_on_close=False, # Keep conversation history after completion
)
assert isinstance(conversation, RemoteConversation)

# Register conversation ID with workspace for completion callback
workspace.register_conversation(str(conversation.id))

print(f" conversation created: {type(conversation).__name__}")

# Inject secrets into the conversation (as LookupSecret references)
Expand Down
Loading