fix(build): app icons, liblo DLL, installer shortcuts

- embed openmix.ico in the exe (RC) so Explorer, taskbar, and the
  WinSparkle update dialog pick it up; NSIS installer + ARP icons
- bundle openmix.icns and set CFBundleIconFile on macOS
- set the runtime window icon from a qrc PNG on all platforms
- install vcpkg's lo.dll: the Qt deploy script only bundles Qt, so
  the NSIS installer shipped without liblo and the app failed to
  launch
- add start menu + desktop shortcuts and a finish-page run option

Author: johnqherman

CMakeLists.txt

@@ -53,6 +53,14 @@ if(WIN32)
     find_library(LIBLO_LIBRARIES NAMES lo liblo REQUIRED)
     target_include_directories(openmix_liblo INTERFACE ${LIBLO_INCLUDE_DIRS})
     target_link_libraries(openmix_liblo INTERFACE ${LIBLO_LIBRARIES})
+    # the deploy script only bundles Qt; ship liblo's runtime DLL ourselves
+    get_filename_component(_liblo_libdir ${LIBLO_LIBRARIES} DIRECTORY)
+    find_file(LIBLO_DLL NAMES lo.dll liblo.dll
+        HINTS ${_liblo_libdir}/../bin ${LIBLO_INCLUDE_DIRS}/../bin)
+    if(NOT LIBLO_DLL)
+        message(FATAL_ERROR "liblo runtime DLL not found; the installer would ship without it")
+    endif()
+    install(FILES ${LIBLO_DLL} DESTINATION ${CMAKE_INSTALL_BINDIR})
 else()
     find_package(PkgConfig REQUIRED)
     pkg_check_modules(LIBLO REQUIRED IMPORTED_TARGET liblo)
@@ -439,13 +447,21 @@ if(WIN32)
     set_target_properties(${PROJECT_NAME} PROPERTIES
         WIN32_EXECUTABLE TRUE
     )
+    # embed the app icon into the executable (needs the RC language, which
+    # project(LANGUAGES CXX) leaves off)
+    enable_language(RC)
+    target_sources(${PROJECT_NAME} PRIVATE packaging/openmix.rc)
 elseif(APPLE)
     set_target_properties(${PROJECT_NAME} PROPERTIES
         MACOSX_BUNDLE TRUE
         MACOSX_BUNDLE_BUNDLE_NAME "OpenMix"
         MACOSX_BUNDLE_BUNDLE_VERSION ${PROJECT_VERSION}
         MACOSX_BUNDLE_SHORT_VERSION_STRING ${PROJECT_VERSION}
     )
+    # bundle icon: ship the icns in Resources (Info.plist.in names it)
+    target_sources(${PROJECT_NAME} PRIVATE packaging/openmix.icns)
+    set_source_files_properties(packaging/openmix.icns
+        PROPERTIES MACOSX_PACKAGE_LOCATION Resources)
 endif()
 
 # install rules
@@ -488,6 +504,18 @@ if(WIN32)
     set(CPACK_NSIS_DISPLAY_NAME "OpenMix")
     set(CPACK_NSIS_ENABLE_UNINSTALL_BEFORE_INSTALL ON)
     set(CPACK_NSIS_MODIFY_PATH OFF)
+    # installer/uninstaller + Add/Remove Programs icons
+    set(CPACK_NSIS_MUI_ICON "${CMAKE_SOURCE_DIR}/packaging/openmix.ico")
+    set(CPACK_NSIS_MUI_UNIICON "${CMAKE_SOURCE_DIR}/packaging/openmix.ico")
+    set(CPACK_NSIS_INSTALLED_ICON_NAME "bin\\\\OpenMix.exe")
+    # start menu entry + desktop shortcut (removed again on uninstall)
+    set(CPACK_PACKAGE_EXECUTABLES "OpenMix" "OpenMix")
+    set(CPACK_NSIS_CREATE_ICONS_EXTRA
+        "CreateShortCut '$DESKTOP\\\\OpenMix.lnk' '$INSTDIR\\\\bin\\\\OpenMix.exe'")
+    set(CPACK_NSIS_DELETE_ICONS_EXTRA
+        "Delete '$DESKTOP\\\\OpenMix.lnk'")
+    # offer to launch the app from the installer's finish page
+    set(CPACK_NSIS_MUI_FINISHPAGE_RUN "bin\\\\OpenMix.exe")
 elseif(APPLE)
     set(CPACK_GENERATOR "DragNDrop")
 else()

packaging/Info.plist.in

@@ -16,6 +16,8 @@
     <string>@PROJECT_VERSION@</string>
     <key>CFBundlePackageType</key>
     <string>APPL</string>
+    <key>CFBundleIconFile</key>
+    <string>openmix</string>
     <key>NSHighResolutionCapable</key>
     <true/>
     <key>LSMinimumSystemVersion</key>

packaging/openmix.icns

@@ -0,0 +1 @@
+IDI_ICON1 ICON "openmix.ico"

packaging/openmix.ico

@@ -2,6 +2,7 @@
 <RCC version="1.0">
     <qresource prefix="/">
         <file>styles/main.qss</file>
+        <file>icons/openmix.png</file>
         <file>icons/chevron-up.svg</file>
         <file>icons/chevron-down.svg</file>
     </qresource>

packaging/openmix.rc

@@ -3,6 +3,7 @@
 #include "ui/WelcomeDialog.h"
 #include "ui/theme/Theme.h"
 #include <QApplication>
+#include <QIcon>
 #include <QSettings>
 #include <QFile>
 #include <QPalette>
@@ -37,6 +38,7 @@ int main(int argc, char* argv[]) {
     QApplication::setApplicationName("OpenMix");
     QApplication::setApplicationVersion("0.1.0");
     QApplication::setOrganizationName("OpenMix");
+    QApplication::setWindowIcon(QIcon(":/icons/openmix.png"));
 
     oclero::qlementine::icons::initializeIconTheme();