Skip to content

chore: use one pre-push Codex review, one pre-push test-quality review, and disable automatic review disposition #60

Description

@Brad-Edwards

Summary

Bring this repo's .ground-control.yaml in line with the pre-push review configuration used by the other Ground Control repos (reference: RAESystem/rae .ground-control.yaml on dev): the /implement workflow should run one pre-push Codex review cycle and one pre-push test-quality review cycle, and automatic disposition of the review cap should be off so reaching the cap always escalates to a human.

Current state (dev)

.ground-control.yaml on dev (and main) is missing both pre_push_cap keys and actively enables automatic review disposition in authoritative mode:

  review_disposition:
    enabled: true
    mode: authoritative
    max_auto_overrides: 1
    judge:
      enabled: true

That diverges from the target on four of the six values: disposition is enabled, the mode is authoritative rather than shadow, one auto-override is permitted, and the judge is on. In authoritative mode a disposition can grant an over-cap review cycle without a human in the loop, which is exactly what this change removes.

Change

Update .ground-control.yaml so the workflow: block contains these keys (leave every other workflow: key as-is):

workflow:
  # ... existing keys unchanged ...
  codex_review:
    pre_push_cap: 1
  test_quality_review:
    pre_push_cap: 1
  review_disposition:
    enabled: false
    mode: shadow
    max_auto_overrides: 0
    judge:
      enabled: false

Acceptance criteria

  • workflow.codex_review.pre_push_cap is 1.
  • workflow.test_quality_review.pre_push_cap is 1.
  • workflow.review_disposition.enabled is false.
  • workflow.review_disposition.mode remains shadow.
  • workflow.review_disposition.max_auto_overrides is 0.
  • workflow.review_disposition.judge.enabled is false.
  • No other workflow: keys are changed.

This is a configuration change only — no code, workflow-skill, or CI changes are in scope.

Notes

This repo is a real behavior change, not just an explicitness change: mode: authoritative with max_auto_overrides: 1 currently lets the auto path grant an extra over-cap review cycle. After the change the cap boundary always escalates to a human.

The fork Brad-Edwards/workbench carries the same configuration and will pick this up when it syncs.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions