Summary
Bring this repo's .ground-control.yaml in line with the pre-push review configuration used by the other Ground Control repos (reference: RAESystem/rae .ground-control.yaml on dev): the /implement workflow should run one pre-push Codex review cycle and one pre-push test-quality review cycle, and automatic disposition of the review cap should be off so reaching the cap always escalates to a human.
Current state (dev)
.ground-control.yaml on dev (and main) is missing both pre_push_cap keys and actively enables automatic review disposition in authoritative mode:
review_disposition:
enabled: true
mode: authoritative
max_auto_overrides: 1
judge:
enabled: true
That diverges from the target on four of the six values: disposition is enabled, the mode is authoritative rather than shadow, one auto-override is permitted, and the judge is on. In authoritative mode a disposition can grant an over-cap review cycle without a human in the loop, which is exactly what this change removes.
Change
Update .ground-control.yaml so the workflow: block contains these keys (leave every other workflow: key as-is):
workflow:
# ... existing keys unchanged ...
codex_review:
pre_push_cap: 1
test_quality_review:
pre_push_cap: 1
review_disposition:
enabled: false
mode: shadow
max_auto_overrides: 0
judge:
enabled: false
Acceptance criteria
This is a configuration change only — no code, workflow-skill, or CI changes are in scope.
Notes
This repo is a real behavior change, not just an explicitness change: mode: authoritative with max_auto_overrides: 1 currently lets the auto path grant an extra over-cap review cycle. After the change the cap boundary always escalates to a human.
The fork Brad-Edwards/workbench carries the same configuration and will pick this up when it syncs.
Summary
Bring this repo's
.ground-control.yamlin line with the pre-push review configuration used by the other Ground Control repos (reference:RAESystem/rae.ground-control.yamlondev): the/implementworkflow should run one pre-push Codex review cycle and one pre-push test-quality review cycle, and automatic disposition of the review cap should be off so reaching the cap always escalates to a human.Current state (
dev).ground-control.yamlondev(andmain) is missing bothpre_push_capkeys and actively enables automatic review disposition in authoritative mode:That diverges from the target on four of the six values: disposition is enabled, the mode is
authoritativerather thanshadow, one auto-override is permitted, and the judge is on. In authoritative mode a disposition can grant an over-cap review cycle without a human in the loop, which is exactly what this change removes.Change
Update
.ground-control.yamlso theworkflow:block contains these keys (leave every otherworkflow:key as-is):Acceptance criteria
workflow.codex_review.pre_push_capis1.workflow.test_quality_review.pre_push_capis1.workflow.review_disposition.enabledisfalse.workflow.review_disposition.moderemainsshadow.workflow.review_disposition.max_auto_overridesis0.workflow.review_disposition.judge.enabledisfalse.workflow:keys are changed.This is a configuration change only — no code, workflow-skill, or CI changes are in scope.
Notes
This repo is a real behavior change, not just an explicitness change:
mode: authoritativewithmax_auto_overrides: 1currently lets the auto path grant an extra over-cap review cycle. After the change the cap boundary always escalates to a human.The fork
Brad-Edwards/workbenchcarries the same configuration and will pick this up when it syncs.