v5.6.0

[Daniel-Svensson]

What's Changed

• Update nugets and Add some trimming annotations by @Daniel-Svensson in Update nugets and Add some trimming annotations #517
• Update azure-pipelines.yml for Azure Pipelines by @Daniel-Svensson in Update azure-pipelines.yml for Azure Pipelines #519
• Use sonarcloudv3 in azure-pipelines.yml by @Daniel-Svensson in Use sonarcloudv3 in azure-pipelines.yml #520
• Set accept header for binary endpoint by @Daniel-Svensson in Set accept header for binary endpoint #521
• AspNetCore: Add Options and improve Setup by @Daniel-Svensson in AspNetCore: Add Options and improve Setup #518
• Drop support for .NET 6, target .NET8 as minimum and update nuget dependencies by @Daniel-Svensson in Drop support for .NET 6, target .NET8 as minimum and update nuget dependencies #523

Full Changelog: v5.5.0...v5.6.0

---

This discussion was created from the release v5.6.0.

[neplan]

Hi Daniel

I have updated our version from 5.5.0 to 5.6. Now I have a problem on our client project for the WPF. We were using the obsolete WcfEndpointBehavior and WcfDomainClientFactory to create a BinaryDomainClientFactory. Is there an example on how to do it in the new version?

Best regards,

Alessandro

[Daniel-Svensson]

It seems like the documentation is a bit lacking does https://github.com/OpenRIAServices/OpenRiaServices/blob/main/Changelog.md#binaryhttpdomainclientfactory help?

You will probably see it used in some of the samples (at least aspnetcore) and in the tests aspnetcore e2e

[neplan]

Thank you Daniel. Is there an example on how to add an additional EndpointBehavior to a DomainClientFactory?
We were using the BinaryDomainClientFactory (This class was extending the WcfDomainClientFactory) and when the client service was created on the client side, we were modifing the "ChannelFactory" to add our EndpointBehaviors:

We wrote an extension method similar to that:
`public static void ShareCookieContainer(this DomainContext domainContext)
{
var channelFactoryProperty = domainContext.DomainClient.GetType().GetProperty("ChannelFactory");
var factory = (ChannelFactory)channelFactoryProperty.GetValue(domainContext.DomainClient, null);
if(factory.Endpoint.Binding is CustomBinding customBinding)
{
var httpBinding = customBinding.Elements.Find();
if (httpBinding != null)
{
httpBinding.AllowCookies = true;
}
var httpsBinding = customBinding.Elements.Find();
if (httpsBinding != null)
{
httpsBinding.AllowCookies = true;
}
}
if(!factory.Endpoint.EndpointBehaviors.Any(c => c is SharedCookieHttpBehavior))
factory.Endpoint.EndpointBehaviors.Add(new SharedCookieHttpBehavior());
}
public class SharedCookieHttpBehavior : IEndpointBehavior
{

}`

Do you have any example or hints for that?

Best regards,

Alessandro

[Daniel-Svensson]

Cookies should be handled by default for httpclient and httpclienthandler.

Httpclienthandler has a few properties to fine tune the behavior and add custom cookies.
https://learn.microsoft.com/en-us/dotnet/api/system.net.http.httpclienthandler?view=net-9.0

HttpClient is very extensible so you should be able to do almost anything you want. Can can also find ready to use delegating handles for various purposes including caching, logging and authentication.

One of the first search reaulta for delegating handlers: (have not read it all) https://code-maze.com/aspnetcore-using-delegating-handlers-to-extend-httpclient/

[neplan]

Ok. Great. I will have a look. Thank you for the fast support.

Best regards,

Alessandro

[neplan]

Dear Daniel

I was able to implement the HttpClient, Cookie Handling as you have suggested. The problem I have now is that the binary endpoint cannot be used for 4.8. I get an 'UnsupportedMediaType' exception as soon I'm trying to call a service function. Is there a way to handle that?

[Daniel-Svensson]

@neplan I have updated the simple wpf example project at https://github.com/OpenRIAServices/Samples/tree/main/SimpleWPF to 5.6.0 on both server and client and it seems to have no issue.

Can you try it out ?

[neplan]

Thank you. I will have a look next week.

[Daniel-Svensson]

Ok. I have an idea what might possibe be related

For GET (queries) HttpClient might not set the "Content-Type" header (since there is no content) but only the more appropiate "Accept" header.
You could try to manually set "Content-Type" on all kinds of requests (either use the delegating handler approch or just pass in a function which returns a HttpClient where "Content-Type" is set using default headers).

[neplan]

Ok. Thank you for the hint. I will try to check it and let you know.

Best regards,

Alessandro

[neplan]

@neplan I have updated the simple wpf example project at https://github.com/OpenRIAServices/Samples/tree/main/SimpleWPF to 5.6.0 on both server and client and it seems to have no issue.

Can you try it out ?

The application seems to run correctly.

[neplan]

SimpleWPF_Modified.zip
I have modified the SimpleWPF with a delegate handler and then it's not working anymore. Do you see the problem?

[Daniel-Svensson]

@neplan if I remove the following section it works for me.

Note: The code is needed in the openria services test project because code generation runs against full .net framework and generates WCF compatible requests, but there we want to call using simplfied ulrs (se AspNetCore specific setting at
https://github.com/OpenRIAServices/OpenRiaServices/tree/main/src/OpenRiaServices.Hosting.AspNetCore/Framework#specifying-endpoint-routes)

//// Remove ".svc/binary" from the URI
const string toRemove = ".svc/binary/";
string uriString = uri.AbsoluteUri;

if (uriString.EndsWith(toRemove, StringComparison.Ordinal))
{
    uri = new Uri(uriString.Remove(uriString.Length - toRemove.Length));
}

Running code

            Func<Uri, HttpClient> httpClientFactory = uri =>
            {
                var behaviorHandler = new SharedCookieHeaderHandler { InnerHandler = inner };

                HttpClient httpClient = new HttpClient(behaviorHandler, disposeHandler: false)
                {
                    Timeout = TimeSpan.FromHours(2),
                    BaseAddress = uri
                };
                return httpClient;
            };

[neplan]

Thank you Daniel. With these changes it seems to work. Unfortunately the same change are not working in our main application. Probably we have to stay to version 5.5 and do an upgrade to .NET 8 or higher.

[Daniel-Svensson]

@neplan first some usage question and then something to try to fix your iisue

1. Do you have any plans to move client .NET ?

2. Will you be moving the server to AspNetCore ?
   I am thinking about stopping to release and test the WCF hosting now that the AspNetCore version is stable, tested and so much faster and easier to integrate with the rest of the .NET and AspNetCore ecosystems.

Setting Content-Type for GET reqeusts

3. As for the error it sounds a lot like your webserver configuration either forces Content-Type to be set OR you have the wrong base address somehow.

To force set Content-Type on GET requests you will have to add the following code someplace at startup

            // Hack .NET Framework in order to allow setting Content-Type to GET requests
            // https://stackoverflow.com/a/41231353
            var field = typeof(System.Net.Http.Headers.HttpRequestHeaders)
    .GetField("invalidHeaders", System.Reflection.BindingFlags.NonPublic | System.Reflection.BindingFlags.Static)
  ?? typeof(System.Net.Http.Headers.HttpRequestHeaders)
    .GetField("s_invalidHeaders", System.Reflection.BindingFlags.NonPublic | System.Reflection.BindingFlags.Static);
            if (field != null)
            {
                var invalidFields = (HashSet<string>)field.GetValue(null);
                invalidFields.Remove("Content-Type");
            }

Once that is done you can do someting similar to the following to set the header on GET requests as well.

Func<Uri, HttpClient> httpClientFactory = uri =>
{
    HttpClient httpClient = new HttpClient(behaviorHandler, disposeHandler: false)
    {
        Timeout = TimeSpan.FromHours(timeOutInHours),
        BaseAddress = uri
    };
    httpClient.DefaultRequestHeaders.Add("Content-Type", "application/msbin1");
    return httpClient;
};
DomainContext.DomainClientFactory = new BinaryHttpDomainClientFactory(baseUri, httpClientFactory);

In case of error I strongly recommend you to have a look att the failing request (against remote server) using fiddler or similar tool and comparing it to a working version

[neplan]

Thank you for the additional input. We are planing to update to .NET and AspNetCore. So for the time being we will keep the running version 5.5.