Add advisory lock timeout configuration with error on failure

- Add advisory_lock_timeout_seconds option (default: 15 seconds)
- Raise error when advisory lock cannot be acquired within timeout
- This provides explicit failure behavior for lock contention issues

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: eapache-opslevel

README.md

@@ -1,4 +1,29 @@
-# Closure Tree
+# Closure Tree (OpsLevel Fork)
+
+This is the OpsLevel fork of [closure_tree](https://github.com/ClosureTree/closure_tree), based on upstream v9.5.0.
+
+## Fork-Specific Changes
+
+This fork adds one enhancement to the advisory lock behavior:
+
+### Advisory Lock Timeout with Error on Failure
+
+- Adds `advisory_lock_timeout_seconds` option (default: 15 seconds)
+- Raises an error when the advisory lock cannot be acquired within the timeout period
+
+The upstream version has no timeout and hangs forever if lock acquisition fails. This fork uses `with_advisory_lock!` (with bang) which raises `WithAdvisoryLock::FailedToAcquireLock` when the lock cannot be obtained, providing explicit failure behavior for lock contention issues.
+
+```ruby
+class Tag < ApplicationRecord
+  # Use default 15 second timeout
+  has_closure_tree
+
+  # Or customize the timeout
+  has_closure_tree advisory_lock_timeout_seconds: 30
+end
+```
+
+---
 
 ### Closure_tree lets your ActiveRecord models act as nodes in a [tree data structure](http://en.wikipedia.org/wiki/Tree_%28data_structure%29)
 

lib/closure_tree/support.rb

@@ -19,6 +19,7 @@ def initialize(model_class, options)
         dependent: :nullify, # or :destroy, :delete_all, or :adopt -- see the README
         name_column: 'name',
         with_advisory_lock: true, # This will be overridden by adapter support
+        advisory_lock_timeout_seconds: 15,
         numeric_order: false
       }.merge(options)
       raise ArgumentError, "name_column can't be 'path'" if options[:name_column] == 'path'
@@ -153,8 +154,8 @@ def build_scope_where_clause(scope_conditions)
     end
 
     def with_advisory_lock(&block)
-      if options[:with_advisory_lock] && connection.supports_advisory_locks? && model_class.respond_to?(:with_advisory_lock)
-        model_class.with_advisory_lock(advisory_lock_name) do
+      if options[:with_advisory_lock] && connection.supports_advisory_locks? && model_class.respond_to?(:with_advisory_lock!)
+        model_class.with_advisory_lock!(advisory_lock_name, advisory_lock_options) do
           transaction(&block)
         end
       else

lib/closure_tree/support_attributes.rb

@@ -34,6 +34,10 @@ def advisory_lock_name
       end
     end
 
+    def advisory_lock_options
+      { timeout_seconds: options[:advisory_lock_timeout_seconds] }.compact
+    end
+
     def quoted_table_name
       connection.quote_table_name(table_name)
     end