Skip to content

Repair #152 merge fallout: dangling barrel export, duplicate package.json keys, crashing flavian pipeline ingest #154

Description

@PAMulligan

PR #152 (the IDML/PDF ingest work for #117) merged after a conflict-resolution merge that left main degraded. CI stayed green because no test exercised the broken paths.

Defects on main

  1. packages/pipeline/src/indesign/index.js statically re-exports resolveAssets, buildIngestBundle, writeIngestBundle, runIngest from ./ingest/index.js, which exports none of them — importing the package's ./indesign barrel throws at load.
  2. bin/flavian.mjs has a pipeline ingest subcommand that imports a non-existent runIngestflavian pipeline ingest crashes when invoked.
  3. Duplicate keys: pipeline:ingest ×2 in root package.json; flavian-ingest ×2 in packages/pipeline/package.json.
  4. packages/pipeline/src/indesign/assets/idml-assets.js (+ its test) landed but is unused by any stage.

Fix

Fix-forward: land the working stage-assets ETL stage (which makes idml-assets.js functional and provides the four names the barrel advertises), remove the crashing subcommand, dedupe the keys, and add a barrel-import regression test.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    Status
    In Progress

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions