Merge pull request #39 from PROCOLLAB-github/dev

Dev

Author: VeryBigSad

users/admin.py

@@ -1,6 +1,6 @@
 from django.contrib import admin
 
-from .models import CustomUser
+from .models import CustomUser, UserAchievement
 
 
 @admin.register(CustomUser)
@@ -91,3 +91,8 @@ class CustomUserAdmin(admin.ModelAdmin):
     def save_model(self, request, obj, form, change):
         obj.set_password(form.cleaned_data["password"])
         obj.save()
+
+
+@admin.register(UserAchievement)
+class UserAchievementAdmin(admin.ModelAdmin):
+    list_display = ("id", "title", "status", "user")

users/managers.py

@@ -1,5 +1,6 @@
 from django.contrib.auth.hashers import make_password
 from django.contrib.auth.models import UserManager
+from django.db.models import Manager
 
 
 class CustomUserManager(UserManager):
@@ -32,6 +33,7 @@ def get_users_for_detail_view(self):
                 "member__preferred_industries",
                 "expert__preferred_industries",
                 "investor__preferred_industries",
+                "achievements",
             )
             .all()
         )
@@ -42,3 +44,19 @@ def _create_user(self, email, password, **extra_fields):
         user.password = make_password(password)
         user.save()
         return user
+
+
+class UserAchievementManager(Manager):
+    def get_achievements_for_list_view(self):
+        return (
+            self.get_queryset()
+            .select_related("user")
+            .only("id", "title", "status", "user__id")
+        )
+
+    def get_achievements_for_detail_view(self):
+        return (
+            self.get_queryset()
+            .select_related("user")
+            .only("id", "title", "status", "user")
+        )

users/migrations/0016_userachievement.py

@@ -0,0 +1,44 @@
+# Generated by Django 4.1.2 on 2022-11-16 16:01
+
+from django.conf import settings
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("users", "0015_customuser_speciality"),
+    ]
+
+    operations = [
+        migrations.CreateModel(
+            name="UserAchievement",
+            fields=[
+                (
+                    "id",
+                    models.BigAutoField(
+                        auto_created=True,
+                        primary_key=True,
+                        serialize=False,
+                        verbose_name="ID",
+                    ),
+                ),
+                ("title", models.CharField(max_length=256)),
+                ("status", models.CharField(max_length=256)),
+                (
+                    "user",
+                    models.ForeignKey(
+                        null=True,
+                        on_delete=django.db.models.deletion.SET_NULL,
+                        related_name="achievements",
+                        to=settings.AUTH_USER_MODEL,
+                    ),
+                ),
+            ],
+            options={
+                "verbose_name": "Достижение",
+                "verbose_name_plural": "Достижения",
+            },
+        ),
+    ]

users/models.py

@@ -13,7 +13,7 @@
     VERBOSE_ROLE_TYPES,
     VERBOSE_USER_TYPES,
 )
-from users.managers import CustomUserManager
+from users.managers import CustomUserManager, UserAchievementManager
 
 
 def get_default_user_type():
@@ -91,6 +91,36 @@ def __str__(self):
         return f"User<{self.id}> - {self.first_name} {self.last_name}"
 
 
+class UserAchievement(models.Model):
+    """
+    UserAchievement model
+
+     Attributes:
+        title: A CharField title of the achievement.
+        status: A CharField place or status of the achievement.
+        user: A ForeignKey referring to the CustomUser model.
+    """
+
+    title = models.CharField(max_length=256, null=False)
+    status = models.CharField(max_length=256, null=False)
+
+    user = models.ForeignKey(
+        CustomUser,
+        on_delete=models.SET_NULL,
+        null=True,
+        related_name="achievements",
+    )
+
+    objects = UserAchievementManager()
+
+    def __str__(self):
+        return f"UserAchievement<{self.id}>"
+
+    class Meta:
+        verbose_name = "Достижение"
+        verbose_name_plural = "Достижения"
+
+
 class AbstractUserWithRole(models.Model):
     """
     AbstractUserWithRole abstract model

users/permissions.py

@@ -0,0 +1,19 @@
+from rest_framework.permissions import BasePermission, SAFE_METHODS
+
+
+class IsAchievementOwnerOrReadOnly(BasePermission):
+    """
+    Allows access to update only to himself.
+    """
+
+    def has_permission(self, request, view) -> bool:
+        if request.method in SAFE_METHODS or (
+            request.user and request.user.id == request.data.get("user")
+        ):
+            return True
+        return False
+
+    def has_object_permission(self, request, view, obj):
+        if request.method in SAFE_METHODS or (obj.user == request.user):
+            return True
+        return False

users/serializers.py

@@ -1,7 +1,17 @@
 from django.forms.models import model_to_dict
 from rest_framework import serializers
 
-from .models import CustomUser, Expert, Investor, Member, Mentor
+from .models import CustomUser, Expert, Investor, Member, Mentor, UserAchievement
+
+
+class AchievementListSerializer(serializers.ModelSerializer):
+    class Meta:
+        model = UserAchievement
+        fields = [
+            "id",
+            "title",
+            "status",
+        ]
 
 
 class MemberSerializer(serializers.ModelSerializer):
@@ -45,6 +55,7 @@ class UserDetailSerializer(serializers.ModelSerializer):
     investor = InvestorSerializer(required=False)
     expert = ExpertSerializer(required=False)
     mentor = MentorSerializer(required=False)
+    achievements = AchievementListSerializer(required=False, many=True)
 
     class Meta:
         model = CustomUser
@@ -63,6 +74,7 @@ class Meta:
             "investor",
             "expert",
             "mentor",
+            "achievements",
         ]
 
     def update(self, instance, validated_data):
@@ -90,12 +102,19 @@ def update(self, instance, validated_data):
         # maybe it's better to write ALLOWED_UPDATABLE_FIELDS = ["first_name", "last_name", ...]
         IMMUTABLE_FIELDS = ("email", "user_type", "is_active", "password")
         USER_TYPE_FIELDS = ("member", "investor", "expert", "mentor")
-
+        RELATED_FIELDS = ("achievements",)
         for attr, value in validated_data.items():
-            if attr in IMMUTABLE_FIELDS + USER_TYPE_FIELDS:
+            if attr in IMMUTABLE_FIELDS + USER_TYPE_FIELDS + RELATED_FIELDS:
                 continue
             setattr(instance, attr, value)
 
+        # if "achievements" in validated_data:
+        #     instance.achievements.all().delete()
+        #     instance.achievements.clear()
+        #     for achievement in validated_data["achievements"]:
+        #         obj = UserAchievement(**achievement)
+        #         obj.save()
+        #         instance.achievements.add(obj)
         instance.save()
 
         return instance
@@ -127,6 +146,17 @@ class Meta:
         extra_kwargs = {"password": {"write_only": True}}
 
 
+class AchievementDetailSerializer(serializers.ModelSerializer):
+    class Meta:
+        model = UserAchievement
+        fields = [
+            "id",
+            "title",
+            "status",
+            "user",
+        ]
+
+
 class EmailSerializer(serializers.Serializer):
     email = serializers.EmailField()
 

users/urls.py

@@ -1,6 +1,8 @@
 from django.urls import path, re_path
 
 from users.views import (
+    AchievementDetail,
+    AchievementList,
     CurrentUser,
     EmailResetPassword,
     ResetPassword,
@@ -24,6 +26,8 @@
     path("users/<int:pk>/", UserDetail.as_view()),
     path("users/reset-password/", EmailResetPassword.as_view()),
     path("users/current/", CurrentUser.as_view()),
+    path("users/achievements/", AchievementList.as_view()),
+    path("users/achievements/<int:pk>/", AchievementDetail.as_view()),
     re_path(
         r"^account-confirm-email/",
         VerifyEmail.as_view(),

users/views.py

@@ -24,7 +24,11 @@
 from core.permissions import IsOwnerOrReadOnly
 from core.utils import Email
 from users.helpers import VERBOSE_ROLE_TYPES
+from users.models import UserAchievement
+from users.permissions import IsAchievementOwnerOrReadOnly
 from users.serializers import (
+    AchievementDetailSerializer,
+    AchievementListSerializer,
     EmailSerializer,
     PasswordSerializer,
     UserDetailSerializer,
@@ -254,3 +258,15 @@ def update(self, request, *args, **kwargs):
                 status=status.HTTP_400_BAD_REQUEST,
                 message="Decode error",
             )
+
+
+class AchievementList(ListCreateAPIView):
+    queryset = UserAchievement.objects.get_achievements_for_list_view()
+    serializer_class = AchievementListSerializer
+    permission_classes = [IsAchievementOwnerOrReadOnly]
+
+
+class AchievementDetail(RetrieveUpdateDestroyAPIView):
+    queryset = UserAchievement.objects.get_achievements_for_detail_view()
+    serializer_class = AchievementDetailSerializer
+    permission_classes = [IsAchievementOwnerOrReadOnly]