Revert "fix: module OnRemove test no longer skips for modules without class exporter"

This reverts commit c694fad.

Author: MariusStorhaug

src/tests/Module/PSModule/PSModule.Tests.ps1

@@ -84,22 +84,23 @@ Describe 'PSModule - Module tests' {
         }
     }
 
-    Context 'Framework - Module OnRemove cleanup' {
-        It 'Should remove the module cleanly and re-import without errors' {
+    Context 'Framework - Module OnRemove cleanup' -Skip:(-not $hasClassExporter) {
+        It 'Should clean up type accelerators when the module is removed' {
+            # Capture type names before removal
+            $typeNames = @(@($expectedEnumNames) + @($expectedClassNames) | Where-Object { $_ })
+            $typeNames | Should -Not -BeNullOrEmpty -Because 'there should be types to verify cleanup for'
+
             # Remove the module to trigger the OnRemove hook
-            { Remove-Module -Name $moduleName -Force } | Should -Not -Throw
+            Remove-Module -Name $moduleName -Force
 
-            # Verify type accelerators are cleaned up when class exporter is present
-            if ($hasClassExporter) {
-                $typeNames = @(@($expectedEnumNames) + @($expectedClassNames) | Where-Object { $_ })
-                $typeAccelerators = [psobject].Assembly.GetType('System.Management.Automation.TypeAccelerators')::Get
-                foreach ($typeName in $typeNames) {
-                    $typeAccelerators.Keys | Should -Not -Contain $typeName -Because "the OnRemove hook should remove type accelerator [$typeName]"
-                }
+            # Verify type accelerators are cleaned up
+            $typeAccelerators = [psobject].Assembly.GetType('System.Management.Automation.TypeAccelerators')::Get
+            foreach ($typeName in $typeNames) {
+                $typeAccelerators.Keys | Should -Not -Contain $typeName -Because "the OnRemove hook should remove type accelerator [$typeName]"
             }
 
             # Re-import the module for any subsequent tests
-            { Import-Module -Name $moduleName -Force } | Should -Not -Throw
+            Import-Module -Name $moduleName -Force
         }
     }
 }