Commit 5176de9
authored
fix: stale modelSlug (#100)
1. fix: remove definition of `currentConversation` as it is not used (to
fix the following error when running `npm run build:prd:chrome`
```bash
> webapp@0.0.0 build:prd:chrome
> bash -c 'source ./scripts/build-prd-chrome.sh'
🧩 Start building Chrome Extension ...
📦 Version: 2.16.0
📦 Monorepo Revision: 9fc435
📦 Beta Build: false
📦 API Endpoint: https://app.paperdebugger.com
❌ Failed to build Chrome Extension, please check logs/build.log
> webapp@0.0.0 build
> tsc -b && npm run _build:default && npm run _build:background && npm run _build:intermediate && npm run _build:settings && npm run _build:popup
src/views/settings/setting-text-input.tsx(32,13): error TS6133: 'currentConversation' is declared but its value is never read.
```
2. fix: change matching from substring to exact, to prevent
`gpt-4.1-mini` from matching to `gpt-4.0` (edit: typo, should be
`gpt-4.1`), making the method more robust to the order of supported
models defined.
3. [edit] refactor: use IsCustom and not redefine logic in NewAIClientV21 parent 9fc435f commit 5176de9
2 files changed
Lines changed: 25 additions & 13 deletions
File tree
- internal/services/toolkit/client
- webapp/_webapp/src/views/settings
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
66 | 74 | | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
73 | 81 | | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
79 | 85 | | |
80 | 86 | | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
81 | 93 | | |
82 | 94 | | |
83 | 95 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
| 32 | + | |
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | | - | |
| 62 | + | |
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
| |||
0 commit comments