chore: update .gitignore and enhance project instruction handling in conversation preparation

Junyi-99 · Junyi-99 · commit ba572426d0bb · 2026-01-27T01:17:51.000+08:00
- Added '.claude' to .gitignore to exclude specific files from version control.
- Refactored conversation preparation logic in both V1 and V2 to use a local variable for project instructions, improving code clarity.
- Updated toolkit client to register file and LaTeX tools with project service injection, enhancing functionality.
- Modified error messages in file and folder tools to indicate unimplemented features.
diff --git a/.gitignore b/.gitignore
@@ -1,3 +1,5 @@
+.claude
+
 # docker image build
 .dockerignore
 node_modules
diff --git a/internal/api/chat/create_conversation_message_stream.go b/internal/api/chat/create_conversation_message_stream.go
@@ -207,9 +207,13 @@ func (s *ChatServerV1) prepare(ctx context.Context, projectId string, conversati
 	}
 
 	var latexFullSource string
+	var projectInstructions string
 	switch conversationType {
 	case chatv1.ConversationType_CONVERSATION_TYPE_DEBUG:
 		latexFullSource = "latex_full_source is not available in debug mode"
+		if project != nil {
+			projectInstructions = project.Instructions
+		}
 	default:
 		if project == nil || project.IsOutOfDate() {
 			return ctx, nil, nil, shared.ErrProjectOutOfDate("project is out of date")
@@ -219,6 +223,7 @@ func (s *ChatServerV1) prepare(ctx context.Context, projectId string, conversati
 		if err != nil {
 			return ctx, nil, nil, err
 		}
+		projectInstructions = project.Instructions
 	}
 
 	var conversation *models.Conversation
@@ -229,7 +234,7 @@ func (s *ChatServerV1) prepare(ctx context.Context, projectId string, conversati
 			actor.ID,
 			projectId,
 			latexFullSource,
-			project.Instructions,
+			projectInstructions,
 			userInstructions,
 			userMessage,
 			userSelectedText,
diff --git a/internal/api/chat/create_conversation_message_stream_v2.go b/internal/api/chat/create_conversation_message_stream_v2.go
@@ -225,9 +225,13 @@ func (s *ChatServerV2) prepare(ctx context.Context, projectId string, conversati
 	}
 
 	var latexFullSource string
+	var projectInstructions string
 	switch conversationType {
 	case chatv2.ConversationType_CONVERSATION_TYPE_DEBUG:
 		latexFullSource = "latex_full_source is not available in debug mode"
+		if project != nil {
+			projectInstructions = project.Instructions
+		}
 	default:
 		if project == nil || project.IsOutOfDate() {
 			return ctx, nil, nil, nil, shared.ErrProjectOutOfDate("project is out of date")
@@ -237,6 +241,7 @@ func (s *ChatServerV2) prepare(ctx context.Context, projectId string, conversati
 		if err != nil {
 			return ctx, nil, nil, nil, err
 		}
+		projectInstructions = project.Instructions
 	}
 
 	var conversation *models.Conversation
@@ -249,7 +254,7 @@ func (s *ChatServerV2) prepare(ctx context.Context, projectId string, conversati
 			actor.ID,
 			projectId,
 			latexFullSource,
-			project.Instructions,
+			projectInstructions,
 			userInstructions,
 			userMessage,
 			userSelectedText,
diff --git a/internal/services/toolkit/client/utils_v2.go b/internal/services/toolkit/client/utils_v2.go
@@ -12,6 +12,8 @@ import (
 	"paperdebugger/internal/libs/logger"
 	"paperdebugger/internal/services"
 	"paperdebugger/internal/services/toolkit/registry"
+	filetools "paperdebugger/internal/services/toolkit/tools/files"
+	latextools "paperdebugger/internal/services/toolkit/tools/latex"
 	"paperdebugger/internal/services/toolkit/tools/xtramcp"
 	chatv2 "paperdebugger/pkg/gen/api/chat/v2"
 	"strings"
@@ -109,40 +111,26 @@ func initializeToolkitV2(
 ) *registry.ToolRegistryV2 {
 	toolRegistry := registry.NewToolRegistryV2()
 
-	// Register static file tools (create/delete don't need ProjectService - they're placeholder only)
-	// toolRegistry.Register("create_file", filetools.CreateFileToolDescriptionV2, filetools.CreateFileTool)
-	// toolRegistry.Register("delete_file", filetools.DeleteFileToolDescriptionV2, filetools.DeleteFileTool)
-	// toolRegistry.Register("create_folder", filetools.CreateFolderToolDescriptionV2, filetools.CreateFolderTool)
-	// toolRegistry.Register("delete_folder", filetools.DeleteFolderToolDescriptionV2, filetools.DeleteFolderTool)
-
-	// Register file tools with ProjectService injection
-	// readFileTool := filetools.NewReadFileTool(projectService)
-	// toolRegistry.Register("read_file", filetools.ReadFileToolDescriptionV2, readFileTool.Call)
-
-	// listFolderTool := filetools.NewListFolderTool(projectService)
-	// toolRegistry.Register("list_folder", filetools.ListFolderToolDescriptionV2, listFolderTool.Call)
-
-	// searchStringTool := filetools.NewSearchStringTool(projectService)
-	// toolRegistry.Register("search_string", filetools.SearchStringToolDescriptionV2, searchStringTool.Call)
-
-	// searchFileTool := filetools.NewSearchFileTool(projectService)
-	// toolRegistry.Register("search_file", filetools.SearchFileToolDescriptionV2, searchFileTool.Call)
-
-	logger.Info("[AI Client V2] Registered static file tools", "count", 0)
-
-	// Register LaTeX tools with ProjectService injection
-	// documentStructureTool := latextools.NewDocumentStructureTool(projectService)
-	// toolRegistry.Register("get_document_structure", latextools.GetDocumentStructureToolDescriptionV2, documentStructureTool.Call)
-
-	// toolRegistry.Register("locate_section", latextools.LocateSectionToolDescriptionV2, latextools.LocateSectionTool)
-
-	// readSectionSourceTool := latextools.NewReadSectionSourceTool(projectService)
-	// toolRegistry.Register("read_section_source", latextools.ReadSectionSourceToolDescriptionV2, readSectionSourceTool.Call)
-
-	// readSourceLineRangeTool := latextools.NewReadSourceLineRangeTool(projectService)
-	// toolRegistry.Register("read_source_line_range", latextools.ReadSourceLineRangeToolDescriptionV2, readSourceLineRangeTool.Call)
-
-	logger.Info("[AI Client V2] Registered static LaTeX tools", "count", 0)
+	readFileTool := filetools.NewReadFileTool(projectService)
+	listFolderTool := filetools.NewListFolderTool(projectService)
+	searchStringTool := filetools.NewSearchStringTool(projectService)
+	searchFileTool := filetools.NewSearchFileTool(projectService)
+	documentStructureTool := latextools.NewDocumentStructureTool(projectService)
+	readSectionSourceTool := latextools.NewReadSectionSourceTool(projectService)
+	readSourceLineRangeTool := latextools.NewReadSourceLineRangeTool(projectService)
+
+	toolRegistry.Register("create_file", filetools.CreateFileToolDescriptionV2, filetools.CreateFileTool)
+	toolRegistry.Register("delete_file", filetools.DeleteFileToolDescriptionV2, filetools.DeleteFileTool)
+	toolRegistry.Register("create_folder", filetools.CreateFolderToolDescriptionV2, filetools.CreateFolderTool)
+	toolRegistry.Register("delete_folder", filetools.DeleteFolderToolDescriptionV2, filetools.DeleteFolderTool)
+	toolRegistry.Register("read_file", filetools.ReadFileToolDescriptionV2, readFileTool.Call)
+	toolRegistry.Register("list_folder", filetools.ListFolderToolDescriptionV2, listFolderTool.Call)
+	toolRegistry.Register("search_string", filetools.SearchStringToolDescriptionV2, searchStringTool.Call)
+	toolRegistry.Register("search_file", filetools.SearchFileToolDescriptionV2, searchFileTool.Call)
+	toolRegistry.Register("get_document_structure", latextools.GetDocumentStructureToolDescriptionV2, documentStructureTool.Call)
+	toolRegistry.Register("locate_section", latextools.LocateSectionToolDescriptionV2, latextools.LocateSectionTool)
+	toolRegistry.Register("read_section_source", latextools.ReadSectionSourceToolDescriptionV2, readSectionSourceTool.Call)
+	toolRegistry.Register("read_source_line_range", latextools.ReadSourceLineRangeToolDescriptionV2, readSourceLineRangeTool.Call)
 
 	// Load tools dynamically from backend
 	xtraMCPLoader := xtramcp.NewXtraMCPLoaderV2(db, projectService, cfg.XtraMCPURI)
diff --git a/internal/services/toolkit/tools/files/file_create.go b/internal/services/toolkit/tools/files/file_create.go
@@ -45,5 +45,5 @@ func CreateFileTool(ctx context.Context, toolCallId string, args json.RawMessage
 	}
 
 	// TODO: Implement actual file creation logic
-	return fmt.Sprintf("[DUMMY] File created at: %s (content length: %d bytes)", getArgs.Path, len(getArgs.Content)), "", nil
+	return "", "", fmt.Errorf("create_file tool is not yet implemented: cannot create file at %s", getArgs.Path)
 }
diff --git a/internal/services/toolkit/tools/files/file_delete.go b/internal/services/toolkit/tools/files/file_delete.go
@@ -40,5 +40,5 @@ func DeleteFileTool(ctx context.Context, toolCallId string, args json.RawMessage
 	}
 
 	// TODO: Implement actual file deletion logic
-	return fmt.Sprintf("[DUMMY] File deleted: %s", getArgs.Path), "", nil
+	return "", "", fmt.Errorf("delete_file tool is not yet implemented: cannot delete file at %s", getArgs.Path)
 }
diff --git a/internal/services/toolkit/tools/files/file_search.go b/internal/services/toolkit/tools/files/file_search.go
@@ -104,7 +104,7 @@ func (t *SearchFileTool) Call(ctx context.Context, toolCallId string, args json.
 				if !recursive && dir != searchPath {
 					continue
 				}
-				if recursive && !strings.HasPrefix(docPath, searchPath) {
+				if recursive && !strings.HasPrefix(docPath, searchPath+"/") {
 					continue
 				}
 			}
diff --git a/internal/services/toolkit/tools/files/folder_create.go b/internal/services/toolkit/tools/files/folder_create.go
@@ -40,5 +40,5 @@ func CreateFolderTool(ctx context.Context, toolCallId string, args json.RawMessa
 	}
 
 	// TODO: Implement actual folder creation logic
-	return fmt.Sprintf("[DUMMY] Folder created at: %s", getArgs.Path), "", nil
+	return "", "", fmt.Errorf("create_folder tool is not yet implemented: cannot create folder at %s", getArgs.Path)
 }
diff --git a/internal/services/toolkit/tools/files/folder_delete.go b/internal/services/toolkit/tools/files/folder_delete.go
@@ -44,11 +44,6 @@ func DeleteFolderTool(ctx context.Context, toolCallId string, args json.RawMessa
 		return "", "", err
 	}
 
-	recursive := false
-	if getArgs.Recursive != nil {
-		recursive = *getArgs.Recursive
-	}
-
 	// TODO: Implement actual folder deletion logic
-	return fmt.Sprintf("[DUMMY] Folder deleted: %s (recursive: %v)", getArgs.Path, recursive), "", nil
+	return "", "", fmt.Errorf("delete_folder tool is not yet implemented: cannot delete folder at %s", getArgs.Path)
 }
diff --git a/internal/services/toolkit/tools/latex/locate_section.go b/internal/services/toolkit/tools/latex/locate_section.go
@@ -40,8 +40,5 @@ func LocateSectionTool(ctx context.Context, toolCallId string, args json.RawMess
 	}
 
 	// TODO: Implement actual section location logic
-	return fmt.Sprintf(`[DUMMY] Located section '%s':
-File: main.tex
-Start Line: 42
-End Line: 87`, getArgs.Title), "", nil
+	return "", "", fmt.Errorf("locate_section tool is not yet implemented: cannot locate section '%s'", getArgs.Title)
 }
diff --git a/webapp/_webapp/src/libs/google-analytics.ts b/webapp/_webapp/src/libs/google-analytics.ts
@@ -75,10 +75,10 @@ class Analytics {
   }
 
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  async fireErrorEvent(error: any, additionalParams = {}) {
+  async fireErrorEvent(clientId: string | undefined, error: any, additionalParams = {}) {
     // Note: 'error' is a reserved event name and cannot be used
     // see https://developers.google.com/analytics/devguides/collection/protocol/ga4/reference?client_type=gtag#reserved_names
-    return this.fireEvent("extension_error", {
+    return this.fireEvent(clientId, "extension_error", {
       ...error,
       ...additionalParams,
     });
diff --git a/webapp/office/src/adapters/document-adapter.ts b/webapp/office/src/adapters/document-adapter.ts
@@ -228,7 +228,7 @@ export class WordAdapter implements DocumentAdapter {
       }
     };
 
-    intervalId = setInterval(checkSelection, 500);
+    intervalId = setInterval(checkSelection, 1000);
     checkSelection();
 
     return () => {

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+.claude`
	`2`	`+`
`1`	`3`	`# docker image build`
`2`	`4`	`.dockerignore`
`3`	`5`	`node_modules`
Original file line number	Diff line number	Diff line change
`@@ -45,5 +45,5 @@ func CreateFileTool(ctx context.Context, toolCallId string, args json.RawMessage`
`45`	`45`	`}`
`46`	`46`
`47`	`47`	`// TODO: Implement actual file creation logic`
`48`		`- return fmt.Sprintf("[DUMMY] File created at: %s (content length: %d bytes)", getArgs.Path, len(getArgs.Content)), "", nil`
	`48`	`+ return "", "", fmt.Errorf("create_file tool is not yet implemented: cannot create file at %s", getArgs.Path)`
`49`	`49`	`}`
Original file line number	Diff line number	Diff line change
`@@ -40,5 +40,5 @@ func DeleteFileTool(ctx context.Context, toolCallId string, args json.RawMessage`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`// TODO: Implement actual file deletion logic`
`43`		`- return fmt.Sprintf("[DUMMY] File deleted: %s", getArgs.Path), "", nil`
	`43`	`+ return "", "", fmt.Errorf("delete_file tool is not yet implemented: cannot delete file at %s", getArgs.Path)`
`44`	`44`	`}`
Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ func (t *SearchFileTool) Call(ctx context.Context, toolCallId string, args json.`
`104`	`104`	`if !recursive && dir != searchPath {`
`105`	`105`	`continue`
`106`	`106`	`}`
`107`		`- if recursive && !strings.HasPrefix(docPath, searchPath) {`
	`107`	`+ if recursive && !strings.HasPrefix(docPath, searchPath+"/") {`
`108`	`108`	`continue`
`109`	`109`	`}`
`110`	`110`	`}`
Original file line number	Diff line number	Diff line change
`@@ -40,5 +40,5 @@ func CreateFolderTool(ctx context.Context, toolCallId string, args json.RawMessa`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`// TODO: Implement actual folder creation logic`
`43`		`- return fmt.Sprintf("[DUMMY] Folder created at: %s", getArgs.Path), "", nil`
	`43`	`+ return "", "", fmt.Errorf("create_folder tool is not yet implemented: cannot create folder at %s", getArgs.Path)`
`44`	`44`	`}`
Original file line number	Diff line number	Diff line change
`@@ -44,11 +44,6 @@ func DeleteFolderTool(ctx context.Context, toolCallId string, args json.RawMessa`
`44`	`44`	`return "", "", err`
`45`	`45`	`}`
`46`	`46`
`47`		`- recursive := false`
`48`		`- if getArgs.Recursive != nil {`
`49`		`- recursive = *getArgs.Recursive`
`50`		`- }`
`51`		`-`
`52`	`47`	`// TODO: Implement actual folder deletion logic`
`53`		`- return fmt.Sprintf("[DUMMY] Folder deleted: %s (recursive: %v)", getArgs.Path, recursive), "", nil`
	`48`	`+ return "", "", fmt.Errorf("delete_folder tool is not yet implemented: cannot delete folder at %s", getArgs.Path)`
`54`	`49`	`}`
Original file line number	Diff line number	Diff line change
`@@ -40,8 +40,5 @@ func LocateSectionTool(ctx context.Context, toolCallId string, args json.RawMess`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`// TODO: Implement actual section location logic`
`43`		- return fmt.Sprintf(`[DUMMY] Located section '%s':
`44`		`-File: main.tex`
`45`		`-Start Line: 42`
`46`		-End Line: 87`, getArgs.Title), "", nil
	`43`	`+ return "", "", fmt.Errorf("locate_section tool is not yet implemented: cannot locate section '%s'", getArgs.Title)`
`47`	`44`	`}`