db: Refactor bulkAddPoints to use bulkWrite

Author: PartMan7

src/database/points.ts

@@ -32,7 +32,7 @@ const schema = new mongoose.Schema<MapModel>({
 	},
 });
 
-const model = mongoose.model<MapModel>('point', schema, 'points', {
+export const model = mongoose.model<MapModel>('point', schema, 'points', {
 	overwriteModels: true,
 });
 
@@ -53,26 +53,31 @@ export async function addPoints(user: string, points: Record<string, number>, ro
 	return document.toJSON();
 }
 
-export async function bulkAddPoints(bulkData: BulkPointsDataInput, roomId: string): Promise<Model[] | undefined> {
+export async function bulkAddPoints(bulkData: BulkPointsDataInput, roomId: string): Promise<boolean | undefined> {
 	if (!IS_ENABLED.DB) return;
-	const lookupIds = Object.keys(bulkData).map(userId => `${roomId}-${userId}`);
-	const userPoints = await model.find({ id: { $in: lookupIds } });
 	const roomConfig = PSRoomConfigs[roomId].points!;
 
-	const documentsToSave = await Promise.all(
-		Object.values(bulkData).map(async ({ name, id, points }) => {
-			const existing = userPoints.find(document => document.userId === id);
-			const document =
-				existing ?? (await model.create({ id: `${roomId}-${id}`, userId: id, name: name ?? id, roomId, points: new Map() }));
-			Object.keys(roomConfig.types).forEach(type => document.points.set(type, document.points.get(type) ?? 0));
-			document.name = name ?? id;
-			Object.entries(points).forEach(([type, count]) => document.points.set(type, (document.points.get(type) ?? 0) + count));
-			return document;
-		})
-	);
-
-	await model.bulkSave(documentsToSave);
-	return documentsToSave.map(document => document.toJSON());
+	const bulkQueries = Object.values(bulkData).map(({ id, name, points }) => ({
+		updateOne: {
+			filter: { id: `${roomId}-${id}` },
+			update: {
+				$setOnInsert: {
+					id: `${roomId}-${id}`,
+					roomId,
+					userId: id,
+					...Object.fromEntries(
+						roomConfig.priority.filter(type => typeof points[type] !== 'number').map(type => [`points.${type}`, 0])
+					),
+				},
+				$inc: Object.fromEntries(Object.entries(points).map(([type, amount]) => [`points.${type}`, amount])),
+				$set: { name: name ?? id },
+			},
+			upsert: true,
+		},
+	}));
+
+	const res = await model.bulkWrite(bulkQueries);
+	return res.isOk();
 }
 
 export async function getPoints(user: string, roomId: string): Promise<Model | null | undefined> {

src/ps/commands/kunc.ts

@@ -20,6 +20,7 @@ export const command: PSCommand = {
 	syntax: 'CMD [time?]',
 	perms: (message, checkPermission) => (message.type === 'chat' ? checkPermission('driver') : true),
 	categories: ['game'],
+	// TODO: Add end
 	async run({ message, arg, $T }): Promise<User[] | null> {
 		const id = message.type === 'chat' ? message.target.id : `pm-${message.author.id}`;
 		if (PSKuncInProgress[id]) {

src/ps/commands/points.tsx

@@ -126,13 +126,12 @@ export const command: PSCommand[] = [
 			);
 			const res = await bulkAddPoints(pointsData, message.target.id);
 			if (!res) throw new ChatError('Something went wrong...' as ToTranslate);
+
 			const pluralData = {
 				singular: pointsTypes.map(pointsType => pointsType.singular).join('/'),
 				plural: pointsTypes.map(pointsType => pointsType.plural).join('/'),
 			};
-			broadcast(
-				`Added ${pluralize<TranslatedText>(pointsAmount, pluralData)} to ${res.map(entry => entry.name ?? entry.id).list($T)}.` as ToTranslate
-			);
+			broadcast(`Added ${pluralize<TranslatedText>(pointsAmount, pluralData)} to ${users.list($T)}.` as ToTranslate);
 		},
 	},
 	{