Skip to content

Commit deeae45

Browse files
committed
Fix no-console rule and remove test console noise
1 parent 6363988 commit deeae45

5 files changed

Lines changed: 4 additions & 11 deletions

File tree

src/Frontend/eslint.config.mjs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,9 @@ const localPlugin = {
1111
},
1212
};
1313

14-
// Configure console rule: error in CI, warn in development
15-
const consoleRuleSeverity = process.env.CI === "true" ? "error" : "warn";
14+
// Configure console rule: error in CI to catch leftover debug calls before merge,
15+
// off locally so developers get no IDE warnings and can use console freely during development.
16+
const consoleRuleSeverity = process.env.CI === "true" ? "error" : "off";
1617

1718
export default tseslint.config(
1819
{

src/Frontend/test/drivers/vitest/driver.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,19 +63,15 @@ const test = testVitest.extend<{ driver: Driver }>({
6363
// eslint-disable-next-line no-empty-pattern, @typescript-eslint/no-explicit-any
6464
driver: async ({}, use: any) => {
6565
const driver = makeDriver();
66-
console.log("Starting test");
67-
6866
//run the test
6967
await use(driver);
7068

71-
console.log("Test ended");
7269
//unmount the app after the test runs
7370
driver.disposeApp();
7471

7572
// We need to wait for any pending promises to resolve before resetting handlers and clearing storage
7673
await flushPromises();
7774

78-
console.log("Cleanup after test");
7975
mockServer.resetHandlers();
8076
//Make JSDOM create a fresh document per each test run
8177
jsdom.reconfigure({ url: "http://localhost:3000/" });

src/Frontend/test/drivers/vitest/setup.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@ beforeEach(() => {
2525
});
2626

2727
beforeAll(() => {
28-
console.log("Starting mock server");
29-
3028
mockServer.listen({
3129
onUnhandledRequest: (_, print) => {
3230
print.warning();
@@ -35,6 +33,5 @@ beforeAll(() => {
3533
});
3634

3735
afterAll(() => {
38-
console.log("Shutting down mock server");
3936
mockServer.close();
4037
});

src/Frontend/test/mocks/scenarios/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,13 +45,13 @@ export async function loadScenario(): Promise<ScenarioModule> {
4545
const loader = scenarios[scenarioName];
4646

4747
if (!loader) {
48+
// eslint-disable-next-line no-console
4849
console.warn(`Unknown mock scenario: "${scenarioName}", falling back to default. Available: ${Object.keys(scenarios).join(", ")}`);
4950
const module = await scenarios.default();
5051
if (module.setupComplete) await module.setupComplete;
5152
return module;
5253
}
5354

54-
console.log(`Loading mock scenario: ${scenarioName}`);
5555
const module = await loader();
5656

5757
// Wait for setup to complete before returning

src/Frontend/test/preconditions/licensing.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ const getLicenseMockedResponse =
6363
license_status: status,
6464
license_extension_url: licenseExtensionUrl,
6565
};
66-
console.log(response);
6766
driver.mockEndpoint(`${serviceControlInstanceUrl}license`, {
6867
body: response,
6968
});

0 commit comments

Comments
 (0)