From be3fa22f7d3d9c7111b4815df73711bfa2f38728 Mon Sep 17 00:00:00 2001 From: Nightblade Date: Wed, 10 Sep 2025 19:54:46 +1000 Subject: [PATCH 1/3] pimp up the quest rewards display a bit --- src/Data/QuestRewards.lua | 128 +++++++++++++++++----------------- src/Modules/ConfigOptions.lua | 12 ++-- 2 files changed, 70 insertions(+), 70 deletions(-) diff --git a/src/Data/QuestRewards.lua b/src/Data/QuestRewards.lua index edf54cfea5..d661ce8cc4 100644 --- a/src/Data/QuestRewards.lua +++ b/src/Data/QuestRewards.lua @@ -1,66 +1,66 @@ return { { - -- "Beira of the Rotten Pack" ["Act"] = 1, - ["Type"] = "", + ["ActName"] = "Act 1", ["Area"] = "Clearfell", + ["Info"] = "Beira", ["Stat"] = "+10% to Cold Resistance", ["AreaLevel"] = 2, ["useConfig"] = true }, { - -- "The Crowbell" ["Act"] = 1, - ["Type"] = "", + ["ActName"] = "Act 1", ["Area"] = "Hunting Grounds", + ["Info"] = "Crowbell", ["Stat"] = "+2 Weapon Set Passive Skill Points", ["questPoints"] = 2, ["AreaLevel"] = 10, ["useConfig"] = false }, { - -- "The King in the Mists" ["Act"] = 1, - ["Type"] = "", + ["ActName"] = "Act 1", ["Area"] = "Freythorn", + ["Info"] = "King In The Mists", ["Stat"] = "+30 to Spirit", ["AreaLevel"] = 11, ["useConfig"] = true }, { - -- Una's Lute ["Act"] = 1, - ["Type"] = "", + ["ActName"] = "Act 1", ["Area"] = "Ogham Farmlands", + ["Info"] = "Una's Lute", ["Stat"] = "+2 Weapon Set Passive Skill Points", ["questPoints"] = 2, ["AreaLevel"] = 12, ["useConfig"] = false }, { - -- "Candlemass, the Living Rite" ["Act"] = 1, - ["Type"] = "", + ["ActName"] = "Act 1", ["Area"] = "Ogham Manor", + ["Info"] = "Candlemass", ["Stat"] = "+20 to maximum Life", ["AreaLevel"] = 15, ["useConfig"] = true }, { - -- "Kabala, Constrictor Queen" ["Act"] = 2, - ["Type"] = "", + ["ActName"] = "Act 2", ["Area"] = "Keth", + ["Info"] = "Kabala", ["Stat"] = "+2 Weapon Set Passive Skill Points", ["questPoints"] = 2, ["AreaLevel"] = 25, ["useConfig"] = false }, { - -- "Medallion" ["Act"] = 2, - ["Type"] = "", + ["ActName"] = "Act 2", ["Area"] = "Valley of the Titans", + ["Info"] = "Medallion", ["Options"] = { "30% increased Charm Charges Gained\n\t+1 Charm Slot", "30% increased Charm Effect Duration\n\t+1 Charm Slot", @@ -69,48 +69,48 @@ return { ["useConfig"] = true }, { - -- "Final Letter" ["Act"] = 2, - ["Type"] = "", + ["ActName"] = "Act 2", ["Area"] = "Deshar", + ["Info"] = "The Final Letter", ["Stat"] = "+2 Weapon Set Passive Skill Points", ["questPoints"] = 2, ["AreaLevel"] = 28, ["useConfig"] = false }, { - -- "Sisters of Garukhan Shrine" ["Act"] = 2, - ["Type"] = "", - ["Area"] = "The Spires of Deshar", + ["ActName"] = "Act 2", + ["Area"] = "Spires of Deshar", + ["Info"] = "Sisters of Garukhan Shrine", ["Stat"] = "+10% to Lightning Resistance", ["AreaLevel"] = 30, ["useConfig"] = true }, { - -- "Mighty Silverfist" ["Act"] = 3, - ["Type"] = "", + ["ActName"] = "Act 3", ["Area"] = "Jungle Ruins", + ["Info"] = "Mighty Silverfist", ["Stat"] = "+2 Weapon Set Passive Skill Points", ["questPoints"] = 2, ["AreaLevel"] = 34, ["useConfig"] = false }, { - -- "Ignagduk, the Bog Witch" ["Act"] = 3, - ["Type"] = "", - ["Area"] = "The Azak Bog", + ["ActName"] = "Act 3", + ["Area"] = "Azak Bog", + ["Info"] = "Ignagduk", ["Stat"] = "+30 to Spirit", ["AreaLevel"] = 36, ["useConfig"] = true }, { - -- "Venom Draught" ["Act"] = 3, - ["Type"] = "", - ["Area"] = "The Venom Crypts", + ["ActName"] = "Act 3", + ["Area"] = "Venom Crypts", + ["Info"] = "Venom Draught", ["Options"] = { "25% increased Stun Threshold", "30% increased Elemental Ailment Threshold", @@ -120,48 +120,48 @@ return { ["useConfig"] = true }, { - -- "Blackjaw, the Remnant" ["Act"] = 3, - ["Type"] = "", + ["ActName"] = "Act 3", ["Area"] = "Jiquani's Machinarium", + ["Info"] = "Blackjaw", ["Stat"] = "+10% to Fire Resistance", ["AreaLevel"] = 37, ["useConfig"] = true }, { - -- "Blood Sacrifice" ["Act"] = 3, - ["Type"] = "", + ["ActName"] = "Act 3", ["Area"] = "Aggorat", + ["Info"] = "Blood Sacrifice", ["Stat"] = "+2 Weapon Set Passive Skill Points", ["questPoints"] = 2, ["AreaLevel"] = 44, ["useConfig"] = false }, { - -- The Blind Beast ["Act"] = 4, - ["Type"] = "", + ["ActName"] = "Act 4", ["Area"] = "Isle Of Kin", + ["Info"] = "Blind Beast", ["Stat"] = "+2 Weapon Set Passive Skill Points", ["questPoints"] = 2, ["AreaLevel"] = 51, ["useConfig"] = false }, { - -- Silent Hall ["Act"] = 4, - ["Type"] = "", + ["ActName"] = "Act 4", ["Area"] = "Eye of Hinekora", + ["Info"] = "Silent Hall", ["Stat"] = "5% increased Maximum Mana", ["AreaLevel"] = 51, ["useConfig"] = true }, { - -- Halls of the dead ["Act"] = 4, - ["Type"] = "", - ["Area"] = "Tawhoa's Test", + ["ActName"] = "Act 4", + ["Area"] = "Halls Of The Dead", + ["Info"] = "Tawhoa's Test", ["Options"] = { "+5 to Dexterity", "+5% to Lightning Resistance", @@ -170,10 +170,10 @@ return { ["useConfig"] = true }, { - -- Halls of the dead ["Act"] = 4, - ["Type"] = "", - ["Area"] = "Tasalio's Test", + ["ActName"] = "Act 4", + ["Area"] = "Halls Of The Dead", + ["Info"] = "Tasalio's Test", ["Options"] = { "+5 to Intelligence", "+5% to Cold Resistance", @@ -182,10 +182,10 @@ return { ["useConfig"] = true }, { - -- Halls of the dead ["Act"] = 4, - ["Type"] = "", - ["Area"] = "Ngamahu's Test", + ["ActName"] = "Act 4", + ["Area"] = "Halls Of The Dead", + ["Info"] = "Ngamahu's Test", ["Options"] = { "+5 to Strength", "+5% to Fire Resistance", @@ -194,20 +194,20 @@ return { ["useConfig"] = true }, { - -- Hinekora ["Act"] = 4, - ["Type"] = "", + ["ActName"] = "Act 4", ["Area"] = "Trial Of The Ancestors", + ["Info"] = "Hinekora", ["Stat"] = "+2 Weapon Set Passive Skill Points", ["questPoints"] = 2, ["AreaLevel"] = 51, ["useConfig"] = false }, { - -- "Goddess of Justice" ["Act"] = 4, - ["Type"] = "", - ["Area"] = "Abandoned prison", + ["ActName"] = "Act 4", + ["Area"] = "Abandoned Prison", + ["Info"] = "Goddess of Justice", ["Options"] = { "30% increased Life Recovery from Flasks", "30% increased Mana Recovery from Flasks", @@ -216,39 +216,39 @@ return { ["useConfig"] = true }, { - -- "Oswin, the Dread Warden" ["Act"] = 5, - ["Type"] = "Interlude 1", + ["ActName"] = "Interlude 1", ["Area"] = "Wolvenhold", + ["Info"] = "Oswin", ["Stat"] = "+2 Weapon Set Passive Skill Points", ["questPoints"] = 2, ["AreaLevel"] = 64, ["useConfig"] = false }, { - -- "Clearing The Way" ["Act"] = 5, - ["Type"] = "Interlude 2", + ["ActName"] = "Interlude 2", ["Area"] = "Khari Bazaar", + ["Info"] = "Clearing The Way", ["Stat"] = "+2 Weapon Set Passive Skill Points", ["questPoints"] = 2, ["AreaLevel"] = 61, ["useConfig"] = false }, { - -- "Molten Shrine" ["Act"] = 5, - ["Type"] = "Interlude 2", - ["Area"] = "The Khari Crossing", + ["ActName"] = "Interlude 2", + ["Area"] = "Khari Crossing", + ["Info"] = "Molten Shrine", ["Stat"] = "5% increased maximum Life", ["AreaLevel"] = 61, ["useConfig"] = true }, { - -- "The Seven Pillars" ["Act"] = 5, - ["Type"] = "Interlude 2", + ["ActName"] = "Interlude 2", ["Area"] = "Qimah", + ["Info"] = "Seven Pillars", ["Options"] = { "+5% to Elemental Resistances", "3% increased Movement Speed", @@ -262,29 +262,29 @@ return { ["useConfig"] = true }, { - -- "Lythara, the Wayward Spear" ["Act"] = 5, - ["Type"] = "Interlude 3", + ["ActName"] = "Interlude 3", ["Area"] = "Kriar Village", + ["Info"] = "Lythara", ["Stat"] = "+40 to Spirit", ["AreaLevel"] = 61, ["useConfig"] = true }, { - -- "The Abominable Yeti" ["Act"] = 5, - ["Type"] = "Interlude 3", + ["ActName"] = "Interlude 3", ["Area"] = "Howling Caves", + ["Info"] = "Abominable Yeti", ["Stat"] = "+2 Weapon Set Passive Skill Points", ["questPoints"] = 2, ["AreaLevel"] = 62, ["useConfig"] = false }, { - -- "Siege Of Oriath" ["Act"] = 6, - ["Type"] = "Epilog", + ["ActName"] = "Epilog", ["Area"] = "Kingsmarch", + ["Info"] = "Siege Of Oriath", ["Stat"] = "+2 Weapon Set Passive Skill Points", ["questPoints"] = 2, ["AreaLevel"] = 62, diff --git a/src/Modules/ConfigOptions.lua b/src/Modules/ConfigOptions.lua index ddbbf4b2bd..818dad8ef0 100644 --- a/src/Modules/ConfigOptions.lua +++ b/src/Modules/ConfigOptions.lua @@ -55,7 +55,7 @@ end local function addQuestModsRewardsConfigOptions(configSettings) table.insert(configSettings, { section = "Quest Rewards", col = 3 }) - + -- Loop through sections of line to apply multiple mods local function applyModsFromString(source, str, modList) for line in tostring(str):gmatch("[^\r\n]+") do @@ -69,16 +69,16 @@ local function addQuestModsRewardsConfigOptions(configSettings) if quest.useConfig == false then goto continue end - local key = "questAct" .. quest.Act .. quest.Type .. quest.Area - local label = string.format("Act %d %s: %s", quest.Act, quest.Type, quest.Area) - local source = string.format("Quest:Act %d %s %s", quest.Act, quest.Type, quest.Area) + local key = "questAct" .. quest.Act .. quest.ActName .. quest.Area .. quest.Info + local label = string.format("%s: %s", quest.ActName, quest.Area) + local source = string.format("Quest:%s: %s", quest.ActName, quest.Area) if quest.Stat then table.insert(configSettings, { var = key, label = label, type = "check", defaultState = true, - tooltip = quest.Stat, + tooltip = "^x88FFFF" .. quest.Info .. "^7\n" .. quest.Stat, apply = function(val, modList, enemyModList) applyModsFromString(source, quest.Stat, modList) end @@ -94,7 +94,7 @@ local function addQuestModsRewardsConfigOptions(configSettings) type = "list", list = listOptions, defaultIndex = 1, - tooltip = "Choose one of the following options:\n" .. table.concat(quest.Options, "\n"), + tooltip = "^x88FFFF" .. quest.Info .. "^7\nOne of the following:\n" .. table.concat(quest.Options, "\n"), apply = function(val, modList, enemyModList) if val == "None" then return From 9418b18f6155d630aad569ce5c1e6e619daed078 Mon Sep 17 00:00:00 2001 From: Nightblade Date: Wed, 10 Sep 2025 20:21:53 +1000 Subject: [PATCH 2/3] naming things is hard --- src/Data/QuestRewards.lua | 56 +++++++++++++++++------------------ src/Modules/ConfigOptions.lua | 6 ++-- 2 files changed, 31 insertions(+), 31 deletions(-) diff --git a/src/Data/QuestRewards.lua b/src/Data/QuestRewards.lua index d661ce8cc4..d2ae60a42a 100644 --- a/src/Data/QuestRewards.lua +++ b/src/Data/QuestRewards.lua @@ -1,7 +1,7 @@ return { { ["Act"] = 1, - ["ActName"] = "Act 1", + ["Description"] = "Act 1", ["Area"] = "Clearfell", ["Info"] = "Beira", ["Stat"] = "+10% to Cold Resistance", @@ -10,7 +10,7 @@ return { }, { ["Act"] = 1, - ["ActName"] = "Act 1", + ["Description"] = "Act 1", ["Area"] = "Hunting Grounds", ["Info"] = "Crowbell", ["Stat"] = "+2 Weapon Set Passive Skill Points", @@ -20,7 +20,7 @@ return { }, { ["Act"] = 1, - ["ActName"] = "Act 1", + ["Description"] = "Act 1", ["Area"] = "Freythorn", ["Info"] = "King In The Mists", ["Stat"] = "+30 to Spirit", @@ -29,7 +29,7 @@ return { }, { ["Act"] = 1, - ["ActName"] = "Act 1", + ["Description"] = "Act 1", ["Area"] = "Ogham Farmlands", ["Info"] = "Una's Lute", ["Stat"] = "+2 Weapon Set Passive Skill Points", @@ -39,7 +39,7 @@ return { }, { ["Act"] = 1, - ["ActName"] = "Act 1", + ["Description"] = "Act 1", ["Area"] = "Ogham Manor", ["Info"] = "Candlemass", ["Stat"] = "+20 to maximum Life", @@ -48,7 +48,7 @@ return { }, { ["Act"] = 2, - ["ActName"] = "Act 2", + ["Description"] = "Act 2", ["Area"] = "Keth", ["Info"] = "Kabala", ["Stat"] = "+2 Weapon Set Passive Skill Points", @@ -58,7 +58,7 @@ return { }, { ["Act"] = 2, - ["ActName"] = "Act 2", + ["Description"] = "Act 2", ["Area"] = "Valley of the Titans", ["Info"] = "Medallion", ["Options"] = { @@ -70,7 +70,7 @@ return { }, { ["Act"] = 2, - ["ActName"] = "Act 2", + ["Description"] = "Act 2", ["Area"] = "Deshar", ["Info"] = "The Final Letter", ["Stat"] = "+2 Weapon Set Passive Skill Points", @@ -80,7 +80,7 @@ return { }, { ["Act"] = 2, - ["ActName"] = "Act 2", + ["Description"] = "Act 2", ["Area"] = "Spires of Deshar", ["Info"] = "Sisters of Garukhan Shrine", ["Stat"] = "+10% to Lightning Resistance", @@ -89,7 +89,7 @@ return { }, { ["Act"] = 3, - ["ActName"] = "Act 3", + ["Description"] = "Act 3", ["Area"] = "Jungle Ruins", ["Info"] = "Mighty Silverfist", ["Stat"] = "+2 Weapon Set Passive Skill Points", @@ -99,7 +99,7 @@ return { }, { ["Act"] = 3, - ["ActName"] = "Act 3", + ["Description"] = "Act 3", ["Area"] = "Azak Bog", ["Info"] = "Ignagduk", ["Stat"] = "+30 to Spirit", @@ -108,7 +108,7 @@ return { }, { ["Act"] = 3, - ["ActName"] = "Act 3", + ["Description"] = "Act 3", ["Area"] = "Venom Crypts", ["Info"] = "Venom Draught", ["Options"] = { @@ -121,7 +121,7 @@ return { }, { ["Act"] = 3, - ["ActName"] = "Act 3", + ["Description"] = "Act 3", ["Area"] = "Jiquani's Machinarium", ["Info"] = "Blackjaw", ["Stat"] = "+10% to Fire Resistance", @@ -130,7 +130,7 @@ return { }, { ["Act"] = 3, - ["ActName"] = "Act 3", + ["Description"] = "Act 3", ["Area"] = "Aggorat", ["Info"] = "Blood Sacrifice", ["Stat"] = "+2 Weapon Set Passive Skill Points", @@ -140,7 +140,7 @@ return { }, { ["Act"] = 4, - ["ActName"] = "Act 4", + ["Description"] = "Act 4", ["Area"] = "Isle Of Kin", ["Info"] = "Blind Beast", ["Stat"] = "+2 Weapon Set Passive Skill Points", @@ -150,7 +150,7 @@ return { }, { ["Act"] = 4, - ["ActName"] = "Act 4", + ["Description"] = "Act 4", ["Area"] = "Eye of Hinekora", ["Info"] = "Silent Hall", ["Stat"] = "5% increased Maximum Mana", @@ -159,7 +159,7 @@ return { }, { ["Act"] = 4, - ["ActName"] = "Act 4", + ["Description"] = "Act 4", ["Area"] = "Halls Of The Dead", ["Info"] = "Tawhoa's Test", ["Options"] = { @@ -171,7 +171,7 @@ return { }, { ["Act"] = 4, - ["ActName"] = "Act 4", + ["Description"] = "Act 4", ["Area"] = "Halls Of The Dead", ["Info"] = "Tasalio's Test", ["Options"] = { @@ -183,7 +183,7 @@ return { }, { ["Act"] = 4, - ["ActName"] = "Act 4", + ["Description"] = "Act 4", ["Area"] = "Halls Of The Dead", ["Info"] = "Ngamahu's Test", ["Options"] = { @@ -195,7 +195,7 @@ return { }, { ["Act"] = 4, - ["ActName"] = "Act 4", + ["Description"] = "Act 4", ["Area"] = "Trial Of The Ancestors", ["Info"] = "Hinekora", ["Stat"] = "+2 Weapon Set Passive Skill Points", @@ -205,7 +205,7 @@ return { }, { ["Act"] = 4, - ["ActName"] = "Act 4", + ["Description"] = "Act 4", ["Area"] = "Abandoned Prison", ["Info"] = "Goddess of Justice", ["Options"] = { @@ -217,7 +217,7 @@ return { }, { ["Act"] = 5, - ["ActName"] = "Interlude 1", + ["Description"] = "Interlude 1", ["Area"] = "Wolvenhold", ["Info"] = "Oswin", ["Stat"] = "+2 Weapon Set Passive Skill Points", @@ -227,7 +227,7 @@ return { }, { ["Act"] = 5, - ["ActName"] = "Interlude 2", + ["Description"] = "Interlude 2", ["Area"] = "Khari Bazaar", ["Info"] = "Clearing The Way", ["Stat"] = "+2 Weapon Set Passive Skill Points", @@ -237,7 +237,7 @@ return { }, { ["Act"] = 5, - ["ActName"] = "Interlude 2", + ["Description"] = "Interlude 2", ["Area"] = "Khari Crossing", ["Info"] = "Molten Shrine", ["Stat"] = "5% increased maximum Life", @@ -246,7 +246,7 @@ return { }, { ["Act"] = 5, - ["ActName"] = "Interlude 2", + ["Description"] = "Interlude 2", ["Area"] = "Qimah", ["Info"] = "Seven Pillars", ["Options"] = { @@ -263,7 +263,7 @@ return { }, { ["Act"] = 5, - ["ActName"] = "Interlude 3", + ["Description"] = "Interlude 3", ["Area"] = "Kriar Village", ["Info"] = "Lythara", ["Stat"] = "+40 to Spirit", @@ -272,7 +272,7 @@ return { }, { ["Act"] = 5, - ["ActName"] = "Interlude 3", + ["Description"] = "Interlude 3", ["Area"] = "Howling Caves", ["Info"] = "Abominable Yeti", ["Stat"] = "+2 Weapon Set Passive Skill Points", @@ -282,7 +282,7 @@ return { }, { ["Act"] = 6, - ["ActName"] = "Epilog", + ["Description"] = "Epilog", ["Area"] = "Kingsmarch", ["Info"] = "Siege Of Oriath", ["Stat"] = "+2 Weapon Set Passive Skill Points", diff --git a/src/Modules/ConfigOptions.lua b/src/Modules/ConfigOptions.lua index 818dad8ef0..9602090215 100644 --- a/src/Modules/ConfigOptions.lua +++ b/src/Modules/ConfigOptions.lua @@ -69,9 +69,9 @@ local function addQuestModsRewardsConfigOptions(configSettings) if quest.useConfig == false then goto continue end - local key = "questAct" .. quest.Act .. quest.ActName .. quest.Area .. quest.Info - local label = string.format("%s: %s", quest.ActName, quest.Area) - local source = string.format("Quest:%s: %s", quest.ActName, quest.Area) + local key = "questAct" .. quest.Act .. quest.Description .. quest.Area .. quest.Info + local label = string.format("%s: %s", quest.Description, quest.Area) + local source = string.format("Quest:%s: %s", quest.Description, quest.Area) if quest.Stat then table.insert(configSettings, { var = key, From c9f9ad148b26503b884e4f9bc1968b7c94b3050b Mon Sep 17 00:00:00 2001 From: Nightblade Date: Wed, 10 Sep 2025 20:29:33 +1000 Subject: [PATCH 3/3] improve "key" --- src/Modules/ConfigOptions.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Modules/ConfigOptions.lua b/src/Modules/ConfigOptions.lua index 9602090215..a18aaca390 100644 --- a/src/Modules/ConfigOptions.lua +++ b/src/Modules/ConfigOptions.lua @@ -69,7 +69,7 @@ local function addQuestModsRewardsConfigOptions(configSettings) if quest.useConfig == false then goto continue end - local key = "questAct" .. quest.Act .. quest.Description .. quest.Area .. quest.Info + local key = "quest" .. quest.Description .. quest.Area .. quest.Info local label = string.format("%s: %s", quest.Description, quest.Area) local source = string.format("Quest:%s: %s", quest.Description, quest.Area) if quest.Stat then