From 3b124f49d06f861cc31eddbd57248d6e686b1d67 Mon Sep 17 00:00:00 2001 From: LocalIdentity Date: Sat, 13 Sep 2025 22:32:50 +1000 Subject: [PATCH] Fix minion Gas Arrow skill not showing Poison / Explode damage We were using a old variable name so the check to find which minion stat set was used always failed and used 1 Also added the attack tag to the gas arrow explosion so the damage numbers would show up --- src/Data/Skills/minion.lua | 1 + src/Export/Skills/minion.txt | 2 +- src/Modules/CalcActiveSkill.lua | 6 ++++-- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/Data/Skills/minion.lua b/src/Data/Skills/minion.lua index 4c23ce643..fae08a2bf 100644 --- a/src/Data/Skills/minion.lua +++ b/src/Data/Skills/minion.lua @@ -222,6 +222,7 @@ skills["GasShotSkeletonSniperMinion"] = { incrementalEffectiveness = 0.054999999701977, statDescriptionScope = "sniper_gas_shot_statset_2", baseFlags = { + attack = true, hit = true, area = true, }, diff --git a/src/Export/Skills/minion.txt b/src/Export/Skills/minion.txt index 374b7351c..e740551f2 100644 --- a/src/Export/Skills/minion.txt +++ b/src/Export/Skills/minion.txt @@ -37,7 +37,7 @@ local skills, mod, flag, skill = ... #flags attack area duration #mods #set GasShotCloudExplodeSkeletonSniperMinion -#flags hit area +#flags attack area #mods #skillEnd diff --git a/src/Modules/CalcActiveSkill.lua b/src/Modules/CalcActiveSkill.lua index 56e6e3ccf..c0910eebc 100644 --- a/src/Modules/CalcActiveSkill.lua +++ b/src/Modules/CalcActiveSkill.lua @@ -967,8 +967,10 @@ function calcs.createMinionSkills(env, activeSkill) } local minionSkillIndex = activeSkill.activeEffect.srcInstance.skillMinionSkill local minionSkillIndexCalcs = activeSkill.activeEffect.srcInstance.skillMinionSkillCalcs - local minionStatSetIndex = activeSkill.activeEffect.srcInstance.minionStatSet and activeSkill.activeEffect.srcInstance.minionStatSet[activeSkill.activeEffect.grantedEffect.id][minionSkillIndex] or 1 - local minionStatSetCalcsIndex = activeSkill.activeEffect.srcInstance.minionStatSetCalcs and activeSkill.activeEffect.srcInstance.minionStatSetCalcs[activeSkill.activeEffect.grantedEffect.id][minionSkillIndexCalcs] or 1 + local minionStatSetIndex = activeSkill.activeEffect.srcInstance.skillMinionSkillStatSetIndexLookup and activeSkill.activeEffect.srcInstance.skillMinionSkillStatSetIndexLookup[activeSkill.activeEffect.grantedEffect.id] + and activeSkill.activeEffect.srcInstance.skillMinionSkillStatSetIndexLookup[activeSkill.activeEffect.grantedEffect.id][minionSkillIndex] or 1 + local minionStatSetCalcsIndex = activeSkill.activeEffect.srcInstance.skillMinionSkillStatSetIndexLookupCalcs and activeSkill.activeEffect.srcInstance.skillMinionSkillStatSetIndexLookupCalcs[activeSkill.activeEffect.grantedEffect.id] + and activeSkill.activeEffect.srcInstance.skillMinionSkillStatSetIndexLookupCalcs[activeSkill.activeEffect.grantedEffect.id][minionSkillIndexCalcs] or 1 activeEffect.statSet = { index = minionStatSetIndex, }