Skip to content

Commit 08bbeb2

Browse files
LocalIdentityLocalIdentity
LocalIdentity
and
LocalIdentity
authored
Add Gem tooltip for Legacy Gems (#9622)
Adds a tooltip to legacy gems so players know when hovering over them Adding `(legacy) to the end of the gem names caused a bunch of issues so dropped it We now manually tag legacy gems instead of relying on a exclusion filter for awakened variants Co-authored-by: LocalIdentity <localidentity2@gmail.com>
1 parent 9bea5a3 commit 08bbeb2

7 files changed

Lines changed: 79 additions & 7 deletions

File tree

‎src/Classes/GemSelectControl.lua‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,6 @@ local m_max = math.max
1212
local m_floor = math.floor
1313

1414
local toolTipText = "Prefix tag searches with a colon and exclude tags with a dash. e.g. :fire:lightning:-cold:area"
15-
local nonLegacyAwakened = {
16-
["SupportAwakenedEmpower"] = true,
17-
["SupportAwakenedEnlighten"] = true,
18-
["SupportAwakenedEnhance"] = true,
19-
}
2015
local altQualMap = {
2116
["Default"] = "",
2217
["Alternate1"] = "Anomalous ",
@@ -121,7 +116,7 @@ function GemSelectClass:PopulateGemList()
121116
local levelRequirement = gemData.grantedEffect.levels[1].levelRequirement or 1
122117
if characterLevel >= levelRequirement or not matchLevel then
123118
if (showExceptional or showAll) and gemData.grantedEffect.plusVersionOf then
124-
if self.skillsTab.showLegacyGems or nonLegacyAwakened[gemData.grantedEffectId] or not gemData.name:match("^Awakened") then
119+
if self.skillsTab.showLegacyGems or not gemData.grantedEffect.legacy then
125120
self.gems["Default:" .. gemId] = gemData
126121
end
127122
elseif showNormal or showAll then
@@ -144,7 +139,7 @@ end
144139

145140
function GemSelectClass:FilterSupport(gemId, gemData)
146141
local showSupportTypes = self.skillsTab.showSupportGemTypes
147-
if gemData.name:match("^Awakened") and not self.skillsTab.showLegacyGems and not nonLegacyAwakened[gemData.grantedEffectId] then
142+
if gemData.grantedEffect.legacy and not self.skillsTab.showLegacyGems then
148143
return false
149144
end
150145
return (not gemData.grantedEffect.support
@@ -615,6 +610,11 @@ function GemSelectClass:AddGemTooltip(gemInstance)
615610
local grantedEffect = gemInstance.gemData.grantedEffect
616611
self.tooltip:AddLine(fontSizeTitle, colorCodes.GEM .. altQualMap[gemInstance.qualityId]..grantedEffect.name, "FONTIN SC")
617612
self.tooltip:AddSeparator(10)
613+
if grantedEffect.legacy then
614+
self.tooltip:AddLine(fontSizeTitle, colorCodes.WARNING .. "Legacy Gem", "FONTIN SC")
615+
self.tooltip:AddLine(fontSizeBig, colorCodes.WARNING .. "Gem only exists in Standard League", "FONTIN SC")
616+
self.tooltip:AddSeparator(10)
617+
end
618618
self.tooltip:AddLine(fontSizeBig, "^x7F7F7F" .. gemInstance.gemData.tagString, "FONTIN SC")
619619
self:AddCommonGemInfo(gemInstance, grantedEffect, true, secondary and secondary.support and secondary)
620620
end

‎src/Data/Skills/sup_dex.lua‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ skills["SupportAwakenedAddedColdDamage"] = {
8181
excludeSkillTypes = { },
8282
plusVersionOf = "SupportAddedColdDamage",
8383
statDescriptionScope = "gem_stat_descriptions",
84+
legacy = true,
8485
qualityStats = {
8586
Default = {
8687
{ "cold_damage_+%", 0.5 },
@@ -267,6 +268,7 @@ skills["SupportAwakenedArrowNova"] = {
267268
["Bow"] = true,
268269
},
269270
statDescriptionScope = "gem_stat_descriptions",
271+
legacy = true,
270272
statMap = {
271273
["support_rain_projectile_damage_+%_final"] = {
272274
mod("Damage", "MORE", nil, ModFlag.Projectile),
@@ -679,6 +681,7 @@ skills["SupportAwakenedCastOnCriticalStrike"] = {
679681
ignoreMinionTypes = true,
680682
plusVersionOf = "SupportCastOnCriticalStrike",
681683
statDescriptionScope = "gem_stat_descriptions",
684+
legacy = true,
682685
statMap = {
683686
["support_cast_on_crit_spell_damage_+%_final"] = {
684687
},
@@ -975,6 +978,7 @@ skills["SupportAwakenedChain"] = {
975978
excludeSkillTypes = { },
976979
plusVersionOf = "SupportChain",
977980
statDescriptionScope = "gem_stat_descriptions",
981+
legacy = true,
978982
statMap = {
979983
["support_chain_hit_damage_+%_final"] = {
980984
mod("Damage", "MORE", nil, ModFlag.Hit),
@@ -1417,6 +1421,7 @@ skills["SupportAwakenedColdPenetration"] = {
14171421
excludeSkillTypes = { },
14181422
plusVersionOf = "SupportColdPenetration",
14191423
statDescriptionScope = "gem_stat_descriptions",
1424+
legacy = true,
14201425
qualityStats = {
14211426
Default = {
14221427
{ "cold_damage_+%", 0.5 },
@@ -1725,6 +1730,7 @@ skills["SupportAwakenedDeadlyAilments"] = {
17251730
excludeSkillTypes = { },
17261731
plusVersionOf = "SupportDeadlyAilments",
17271732
statDescriptionScope = "gem_stat_descriptions",
1733+
legacy = true,
17281734
statMap = {
17291735
["support_better_ailments_hit_damage_+%_final"] = {
17301736
mod("Damage", "MORE", nil, ModFlag.Hit),
@@ -2118,6 +2124,7 @@ skills["SupportAwakenedFork"] = {
21182124
excludeSkillTypes = { },
21192125
plusVersionOf = "SupportFork",
21202126
statDescriptionScope = "gem_stat_descriptions",
2127+
legacy = true,
21212128
statMap = {
21222129
["support_fork_projectile_damage_+%_final"] = {
21232130
mod("Damage", "MORE", nil, ModFlag.Projectile),
@@ -2281,6 +2288,7 @@ skills["SupportAwakenedGreaterMultipleProjectiles"] = {
22812288
excludeSkillTypes = { SkillType.ProjectilesNumberModifiersNotApplied, },
22822289
plusVersionOf = "SupportGreaterMultipleProjectiles",
22832290
statDescriptionScope = "gem_stat_descriptions",
2291+
legacy = true,
22842292
statMap = {
22852293
["support_multiple_projectile_damage_+%_final"] = {
22862294
mod("Damage", "MORE", nil, ModFlag.Projectile),
@@ -4079,6 +4087,7 @@ skills["SupportAwakenedSwiftAffliction"] = {
40794087
excludeSkillTypes = { },
40804088
plusVersionOf = "SupportSwiftAffliction",
40814089
statDescriptionScope = "gem_stat_descriptions",
4090+
legacy = true,
40824091
statMap = {
40834092
["support_rapid_decay_damage_over_time_+%_final"] = {
40844093
mod("Damage", "MORE", nil, ModFlag.Dot),
@@ -4549,6 +4558,7 @@ skills["SupportAwakenedViciousProjectiles"] = {
45494558
excludeSkillTypes = { },
45504559
plusVersionOf = "SupportViciousProjectiles",
45514560
statDescriptionScope = "gem_stat_descriptions",
4561+
legacy = true,
45524562
statMap = {
45534563
["support_projectile_attack_speed_+%_final"] = {
45544564
mod("Speed", "MORE", nil, bit.bor(ModFlag.Attack, ModFlag.Projectile)),
@@ -4750,6 +4760,7 @@ skills["SupportAwakenedVoidManipulation"] = {
47504760
excludeSkillTypes = { },
47514761
plusVersionOf = "SupportVoidManipulation",
47524762
statDescriptionScope = "gem_stat_descriptions",
4763+
legacy = true,
47534764
statMap = {
47544765
["support_void_manipulation_chaos_damage_+%_final"] = {
47554766
mod("ChaosDamage", "MORE", nil),

‎src/Data/Skills/sup_int.lua‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ skills["SupportAwakenedAddedChaosDamage"] = {
8181
excludeSkillTypes = { },
8282
plusVersionOf = "SupportAddedChaosDamage",
8383
statDescriptionScope = "gem_stat_descriptions",
84+
legacy = true,
8485
qualityStats = {
8586
Default = {
8687
{ "chaos_damage_+%", 0.5 },
@@ -189,6 +190,7 @@ skills["SupportAwakenedAddedLightningDamage"] = {
189190
excludeSkillTypes = { },
190191
plusVersionOf = "SupportAddedLightningDamage",
191192
statDescriptionScope = "gem_stat_descriptions",
193+
legacy = true,
192194
qualityStats = {
193195
Default = {
194196
{ "lightning_damage_+%", 0.5 },
@@ -456,6 +458,7 @@ skills["SupportAwakenedBlasphemy"] = {
456458
ignoreMinionTypes = true,
457459
plusVersionOf = "SupportBlasphemy",
458460
statDescriptionScope = "gem_stat_descriptions",
461+
legacy = true,
459462
statMap = {
460463
["curse_apply_as_aura"] = {
461464
},
@@ -845,6 +848,7 @@ skills["SupportAwakenedCastWhileChannelling"] = {
845848
excludeSkillTypes = { SkillType.SummonsTotem, SkillType.DisallowTriggerSupports, },
846849
plusVersionOf = "SupportCastWhileChannelling",
847850
statDescriptionScope = "gem_stat_descriptions",
851+
legacy = true,
848852
statMap = {
849853
["cast_while_channelling_time_ms"] = {
850854
skill("triggerTime", nil, { type = "SkillType", skillType = SkillType.Channel } ),
@@ -1270,6 +1274,7 @@ skills["SupportAwakenedControlledDestruction"] = {
12701274
excludeSkillTypes = { },
12711275
plusVersionOf = "SupportControlledDestruction",
12721276
statDescriptionScope = "gem_stat_descriptions",
1277+
legacy = true,
12731278
statMap = {
12741279
["support_controlled_destruction_spell_damage_+%_final"] = {
12751280
mod("Damage", "MORE", nil, ModFlag.Spell),
@@ -1577,6 +1582,7 @@ skills["SupportAwakenedHextouch"] = {
15771582
ignoreMinionTypes = true,
15781583
plusVersionOf = "SupportHextouch",
15791584
statDescriptionScope = "gem_stat_descriptions",
1585+
legacy = true,
15801586
statMap = {
15811587
["apply_linked_curses_on_hit_%"] = {
15821588
--Display only. Handled by SupportCurseOnHitCursePlus
@@ -2137,6 +2143,7 @@ skills["SupportAwakenedElementalFocus"] = {
21372143
excludeSkillTypes = { },
21382144
plusVersionOf = "SupportElementalFocus",
21392145
statDescriptionScope = "gem_stat_descriptions",
2146+
legacy = true,
21402147
statMap = {
21412148
["support_gem_elemental_damage_+%_final"] = {
21422149
mod("ElementalDamage", "MORE", nil),
@@ -3712,6 +3719,7 @@ skills["SupportAwakenedIncreasedAreaofEffect"] = {
37123719
excludeSkillTypes = { },
37133720
plusVersionOf = "SupportIncreasedAreaOfEffect",
37143721
statDescriptionScope = "gem_stat_descriptions",
3722+
legacy = true,
37153723
statMap = {
37163724
["inc_aoe_plus_more_area_damage_+%_final"] = {
37173725
mod("Damage", "MORE", nil, ModFlag.Area),
@@ -4713,6 +4721,7 @@ skills["SupportAwakenedLightningPenetration"] = {
47134721
excludeSkillTypes = { },
47144722
plusVersionOf = "SupportLightningPenetration",
47154723
statDescriptionScope = "gem_stat_descriptions",
4724+
legacy = true,
47164725
qualityStats = {
47174726
Default = {
47184727
{ "lightning_damage_+%", 0.5 },
@@ -4971,6 +4980,7 @@ skills["SupportAwakenedMinionDamage"] = {
49714980
excludeSkillTypes = { },
49724981
plusVersionOf = "SupportMinionDamage",
49734982
statDescriptionScope = "gem_stat_descriptions",
4983+
legacy = true,
49744984
statMap = {
49754985
["support_minion_damage_+%_final"] = {
49764986
mod("MinionModifier", "LIST", { mod = mod("Damage", "MORE", nil) }),
@@ -6278,6 +6288,7 @@ skills["SupportAwakenedSpellCascade"] = {
62786288
ignoreMinionTypes = true,
62796289
plusVersionOf = "SupportSpellCascade",
62806290
statDescriptionScope = "gem_stat_descriptions",
6291+
legacy = true,
62816292
statMap = {
62826293
["support_spell_cascade_area_of_effect_+%_final"] = {
62836294
mod("AreaOfEffect", "MORE", nil),
@@ -6515,6 +6526,7 @@ skills["SupportAwakenedSpellEcho"] = {
65156526
excludeSkillTypes = { SkillType.SummonsTotem, SkillType.Trapped, SkillType.RemoteMined, SkillType.Triggered, SkillType.HasReservation, SkillType.Vaal, SkillType.Instant, SkillType.NonRepeatable, SkillType.CreatesMinion, SkillType.NOT, SkillType.AND, },
65166527
plusVersionOf = "SupportSpellEcho",
65176528
statDescriptionScope = "gem_stat_descriptions",
6529+
legacy = true,
65186530
statMap = {
65196531
["support_echo_damage_+%_final"] = {
65206532
mod("Damage", "MORE", nil),
@@ -6873,6 +6885,7 @@ skills["SupportAwakenedUnboundAilments"] = {
68736885
excludeSkillTypes = { },
68746886
plusVersionOf = "SupportUnboundAilments",
68756887
statDescriptionScope = "gem_stat_descriptions",
6888+
legacy = true,
68766889
statMap = {
68776890
["support_unbound_ailments_ailment_damage_+%_final"] = {
68786891
mod("Damage", "MORE", nil, 0, bit.bor(KeywordFlag.Bleed, KeywordFlag.Poison, KeywordFlag.Ignite)),
@@ -7003,6 +7016,7 @@ skills["SupportAwakenedUnleash"] = {
70037016
excludeSkillTypes = { SkillType.SummonsTotem, SkillType.Trapped, SkillType.RemoteMined, SkillType.Triggered, SkillType.HasReservation, SkillType.Vaal, SkillType.Instant, SkillType.Channel, SkillType.Cooldown, },
70047017
plusVersionOf = "SupportUnleash",
70057018
statDescriptionScope = "gem_stat_descriptions",
7019+
legacy = true,
70067020
statMap = {
70077021
["support_anticipation_rapid_fire_count"] = {
70087022
mod("SealCount", "BASE", nil),

‎src/Data/Skills/sup_str.lua‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ skills["SupportAwakenedAddedFireDamage"] = {
7777
excludeSkillTypes = { },
7878
plusVersionOf = "SupportAddedFireDamage",
7979
statDescriptionScope = "gem_stat_descriptions",
80+
legacy = true,
8081
qualityStats = {
8182
Default = {
8283
{ "fire_damage_+%", 0.5 },
@@ -232,6 +233,7 @@ skills["SupportAwakenedAncestralCall"] = {
232233
ignoreMinionTypes = true,
233234
plusVersionOf = "SupportAncestralCall",
234235
statDescriptionScope = "gem_stat_descriptions",
236+
legacy = true,
235237
statMap = {
236238
["support_spirit_strike_damage_+%_final"] = {
237239
mod("Damage", "MORE", nil),
@@ -885,6 +887,7 @@ skills["SupportAwakenedBrutality"] = {
885887
excludeSkillTypes = { },
886888
plusVersionOf = "SupportBrutality",
887889
statDescriptionScope = "gem_stat_descriptions",
890+
legacy = true,
888891
statMap = {
889892
["support_brutality_physical_damage_+%_final"] = {
890893
mod("PhysicalDamage", "MORE", nil),
@@ -999,6 +1002,7 @@ skills["SupportAwakenedBurningDamage"] = {
9991002
excludeSkillTypes = { },
10001003
plusVersionOf = "SupportBurningDamage",
10011004
statDescriptionScope = "gem_stat_descriptions",
1005+
legacy = true,
10021006
statMap = {
10031007
["support_burning_damage_+%_final"] = {
10041008
mod("FireDamage", "MORE", nil, 0, KeywordFlag.FireDot),
@@ -1824,6 +1828,7 @@ skills["SupportAwakenedElementalDamageWithAttacks"] = {
18241828
excludeSkillTypes = { },
18251829
plusVersionOf = "SupportElementalDamageWithAttacks",
18261830
statDescriptionScope = "gem_stat_descriptions",
1831+
legacy = true,
18271832
statMap = {
18281833
["support_attack_skills_elemental_damage_+%_final"] = {
18291834
mod("ElementalDamage", "MORE", nil, 0, KeywordFlag.Attack),
@@ -2216,6 +2221,7 @@ skills["SupportAwakenedFirePenetration"] = {
22162221
excludeSkillTypes = { },
22172222
plusVersionOf = "SupportFirePenetration",
22182223
statDescriptionScope = "gem_stat_descriptions",
2224+
legacy = true,
22192225
qualityStats = {
22202226
Default = {
22212227
{ "fire_damage_+%", 0.5 },
@@ -2731,6 +2737,7 @@ skills["SupportAwakenedGenerosity"] = {
27312737
ignoreMinionTypes = true,
27322738
plusVersionOf = "SupportGenerosity",
27332739
statDescriptionScope = "gem_stat_descriptions",
2740+
legacy = true,
27342741
statMap = {
27352742
["aura_cannot_affect_self"] = {
27362743
skill("auraCannotAffectSelf", true),
@@ -3175,6 +3182,7 @@ skills["SupportItemQuantity"] = {
31753182
addSkillTypes = { },
31763183
excludeSkillTypes = { },
31773184
statDescriptionScope = "gem_stat_descriptions",
3185+
legacy = true,
31783186
qualityStats = {
31793187
Default = {
31803188
{ "base_killed_monster_dropped_item_quantity_+%", 0.35 },
@@ -3714,6 +3722,7 @@ skills["SupportAwakenedMeleePhysicalDamage"] = {
37143722
excludeSkillTypes = { },
37153723
plusVersionOf = "SupportMeleePhysicalDamage",
37163724
statDescriptionScope = "gem_stat_descriptions",
3725+
legacy = true,
37173726
statMap = {
37183727
["support_melee_physical_damage_+%_final"] = {
37193728
mod("PhysicalDamage", "MORE", nil, ModFlag.Melee),
@@ -3836,6 +3845,7 @@ skills["SupportAwakenedMeleeSplash"] = {
38363845
excludeSkillTypes = { },
38373846
plusVersionOf = "SupportMeleeSplash",
38383847
statDescriptionScope = "gem_stat_descriptions",
3848+
legacy = true,
38393849
qualityStats = {
38403850
Default = {
38413851
{ "base_skill_area_of_effect_+%", 0.5 },
@@ -4034,6 +4044,7 @@ skills["SupportAwakenedMultistrike"] = {
40344044
excludeSkillTypes = { SkillType.Vaal, SkillType.NonRepeatable, SkillType.CreatesMinion, SkillType.NOT, SkillType.AND, },
40354045
plusVersionOf = "SupportMultistrike",
40364046
statDescriptionScope = "gem_stat_descriptions",
4047+
legacy = true,
40374048
statMap = {
40384049
["multistrike_damage_+%_final_on_first_repeat"] = {
40394050
mod("RepeatOneDamage", "MORE", nil, nil, nil, { type = "ModFlagOr", modFlags = bit.bor(ModFlag.WeaponMelee, ModFlag.Unarmed) }, { type = "Condition", varList = {"averageRepeat", "alwaysFinalRepeat"} }),

0 commit comments

Comments
 (0)