Skip to content

Commit d3151b4

Browse files
LocalIdentityLocalIdentity
andauthored
Fix Replica Dragonfang's Flight not working with Lightning Tendrils (#9652)
Replica Dragonfang's Flight wasn't working with Lightning Tendrils as the transfigured gem matching code was matching to another version of the gem that existed in the game files Changed the exporter so it now only exports the current version of the gem so the transfigured gem matching logic now works Co-authored-by: LocalIdentity <localidentity2@gmail.com>
1 parent 3edc00a commit d3151b4

2 files changed

Lines changed: 1 addition & 61 deletions

File tree

src/Data/Gems.lua

Lines changed: 0 additions & 61 deletions
Original file line numberDiff line numberDiff line change
@@ -2057,27 +2057,6 @@ return {
20572057
reqInt = 0,
20582058
naturalMaxLevel = 20,
20592059
},
2060-
["Metadata/Items/Gems/SkillGemPhaseRun"] = {
2061-
name = "Phase Run",
2062-
baseTypeName = "Phase Run",
2063-
gameId = "Metadata/Items/Gems/SkillGemPhaseRun",
2064-
variantId = "PhaseRun",
2065-
grantedEffectId = "PhaseRun",
2066-
tags = {
2067-
dexterity = true,
2068-
grants_active_skill = true,
2069-
spell = true,
2070-
duration = true,
2071-
movement = true,
2072-
physical = true,
2073-
travel = true,
2074-
},
2075-
tagString = "Spell, Duration, Movement, Physical, Travel",
2076-
reqStr = 0,
2077-
reqDex = 100,
2078-
reqInt = 0,
2079-
naturalMaxLevel = 20,
2080-
},
20812060
["Metadata/Items/Gems/SkillGemSupportMeleePhysicalDamage"] = {
20822061
name = "Melee Physical Damage",
20832062
gameId = "Metadata/Items/Gems/SupportGemMeleePhysicalDamage",
@@ -4174,25 +4153,6 @@ return {
41744153
reqInt = 40,
41754154
naturalMaxLevel = 20,
41764155
},
4177-
["Metadata/Items/Gems/SkillGemArcticArmour"] = {
4178-
name = "Arctic Armour",
4179-
baseTypeName = "Arctic Armour",
4180-
gameId = "Metadata/Items/Gems/SkillGemArcticArmour",
4181-
variantId = "ArcticArmour",
4182-
grantedEffectId = "ArcticArmour",
4183-
tags = {
4184-
dexterity = true,
4185-
grants_active_skill = true,
4186-
spell = true,
4187-
duration = true,
4188-
cold = true,
4189-
},
4190-
tagString = "Spell, Duration, Cold",
4191-
reqStr = 0,
4192-
reqDex = 60,
4193-
reqInt = 40,
4194-
naturalMaxLevel = 20,
4195-
},
41964156
["Metadata/Items/Gems/SkillGemVaalArcticArmour"] = {
41974157
name = "Vaal Arctic Armour",
41984158
baseTypeName = "Vaal Arctic Armour",
@@ -6327,27 +6287,6 @@ return {
63276287
reqInt = 100,
63286288
naturalMaxLevel = 20,
63296289
},
6330-
["Metadata/Items/Gems/SkillGemLightningTendrils"] = {
6331-
name = "Lightning Tendrils",
6332-
baseTypeName = "Lightning Tendrils",
6333-
gameId = "Metadata/Items/Gems/SkillGemLightningTendrilsChannelled",
6334-
variantId = "LightningTendrils",
6335-
grantedEffectId = "LightningTendrils",
6336-
tags = {
6337-
critical = true,
6338-
intelligence = true,
6339-
grants_active_skill = true,
6340-
spell = true,
6341-
area = true,
6342-
lightning = true,
6343-
channelling = true,
6344-
},
6345-
tagString = "Critical, Spell, AoE, Lightning, Channelling",
6346-
reqStr = 0,
6347-
reqDex = 0,
6348-
reqInt = 100,
6349-
naturalMaxLevel = 1,
6350-
},
63516290
["Metadata/Items/Gems/SkillGemKineticBlast"] = {
63526291
name = "Kinetic Blast",
63536292
baseTypeName = "Kinetic Blast",

src/Export/Scripts/skills.lua

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -534,6 +534,7 @@ out:write('-- Gem data (c) Grinding Gear Games\n\nreturn {\n')
534534
for skillGem in dat("SkillGems"):Rows() do
535535
for _, gemEffect in ipairs(skillGem.GemVariants) do
536536
if gems[gemEffect.Id] then
537+
gems[gemEffect.Id] = nil -- Some skills have an additional old version that exists in the game files and messes up transfigured gem matching
537538
out:write('\t["', "Metadata/Items/Gems/SkillGem" .. gemEffect.Id, '"] = {\n')
538539
out:write('\t\tname = "', fullNameGems[skillGem.BaseItemType.Id] and skillGem.BaseItemType.Name or trueGemNames[gemEffect.Id] or skillGem.BaseItemType.Name:gsub(" Support",""), '",\n')
539540
-- Hybrid gems (e.g. Vaal gems) use the display name of the active skill e.g. Vaal Summon Skeletons of Sorcery

0 commit comments

Comments
 (0)