test(trade): cover stale result dropdown tooltip guards

Author: mcagnion

spec/System/TestTradeQueryCurrency_spec.lua

@@ -62,4 +62,5 @@ describe("TradeQuery Currency Conversion", function()
             assert.are.equal(result, "5 chaos, 10 div")
         end)
     end)
+
 end)

spec/System/TestTradeQuery_spec.lua

@@ -0,0 +1,87 @@
+describe("TradeQuery", function()
+    local mock_tradeQuery = new("TradeQuery", { itemsTab = {} })
+
+    local function makeTooltip()
+        return new("Tooltip")
+    end
+
+    local function makeTradeResult(overrides)
+        local result = {
+            index = 1,
+            currency = "chaos",
+            amount = 5,
+            item_string = "Rarity: RARE\nBehemoth Hold\nGold Ring",
+        }
+        for key, value in pairs(overrides or {}) do
+            result[key] = value
+        end
+        return result
+    end
+
+    local function makeResultState(result)
+        result = result or makeTradeResult()
+        return {
+            resultTbl = {
+                [1] = {
+                    [result.index] = {
+                        currency = result.currency,
+                        amount = result.amount,
+                        item_string = result.item_string,
+                    }
+                }
+            },
+            sortedResultTbl = {
+                [1] = {
+                    { index = result.index }
+                }
+            }
+        }
+    end
+
+    local function makeTraderTooltipFixture(opts)
+        opts = opts or {}
+        mock_tradeQuery.itemsTab = {
+            activeItemSet = {},
+            sockets = {},
+            slots = {},
+            AddItemTooltip = function() end,
+            build = { AddStatComparesToTooltip = function() end },
+        }
+        mock_tradeQuery.controls = { fullPrice = {}, pbNotice = {} }
+        mock_tradeQuery.totalPrice = {}
+        mock_tradeQuery.itemIndexTbl = {}
+        mock_tradeQuery.onlyWeightedBaseOutput = {}
+        mock_tradeQuery.resultTbl = opts.resultTbl or {}
+        mock_tradeQuery.sortedResultTbl = opts.sortedResultTbl or {}
+        mock_tradeQuery.slotTables = { [1] = { slotName = "Ring 1" } }
+
+        mock_tradeQuery:PriceItemRowDisplay(1, nil, 0, 20)
+        return {
+            tooltip = makeTooltip(),
+            dropdown = mock_tradeQuery.controls.resultDropdown1,
+            tradeQuery = mock_tradeQuery,
+        }
+    end
+
+    describe("result dropdown tooltip", function()
+        it("returns early when the sorted row is stale", function()
+            local fx = makeTraderTooltipFixture()
+            fx.tradeQuery.sortedResultTbl[1] = nil
+            local ok, err = pcall(function()
+                fx.dropdown.tooltipFunc(fx.tooltip, "DROP", 1, nil)
+            end)
+            assert.is_true(ok, tostring(err))
+            assert.are.equal(0, #fx.tooltip.lines)
+        end)
+
+        it("returns early when the selected result entry is gone", function()
+            local fx = makeTraderTooltipFixture(makeResultState())
+            fx.tradeQuery.resultTbl[1] = {}
+            local ok, err = pcall(function()
+                fx.dropdown.tooltipFunc(fx.tooltip, "DROP", 1, fx.dropdown.list[1])
+            end)
+            assert.is_true(ok, tostring(err))
+            assert.are.equal(0, #fx.tooltip.lines)
+        end)
+    end)
+end)