From 2ea83fab7d4d0f234bb721e20d1ca0c1ef6ed7ee Mon Sep 17 00:00:00 2001 From: LocalIdentity Date: Thu, 12 Mar 2026 09:53:40 +1100 Subject: [PATCH] Add Holy Strike FullDPS override to not overstate melee damage Just like with Dominating Blow, Holy Strike is a hybrid melee / minion skill when scaling the full DPS on the skill would inflate the players DPS by the number of minions you were trying to represent --- src/Modules/Calcs.lua | 3 ++- src/Modules/ConfigOptions.lua | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/Modules/Calcs.lua b/src/Modules/Calcs.lua index b70df76782..daaf130572 100644 --- a/src/Modules/Calcs.lua +++ b/src/Modules/Calcs.lua @@ -238,7 +238,8 @@ function calcs.calcFullDPS(build, mode, override, specEnv) end -- This is a fix to prevent skills such as Absolution or Dominating Blow from being counted multiple times when increasing minions count if (activeSkill.activeEffect.grantedEffect.name:match("Absolution") and fullEnv.modDB:Flag(false, "Condition:AbsolutionSkillDamageCountedOnce")) - or (activeSkill.activeEffect.grantedEffect.name:match("Dominating Blow") and fullEnv.modDB:Flag(false, "Condition:DominatingBlowSkillDamageCountedOnce")) then + or (activeSkill.activeEffect.grantedEffect.name:match("Dominating Blow") and fullEnv.modDB:Flag(false, "Condition:DominatingBlowSkillDamageCountedOnce")) + or (activeSkill.activeEffect.grantedEffect.name:match("Holy Strike") and fullEnv.modDB:Flag(false, "Condition:HolyStrikeSkillDamageCountedOnce"))then activeSkillCount = 1 activeSkill.infoMessage2 = "Skill Damage" end diff --git a/src/Modules/ConfigOptions.lua b/src/Modules/ConfigOptions.lua index 9980437a83..1ad17dbbf4 100644 --- a/src/Modules/ConfigOptions.lua +++ b/src/Modules/ConfigOptions.lua @@ -741,6 +741,9 @@ return { { var = "dominatingBlowSkillDamageCountedOnce", type = "check", label = "Dom. Blow: Count skill damage once", ifSkill = "Dominating Blow", includeTransfigured = true, tooltip = "Your Dominating Blow Skill Damage will not be scaled with Count setting.\nBy default it multiplies both minion count and skill hit count which leads to incorrect\nTotal DPS calculation since Dominating Blow cannot inherently shotgun.\nDo not enable if you use Spell Totem support, Spell Cascade support or similar supports", apply = function(val, modList, enemyModList) modList:NewMod("Condition:DominatingBlowSkillDamageCountedOnce", "FLAG", true, "Config", { type = "Condition", var = "Combat" }) end }, + { var = "holyStrikeSkillDamageCountedOnce", type = "check", label = "Holy Strike: Count skill damage once", ifSkill = "Holy Strike", includeTransfigured = true, tooltip = "Your Holy Strike Skill Damage will not be scaled with Count setting.\nBy default it multiplies both minion count and skill hit count which leads to incorrect\nTotal DPS calculation since Holy Strike cannot inherently shotgun.", apply = function(val, modList, enemyModList) + modList:NewMod("Condition:HolyStrikeSkillDamageCountedOnce", "FLAG", true, "Config", { type = "Condition", var = "Combat" }) + end }, { label = "Molten Shell:", ifSkill = "Molten Shell" }, { var = "MoltenShellDamageMitigated", type = "count", label = "Damage mitigated:", tooltip = "Molten Shell reflects damage to the enemy,\nbased on the amount of damage it has mitigated.", ifSkill = "Molten Shell", apply = function(val, modList, enemyModList) modList:NewMod("SkillData", "LIST", { key = "MoltenShellDamageMitigated", value = val }, "Config", { type = "SkillName", skillName = "Molten Shell" })