File type question by srobotta · Pull Request #681 · PoetOS/moodle-mod_questionnaire

srobotta · 2025-11-17T16:00:44Z

Hi Mike,

this is the next attempt to open a pull request for the file type response. This will replace PR #599 (which I can try to close after creating this one).
The original work was done by Laurent David. He introduced this question/response type and also created PR #471. Luca Bösch added some tests. I completed the work.

There is code for backup and restore (as requested from you the last time).
I rebased it on the MOODLE_500_STABLE branch.

This PR also contains two changes unrelated to that feature but that are fixing two issues we had in the past and that are missing in the current MOODLE_500_STABLE branch.

Best regards, Stephan

mchurchward · 2025-11-17T18:24:28Z

Thanks. I will review. In the meantime, can you fix the CI errors please?

srobotta · 2025-11-17T21:02:55Z

CI errors should be fixed by now.

mchurchward · 2025-11-20T18:39:40Z

Can you do a rebase with the current MOODLE_500_STABLE branch please? There are commits here that shouldn't be.

srobotta · 2025-11-20T20:17:39Z

It is already rebased on your MOODLE_500_STABLE branch. When I tried a fetch and rebase now, it claimed to be up to date already.

mchurchward · 2025-11-20T20:37:23Z

Hmmm... Okay. Looks like this commit was missing from the 500 branch. I'll keep it.
But this commit doesn't seem to need to be there. Why is it there?

I will leave some comments in the code review as well.

mchurchward

Well I appreciate the changes made that are not part of this actual issue, it is really necessary to limit the changes to the specific issue. If there are CI issues that are not caused by your code, they should be fixed separately. Can you simplify this PR? Possibly make a new one limited to the only the code needed for this question type?

mchurchward

Testing functionality.
I added a file type question. I set the questionnaire so that I could save and resume. I added a file to the file question and saved my response. When I resumed, there was no file attached. I think that needs to be saved too.

srobotta · 2025-11-21T07:40:32Z

Thanks for looking at it, I will see that I implement the changes within the next days. I inform you as soon as I am done.

Fix upload when several file upload questions are used. - Adjust siganture of methods to their parent - Limit the files to upload to one for each question - Use questionaire id for file draft area instead of question id in the questionaire. Fix handling of file uploads - allow upload of one file only. - new submit does not load previously existing files. Change refence of file.itemid to questionnaire_response_file.id update existing files.itemid to questionnaire_response_file.id

Improvements to satisfy code checker. Make the file upload work with required setting, fix delete of records Add file question type

Fix cleanup of old file responses. Add backup/restore handling for file response type.

srobotta · 2025-11-28T18:28:08Z

Hi Mike,

I just finished working on it and it works from my point of few now. Could you please have another check? Also, now in this diff I can explain all the changes. There should be no left overs from other stuff.

Thank you, Stephan

mchurchward · 2025-12-02T14:38:24Z

Thanks for all your work on this. I will strive to review this soon.

mchurchward

One last change. The current MOODLE_500_STABLE uses version 2025041400.01. Can you change the version file in the PR to use 2025041400.02, and then update your upgrade.php file as well? Then I can merge.

mchurchward

I just tested the backup and restore with file type questions and I don't think its working yet. The restore didn't seem to restore the uploaded files into the results.
Test steps:

Install questionnaire with file question type.
Add a questionnaire with a couple of questions including file type.
Respond from a couple of users, uploading different files.
Backup the course with just the questionnaire and all responses.
Download the backup file and keep.
Uninstall questionnaire - this hopefully ensures that the uploaded files are removed.
Reinstall questionnaire.
Restore the saved questionnaire backup into the same course as before.
Look a the restored responses. The file questions should have files. In my test, they were missing.

srobotta · 2026-01-12T12:10:58Z

Thanks for the comment. Indeed, I see that in a fresh instance the images are not imported, or at least not visible in the responses. I'll fix that.

srobotta · 2026-01-13T16:38:51Z

Hi Mike, the restore works now. I also updated the version as requested.

mchurchward · 2026-01-16T15:36:47Z

Thanks for the fixes and all of the work you have put into this. It will be a great addition.

* Circumvent number on string error, resolves #538. (#563) * Add file question type Fix upload when several file upload questions are used. - Adjust siganture of methods to their parent - Limit the files to upload to one for each question - Use questionaire id for file draft area instead of question id in the questionaire. Fix handling of file uploads - allow upload of one file only. - new submit does not load previously existing files. Change refence of file.itemid to questionnaire_response_file.id update existing files.itemid to questionnaire_response_file.id Improvements to satisfy code checker. Make the file upload work with required setting, fix delete of records * Make sid public, because its already used via #[\AllowDynamicProperties] Fix cleanup of old file responses. Add backup/restore handling for file response type. * Fix restore of files in backup. --------- Co-authored-by: Luca Bösch <luca.boesch@bfh.ch> Co-authored-by: Laurent David <lmedavid@gmail.com>

djarran · 2026-01-29T05:37:13Z

Hi @mchurchward, it's great to have this feature merged. Would there be any issue if we backport this to the MOODLE_404_STABLE branch? Thanks

mchurchward · 2026-01-29T16:03:51Z

You can do that for yours, sure.

* Circumvent number on string error, resolves PoetOS#538. (PoetOS#563) * Add file question type Fix upload when several file upload questions are used. - Adjust siganture of methods to their parent - Limit the files to upload to one for each question - Use questionaire id for file draft area instead of question id in the questionaire. Fix handling of file uploads - allow upload of one file only. - new submit does not load previously existing files. Change refence of file.itemid to questionnaire_response_file.id update existing files.itemid to questionnaire_response_file.id Improvements to satisfy code checker. Make the file upload work with required setting, fix delete of records * Make sid public, because its already used via #[\AllowDynamicProperties] Fix cleanup of old file responses. Add backup/restore handling for file response type. * Fix restore of files in backup. --------- Co-authored-by: Luca Bösch <luca.boesch@bfh.ch> Co-authored-by: Laurent David <lmedavid@gmail.com>

File type question (PoetOS#681)

voegii · 2026-02-11T10:53:40Z

Hi, thank you for this.

After an update, a database error appears on the questionnaire preview page. The table "questionnaire_response_file" is missing.

When updating from a version greater than 2023101500 the table "questionnaire_response_file" will not be created. See https://github.com/PoetOS/moodle-mod_questionnaire/blob/MOODLE_500_STABLE/db/upgrade.php#L1032

mchurchward · 2026-02-18T20:38:19Z

Hi, thank you for this.

After an update, a database error appears on the questionnaire preview page. The table "questionnaire_response_file" is missing.

When updating from a version greater than 2023101500 the table "questionnaire_response_file" will not be created. See https://github.com/PoetOS/moodle-mod_questionnaire/blob/MOODLE_500_STABLE/db/upgrade.php#L1032

Yep. Looks like the version merge didn't get done correctly. I have created issue 707 to deal with this.

* Circumvent number on string error, resolves #538. (#563) * Add file question type Fix upload when several file upload questions are used. - Adjust siganture of methods to their parent - Limit the files to upload to one for each question - Use questionaire id for file draft area instead of question id in the questionaire. Fix handling of file uploads - allow upload of one file only. - new submit does not load previously existing files. Change refence of file.itemid to questionnaire_response_file.id update existing files.itemid to questionnaire_response_file.id Improvements to satisfy code checker. Make the file upload work with required setting, fix delete of records * Make sid public, because its already used via #[\AllowDynamicProperties] Fix cleanup of old file responses. Add backup/restore handling for file response type. * Fix restore of files in backup. --------- Co-authored-by: Luca Bösch <luca.boesch@bfh.ch> Co-authored-by: Laurent David <lmedavid@gmail.com>

srobotta mentioned this pull request Nov 17, 2025

Add new question type file #599

Closed

lucaboesch added a commit to lucaboesch/moodle-mod_questionnaire that referenced this pull request Nov 17, 2025

Fixup for PoetOS#681 pull request.

a05fcfa

lucaboesch added a commit to lucaboesch/moodle-mod_questionnaire that referenced this pull request Nov 17, 2025

Fixup for PoetOS#681 pull request.

1f558e8

srobotta force-pushed the file_type_question branch from c142a07 to 5f1ec08 Compare November 17, 2025 19:20

lucaboesch added a commit to lucaboesch/moodle-mod_questionnaire that referenced this pull request Nov 17, 2025

Fixup for PoetOS#681 pull request.

30c78fb

srobotta force-pushed the file_type_question branch 2 times, most recently from fbaf4cc to 1b8da9e Compare November 17, 2025 20:06

mchurchward requested changes Nov 20, 2025

View reviewed changes

lucaboesch and others added 8 commits November 27, 2025 13:37

Circumvent number on string error, resolves PoetOS#538. (PoetOS#563)

989338f

Fixing Moodle Code Checker issues and prepare for Moodle 4.3

2cca738

Add file question type

d5da11c

Adding savepoint.

e31d31e

Improvements to satisfy code checker. Make the file upload work with required setting, fix delete of records Add file question type

Add file question type

22b1f3e

File question type Behat tests.

bebcec1

Make sid public, because its already used via #[\AllowDynamicProperties]

8142389

Fix cleanup of old file responses. Add backup/restore handling for file response type.

srobotta force-pushed the file_type_question branch 5 times, most recently from 202e766 to c42bf28 Compare November 28, 2025 18:26

srobotta force-pushed the file_type_question branch from c42bf28 to 02a3305 Compare November 29, 2025 11:30

srobotta force-pushed the file_type_question branch from 02a3305 to 12b9cce Compare November 30, 2025 10:56

Adjust code after feedback for PR.

8d9e780

srobotta force-pushed the file_type_question branch from 12b9cce to 8d9e780 Compare December 1, 2025 13:46

lucaboesch mentioned this pull request Dec 8, 2025

Upload file question type for Questionnaire #287

Closed

mchurchward approved these changes Jan 6, 2026

View reviewed changes

mchurchward requested changes Jan 6, 2026

View reviewed changes

srobotta force-pushed the file_type_question branch from 061d48f to 5c84f20 Compare January 13, 2026 16:45

srobotta added 2 commits January 14, 2026 07:58

Fix restore of files in backup.

b5f3045

Update version as requested in PR.

8c82448

srobotta force-pushed the file_type_question branch from 5c84f20 to 8c82448 Compare January 14, 2026 06:58

mchurchward approved these changes Jan 16, 2026

View reviewed changes

mchurchward merged commit 5f1d0cf into PoetOS:MOODLE_500_STABLE Jan 16, 2026
3 checks passed

djarran mentioned this pull request Feb 2, 2026

File type question (#681) catalyst/moodle-mod_questionnaire#6

Merged

golenkovm added a commit to catalyst/moodle-mod_questionnaire that referenced this pull request Feb 9, 2026

Merge pull request #6 from catalyst/MOODLE_404_STABLE_file_type

b164857

File type question (PoetOS#681)

Conversation

srobotta commented Nov 17, 2025

Uh oh!

mchurchward commented Nov 17, 2025

Uh oh!

srobotta commented Nov 17, 2025

Uh oh!

mchurchward commented Nov 20, 2025

Uh oh!

srobotta commented Nov 20, 2025

Uh oh!

mchurchward commented Nov 20, 2025

Uh oh!

mchurchward left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mchurchward left a comment

Choose a reason for hiding this comment

Uh oh!

srobotta commented Nov 21, 2025

Uh oh!

srobotta commented Nov 28, 2025

Uh oh!

mchurchward commented Dec 2, 2025

Uh oh!

mchurchward left a comment

Choose a reason for hiding this comment

Uh oh!

mchurchward left a comment

Choose a reason for hiding this comment

Uh oh!

srobotta commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

srobotta commented Jan 13, 2026

Uh oh!

Uh oh!

mchurchward commented Jan 16, 2026

Uh oh!

djarran commented Jan 29, 2026

Uh oh!

mchurchward commented Jan 29, 2026

Uh oh!

voegii commented Feb 11, 2026

Uh oh!

mchurchward commented Feb 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

srobotta commented Jan 12, 2026 •

edited

Loading