From 157e5c13a7115d93a4e7f60382ed18695fa5976d Mon Sep 17 00:00:00 2001 From: faraz16iqbal Date: Thu, 27 Apr 2023 16:18:53 +0530 Subject: [PATCH 1/4] Added code-review question --- src/server/controllers/todo.js | 22 +++++++++++++++++++++- src/server/models/todo.js | 18 +++++++++++------- src/server/routes/todo.js | 8 ++++---- 3 files changed, 36 insertions(+), 12 deletions(-) diff --git a/src/server/controllers/todo.js b/src/server/controllers/todo.js index 788b682..1298376 100644 --- a/src/server/controllers/todo.js +++ b/src/server/controllers/todo.js @@ -46,6 +46,26 @@ exports.deleteTodo = (req, res) => { res.json({ message: "todo deleted successfully", data }); }) .catch((err) => { - res.status(404).json({ error: "book not found", message: err.message }); + res.status(404).json({ error: "todo not found", message: err.message }); + }); +}; + +exports.deleteTodo = (req, res) => { + Todo.findByIdAndRemove(req.params.id, req.body) + .then((data) => { + res.json({ message: "todo deleted successfully", data }); + }) + .catch((err) => { + res.status(404).json({ error: "todo not found", message: err.message }); + }); +}; + +exports.completeTodo = (req, res) => { + Todo.findByIdAndUpdate(req._id, { updated: req.body.updated }) + .then((data) => { + res.json({ message: "todo status updated successfully", data }); + }) + .catch((err) => { + res.status(404).json({ error: "todo not found", message: err.message }); }); }; diff --git a/src/server/models/todo.js b/src/server/models/todo.js index d801788..95e82a4 100644 --- a/src/server/models/todo.js +++ b/src/server/models/todo.js @@ -1,13 +1,17 @@ const mongoose = require("mongoose"); const TodoSchema = new mongoose.Schema({ - title: { - type: String, - required: true, - }, - description: { - type: String, - }, + title: { + type: String, + required: true, + }, + description: { + type: String, + }, + completedStatus: { + type: Number, + default: false, + }, }); const Todo = mongoose.model("todo", TodoSchema); diff --git a/src/server/routes/todo.js b/src/server/routes/todo.js index 21725fa..188718d 100644 --- a/src/server/routes/todo.js +++ b/src/server/routes/todo.js @@ -3,10 +3,10 @@ const express = require("express"); const router = express.Router(); const { - getAllTodo, - postCreateTodo, - putUpdateTodo, - deleteTodo, + getAllTodo, + postCreateTodo, + putUpdateTodo, + deleteTodo, } = require("../controllers/todo"); /** From a4150e02ba7937075dd8bc3425b16ec7d406be54 Mon Sep 17 00:00:00 2001 From: faraz16iqbal Date: Thu, 27 Apr 2023 16:20:25 +0530 Subject: [PATCH 2/4] Modified code-review question --- src/server/controllers/todo.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/server/controllers/todo.js b/src/server/controllers/todo.js index 1298376..3918273 100644 --- a/src/server/controllers/todo.js +++ b/src/server/controllers/todo.js @@ -60,9 +60,9 @@ exports.deleteTodo = (req, res) => { }); }; -exports.completeTodo = (req, res) => { +exports.completeTodo = (req, res, data) => { Todo.findByIdAndUpdate(req._id, { updated: req.body.updated }) - .then((data) => { + .then(() => { res.json({ message: "todo status updated successfully", data }); }) .catch((err) => { From cbf713fdb57ed83cc69d2eb82e76ce3a89b71f4c Mon Sep 17 00:00:00 2001 From: faraz16iqbal Date: Thu, 27 Apr 2023 16:57:45 +0530 Subject: [PATCH 3/4] chore: add feature --- src/app/components/createTodo.jsx | 102 +++++++++++++++--------------- 1 file changed, 51 insertions(+), 51 deletions(-) diff --git a/src/app/components/createTodo.jsx b/src/app/components/createTodo.jsx index c580883..9624357 100644 --- a/src/app/components/createTodo.jsx +++ b/src/app/components/createTodo.jsx @@ -1,58 +1,58 @@ import { useState } from "react"; -import { addTodo, getTodos } from "../apis"; +import { addTodo } from "../apis"; export function CreateTodo() { - const [data, setData] = useState({ title: "", description: "" }); + const [data, setData] = useState({ title: "", description: "" }); - function handleChange(e) { - setData((data) => ({ ...data, [e.target.name]: e.target.value })); - } + function handleChange(e) { + setData((data) => ({ ...data, [e.target.name]: e.target.value })); + } - async function handleSubmit(e) { - e.preventDefault(); - await addTodo(data); - setData({ title: "", description: "" }); - } + async function handleSubmit(e) { + e.preventDefault(); + await addTodo(data); + setData({ title: "", description: "" }); + } - return ( -
-
-

ADD TODOS

-
-
- - - - - -
-
-
-
- ); -} \ No newline at end of file + return ( +
+
+

ADD TODOS

+
+
+ + + + + +
+
+
+
+ ); +} From 23c9ad106b0349bd48b7e4a20727a27dababcdad Mon Sep 17 00:00:00 2001 From: varadp27 Date: Thu, 27 Apr 2023 16:48:40 +0530 Subject: [PATCH 4/4] tix typo in mongo uri --- src/server/config/db.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/server/config/db.js b/src/server/config/db.js index 903d5db..a8b817b 100644 --- a/src/server/config/db.js +++ b/src/server/config/db.js @@ -1,6 +1,6 @@ const mongoose = require("mongoose"); -const db = "mongodb://120.0.0.1:27017/todo_app" +const db = "mongodb://127.0.0.1:27017/todo_app" const connectDB = async () => { try {