Skip to content

Commit 1ed1056

Browse files
committed
fix(codex): disable unused codex_app.github connector
Set [apps.github] enabled = false in the managed Codex config so the built-in codex_app.github connector is turned off. It is redundant inside docker-git containers (repo clone + synced GitHub token + managed git wrapper already provide GitHub access) and only adds noise. Applied to both the defaultCodexConfig used by auth sync and the entrypoint heredoc, with matching app-package mirrors and a test. Fixes #410
1 parent a78525e commit 1ed1056

6 files changed

Lines changed: 32 additions & 0 deletions

File tree

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
---
2+
"@prover-coder-ai/docker-git": patch
3+
---
4+
5+
Disable the unused `codex_app.github` connector in the managed Codex config.
6+
7+
The generated `config.toml` enables `apps`, which surfaces the built-in
8+
`codex_app.github` connector. It is redundant inside docker-git because
9+
containers already get GitHub access through the cloned repository, the synced
10+
GitHub token, and the managed git wrapper, so the connector only adds noise.
11+
The default Codex config now sets `[apps.github] enabled = false` (both the
12+
`defaultCodexConfig` written by auth sync and the entrypoint heredoc), turning
13+
the connector off while keeping the rest of the `apps` feature intact.

packages/app/src/lib/core/templates-entrypoint/codex.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,10 @@ multi_agent = true
9494
apps = true
9595
shell_tool = true
9696
97+
[apps.github]
98+
# docker-git: disable the unused codex_app.github connector (issue #410)
99+
enabled = false
100+
97101
[profiles.longcontx]
98102
model = "gpt-5.5"
99103
model_context_window = 1050000

packages/app/src/lib/usecases/auth-sync-helpers.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,10 @@ export const defaultCodexConfig = [
5757
"apps = true",
5858
"shell_tool = true",
5959
"",
60+
"[apps.github]",
61+
"# docker-git: disable the unused codex_app.github connector (issue #410)",
62+
"enabled = false",
63+
"",
6064
"[profiles.longcontx]",
6165
"model = \"gpt-5.5\"",
6266
"model_context_window = 1050000",

packages/lib/src/core/templates-entrypoint/codex.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,10 @@ multi_agent = true
9393
apps = true
9494
shell_tool = true
9595
96+
[apps.github]
97+
# docker-git: disable the unused codex_app.github connector (issue #410)
98+
enabled = false
99+
96100
[profiles.longcontx]
97101
model = "gpt-5.5"
98102
model_context_window = 1050000

packages/lib/src/usecases/auth-sync-helpers.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,10 @@ export const defaultCodexConfig = [
5656
"apps = true",
5757
"shell_tool = true",
5858
"",
59+
"[apps.github]",
60+
"# docker-git: disable the unused codex_app.github connector (issue #410)",
61+
"enabled = false",
62+
"",
5963
"[profiles.longcontx]",
6064
"model = \"gpt-5.5\"",
6165
"model_context_window = 1050000",

packages/lib/tests/usecases/auth-sync.test.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,9 @@ describe("syncGithubAuthKeys", () => {
102102
expect(configText).toContain("model_auto_compact_token_limit = 945000")
103103
expect(configText).toContain("model_reasoning_effort = \"xhigh\"")
104104
expect(configText).toContain("plan_mode_reasoning_effort = \"xhigh\"")
105+
// issue #410: the unused codex_app.github connector must be disabled
106+
expect(configText).toContain("[apps.github]")
107+
expect(configText).toContain("enabled = false")
105108
})
106109
).pipe(Effect.provide(NodeContext.layer)))
107110

0 commit comments

Comments
 (0)