test(entrypoint): use @effect/platform FileSystem to satisfy Effect-TS lint

Author: konard

packages/lib/tests/shell/entrypoint-clone-target.test.ts

@@ -5,56 +5,65 @@
 // REF: issue-408
 // SOURCE: n/a
 // FORMAT THEOREM: defaultTargetDir(entrypoint) = appDir(Dockerfile) ∧ appDir ⊂ chown(dev, /home/dev)
-// PURITY: SHELL (reads repository source files)
+// PURITY: SHELL (reads repository source files via @effect/platform FileSystem)
 // INVARIANT: clone target is owned by the unprivileged clone user
 // COMPLEXITY: O(|file|)
+import * as FileSystem from "@effect/platform/FileSystem"
+import * as Path from "@effect/platform/Path"
+import { NodeContext } from "@effect/platform-node"
 import { describe, expect, it } from "@effect/vitest"
-import { readFileSync } from "node:fs"
-import path from "node:path"
-import { fileURLToPath } from "node:url"
+import { Effect } from "effect"
 
-const __filename = fileURLToPath(import.meta.url)
-const __dirname = path.dirname(__filename)
-// packages/lib/tests/shell -> repository root
-const repoRoot = path.resolve(__dirname, "..", "..", "..", "..")
+// CHANGE: derive the dev home that the Dockerfile recursively chowns to the clone user
+// WHY: `git clone` runs as `su - dev`, so the target must live under a dev-owned path
+// PURITY: CORE
+// INVARIANT: returns the `chown -R dev:dev <home>` argument, or "" when absent
+const matchChownedHome = (dockerfile: string): string =>
+  dockerfile.match(/chown -R dev:dev (\/home\/dev)\b/)?.[1] ?? ""
 
-const readRepoFile = (relativePath: string): string =>
-  readFileSync(path.join(repoRoot, relativePath), "utf8")
+// CHANGE: derive the default TARGET_DIR the entrypoint clones into
+// WHY: the bug is a wrong default that points outside the dev-owned home
+// PURITY: CORE
+// INVARIANT: returns the `TARGET_DIR="${TARGET_DIR:-<default>}"` value, or "" when absent
+const matchDefaultTargetDir = (entrypoint: string): string =>
+  entrypoint.match(/TARGET_DIR="\$\{TARGET_DIR:-([^}]+)\}"/)?.[1] ?? ""
 
-describe("standalone base-image clone target", () => {
-  const entrypoint = readRepoFile("entrypoint.sh")
-  const dockerfile = readRepoFile("Dockerfile")
-
-  // CHANGE: derive the dev home that the Dockerfile recursively chowns to the clone user
-  // WHY: `git clone` runs as `su - dev`, so the target must live under a dev-owned path
-  // PURITY: CORE
-  // INVARIANT: chownedHome captures the `chown -R dev:dev <home>` argument
-  const chownedHome = (() => {
-    const match = dockerfile.match(/chown -R dev:dev (\/home\/dev)\b/)
-    return match?.[1]
-  })()
-
-  // CHANGE: derive the default TARGET_DIR the entrypoint clones into
-  // WHY: the bug is a wrong default that points outside the dev-owned home
-  // PURITY: CORE
-  // INVARIANT: defaultTargetDir captures `TARGET_DIR="${TARGET_DIR:-<default>}"`
-  const defaultTargetDir = (() => {
-    const match = entrypoint.match(/TARGET_DIR="\$\{TARGET_DIR:-([^}]+)\}"/)
-    return match?.[1]
-  })()
+// CHANGE: read the repo-root entrypoint + Dockerfile through the Effect FileSystem service
+// WHY: lint forbids node:* imports; @effect/platform is the sanctioned IO boundary
+// PURITY: SHELL
+// EFFECT: Effect<{ entrypoint, dockerfile }, PlatformError | BadArgument, FileSystem | Path>
+const readRepoSources = Effect.gen(function*(_) {
+  const fs = yield* _(FileSystem.FileSystem)
+  const path = yield* _(Path.Path)
+  const here = yield* _(path.fromFileUrl(new URL(import.meta.url)))
+  // packages/lib/tests/shell -> repository root
+  const repoRoot = path.resolve(path.dirname(here), "..", "..", "..", "..")
+  const entrypoint = yield* _(fs.readFileString(path.join(repoRoot, "entrypoint.sh")))
+  const dockerfile = yield* _(fs.readFileString(path.join(repoRoot, "Dockerfile")))
+  return { dockerfile, entrypoint }
+})
 
-  it("prepares an app folder under the dev home in the Dockerfile", () => {
-    expect(dockerfile).toContain("mkdir -p /home/dev/app")
-    expect(chownedHome).toBe("/home/dev")
-  })
+describe("standalone base-image clone target", () => {
+  it.effect("prepares an app folder under the dev home in the Dockerfile", () =>
+    Effect.gen(function*(_) {
+      const { dockerfile } = yield* _(readRepoSources)
+      expect(dockerfile).toContain("mkdir -p /home/dev/app")
+      expect(matchChownedHome(dockerfile)).toBe("/home/dev")
+    }).pipe(Effect.provide(NodeContext.layer)))
 
-  it("defaults the clone target to the prepared app folder", () => {
-    expect(defaultTargetDir).toBe("/home/dev/app")
-  })
+  it.effect("defaults the clone target to the prepared app folder", () =>
+    Effect.gen(function*(_) {
+      const { entrypoint } = yield* _(readRepoSources)
+      expect(matchDefaultTargetDir(entrypoint)).toBe("/home/dev/app")
+    }).pipe(Effect.provide(NodeContext.layer)))
 
-  it("keeps the clone target under the dev-owned home so `su - dev` can write into it", () => {
-    expect(defaultTargetDir).toBeDefined()
-    expect(chownedHome).toBeDefined()
-    expect(`${defaultTargetDir}/`.startsWith(`${chownedHome}/`)).toBe(true)
-  })
+  it.effect("keeps the clone target under the dev-owned home so `su - dev` can write into it", () =>
+    Effect.gen(function*(_) {
+      const { dockerfile, entrypoint } = yield* _(readRepoSources)
+      const chownedHome = matchChownedHome(dockerfile)
+      const defaultTargetDir = matchDefaultTargetDir(entrypoint)
+      expect(chownedHome).not.toBe("")
+      expect(defaultTargetDir).not.toBe("")
+      expect(`${defaultTargetDir}/`.startsWith(`${chownedHome}/`)).toBe(true)
+    }).pipe(Effect.provide(NodeContext.layer)))
 })