fix(lint,test): fix remaining unicorn violations and apply Biome http→https auto-fix

Lint:
- errors.ts, gitlab-token-preflight.ts: convert remaining || === chains to .includes()

Biome auto-fix (useHttpsProtocol and other rules applied to test files):
- terminal-session-client.test.ts: mock URL http→https; update ws:// expectation to wss://
- controller-health.test.ts: http://controller.test → https://controller.test
- controller-ready.test.ts: DOCKER_GIT_API_URL and expectations http→https
- controller-revision.test.ts: .split("/")[0] → .split("/", 1)[0]
- app-ready-create-fixture.ts: "   " → " ".repeat(3)
- menu-shared.test.ts: arrow function formatting

CI setup: bump bun CI runner from 1.3.11 to 1.3.14 to match local dev environment

All 448 tests pass locally.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: skulidropek

.github/actions/setup/action.yml

@@ -4,7 +4,7 @@ inputs:
   bun-version:
     description: The version of Bun to install
     required: true
-    default: 1.3.11
+    default: 1.3.14
   node-version:
     description: The version of Node.js to install for compatibility/native builds
     required: true

packages/app/src/lib/usecases/errors.ts

@@ -48,12 +48,7 @@ export type AppError =
 type NonParseError = Exclude<AppError, ParseError>
 
 const isParseError = (error: AppError): error is ParseError =>
-  error._tag === "UnknownCommand" ||
-  error._tag === "UnknownOption" ||
-  error._tag === "MissingOptionValue" ||
-  error._tag === "MissingRequiredOption" ||
-  error._tag === "InvalidOption" ||
-  error._tag === "UnexpectedArgument"
+  ["UnknownCommand", "UnknownOption", "MissingOptionValue", "MissingRequiredOption", "InvalidOption", "UnexpectedArgument"].includes(error._tag)
 
 const renderDockerAccessHeadline = (issue: DockerAccessError["issue"]): string =>
   issue === "PermissionDenied"

packages/app/src/lib/usecases/gitlab-token-preflight.ts

@@ -93,7 +93,7 @@ const mapGitlabRepoAccessStatus = (status: number): GitlabRepoAccessStatus => {
   if (status >= 200 && status < 300) {
     return "accessible"
   }
-  if (status === 401 || status === 403 || status === 404) {
+  if ([401, 403, 404].includes(status)) {
     return "notAccessible"
   }
   return "unknown"

packages/app/tests/docker-git/app-ready-create-fixture.ts

@@ -292,7 +292,7 @@ export const expectEmptyRepoInlineError = (
   submitCreateInputsMock: SubmitCreateInputsMock,
   mode: CreateSubmitMode = "advance"
 ) => {
-  const createView = createInitialFlowView("   ")
+  const createView = createInitialFlowView(" ".repeat(3))
   const { context, setCreateViewSpy } = runSubmitCreateView(submitCreateView, createView, { mode })
 
   expect(submitCreateInputsMock).not.toHaveBeenCalled()

packages/app/tests/docker-git/controller-health.test.ts

@@ -48,7 +48,7 @@ const withHealthClient = <A, E>(
   revisions: ReadonlyArray<string>,
   effect: (baseUrl: string) => Effect.Effect<A, E, HttpClient.HttpClient>
 ): Effect.Effect<A, E> =>
-  effect("http://controller.test").pipe(Effect.provideService(HttpClient.HttpClient, makeHealthClient(revisions)))
+  effect("https://controller.test").pipe(Effect.provideService(HttpClient.HttpClient, makeHealthClient(revisions)))
 
 describe("controller health", () => {
   it.effect("selects the first reachable candidate whose revision matches the expected revision", () =>

packages/app/tests/docker-git/controller-ready.test.ts

@@ -98,10 +98,10 @@ describe("controller readiness bootstrap", () => {
 
   it.effect("probes explicit API URL before preparing a local controller revision", () =>
     Effect.gen(function*(_) {
-      process.env["DOCKER_GIT_API_URL"] = "http://api.example.test"
+      process.env["DOCKER_GIT_API_URL"] = "https://api.example.test"
       findReachableDirectHealthProbeMock.mockImplementation(({ explicitApiBaseUrl }) =>
         Effect.succeed({
-          apiBaseUrl: explicitApiBaseUrl ?? "http://api.example.test",
+          apiBaseUrl: explicitApiBaseUrl ?? "https://api.example.test",
           revision: "remote-revision"
         })
       )
@@ -116,7 +116,7 @@ describe("controller readiness bootstrap", () => {
       expect(prepareLocalControllerRevisionMock).not.toHaveBeenCalled()
       expect(prepareControllerResourceLimitEnvMock).not.toHaveBeenCalled()
       expect(prepareControllerRuntimeEnvMock).not.toHaveBeenCalled()
-      expect(resolveApiBaseUrl()).toBe("http://api.example.test")
+      expect(resolveApiBaseUrl()).toBe("https://api.example.test")
     }))
 
   it.effect("falls back to local bootstrap when the default local API URL is not reachable", () =>

packages/app/tests/docker-git/controller-revision.test.ts

@@ -141,7 +141,7 @@ const createMemoryFileSystemLayer = () => {
           if (candidate === directory || !candidate.startsWith(prefix)) {
             continue
           }
-          const name = candidate.slice(prefix.length).split("/")[0]
+          const name = candidate.slice(prefix.length).split("/", 1)[0]
           if (name !== undefined && name.length > 0) {
             names.add(name)
           }

packages/app/tests/docker-git/menu-shared.test.ts

@@ -48,11 +48,10 @@ const restoreTerminalBindings = (): void => {
   Object.defineProperty(process.stdout, "isTTY", { configurable: true, value: originalStdoutTty })
 }
 
-const createRawModeStub = (events: Array<string>): typeof process.stdin.setRawMode =>
-  (enabled: boolean) => {
-    events.push(`raw:${String(enabled)}`)
-    return process.stdin
-  }
+const createRawModeStub = (events: Array<string>): typeof process.stdin.setRawMode => (enabled: boolean) => {
+  events.push(`raw:${String(enabled)}`)
+  return process.stdin
+}
 
 const createWriteStub = (
   events: Array<string>

packages/app/tests/docker-git/terminal-session-client.test.ts

@@ -194,7 +194,7 @@ describe("terminal-session-client", () => {
     vi.useFakeTimers()
     vi.resetModules()
     resolveApiBaseUrlMock.mockReset()
-    resolveApiBaseUrlMock.mockReturnValue("http://controller.example/api")
+    resolveApiBaseUrlMock.mockReturnValue("https://controller.example/api")
     writeToTerminalMock.mockReset()
     setRawModeMock.mockClear()
     stdinOnMock.mockClear()
@@ -247,7 +247,7 @@ describe("terminal-session-client", () => {
 
       const socket = firstSocket()
       expect(socket.url).toBe(
-        "ws://controller.example/api/projects/%2Fcontroller%2Fprovercoderai%2Fdocker-git%2Fmain/terminal-sessions/session-1/ws?cols=132&rows=40"
+        "wss://controller.example/api/projects/%2Fcontroller%2Fprovercoderai%2Fdocker-git%2Fmain/terminal-sessions/session-1/ws?cols=132&rows=40"
       )
       expect(socket.sent).toEqual([])
       expect(setRawModeMock).toHaveBeenCalledWith(false)