refactor: consolidation sweep — adapter-owned exposure-time knowledge + shared FWHM helper

[Jammy2211]

Overview

Behaviour-preserving consolidation sweep from the mined candidates in PyAutoMind/draft/refactor/pyautoreduce/consolidation_sweep.md (Refactor Agent: invariant witnessed by test_autoreduce; API guard none-expected). Public behaviour observable through the test suite is unchanged; no dial or output changes.

Plan

• Move the per-observatory single-exposure-time header knowledge (HST EXPTIME vs Keck ITIME×COADDS) out of pipeline._psf onto InstrumentAdapter, where the adapter-boundary contract says it belongs — shrinking the if/elif chains the planned ground-based instruments would otherwise extend.
• Merge the two mathematically identical second-moment FWHM helpers (psf/frame_combine._moment_fwhm, psf/starred_epsf._size_fwhm) into one shared psf/moments.py helper; leave the two genuinely different estimators (epsf._fwhm_of radial half-max diagnostic, nirc2_star._fwhm_arcsec equivalent-area) in place.
• Fold single-function noise/jwst_rms.py into noise/rms.py (callers/tests updated).
• Rider: gitignore prototypes/cache_inject/ (the inject-recovery prototype's fresh cache; FITS are never committed).

Detailed implementation plan

Affected Repositories

• PyAutoReduce (primary, only)

Branch Survey

Repository	Current Branch	Dirty?
./PyAutoReduce	main @ 59beb04	clean (background prototype writing to untracked cache dir)

Suggested branch: refactor/consolidation-sweep

Implementation Steps

1. autoreduce/instruments/adapter.py — max_single_exposure_seconds(headers) -> Optional[float]: HST max EXPTIME; Keck max ITIME×COADDS; JWST None (surface-brightness mosaics take no full-well cut). Loud on non-positive results for observatories that require it. The per-observatory explanatory comments move with the knowledge.
2. autoreduce/pipeline.py _psf — replace the hst/keck/else peak_max branches with one call: t = adapter.max_single_exposure_seconds(headers); peak_max = selection.saturation_fraction * adapter.saturation_dn / t if t else None.
3. New autoreduce/psf/moments.py — moment_fwhm(kernel) (second-moment 2.3548σ, non-negative clip); frame_combine and starred_epsf import it; private duplicates deleted.
4. noise/rms.py absorbs noise_map_from_error from noise/jwst_rms.py; pipeline._noise import updated; noise/jwst_rms.py deleted; tests touching it updated.
5. .gitignore — add prototypes/cache_inject/.
6. Full suite must stay green unchanged (229 passed / 3 skipped baseline).

Key Files

• autoreduce/instruments/adapter.py, autoreduce/pipeline.py
• autoreduce/psf/moments.py (new), autoreduce/psf/frame_combine.py, autoreduce/psf/starred_epsf.py
• autoreduce/noise/rms.py, autoreduce/noise/jwst_rms.py (removed)

Original Prompt

Click to expand starting prompt

See PyAutoMind/draft/refactor/pyautoreduce/consolidation_sweep.md (moves to active/ with this issue) — user request 2026-07-16 + mined candidates (including the checked-and-rejected list: mad_sigma already shared, combine dispatch already centralised, frames.py vs keck_frames.py divergence deliberate).

---

Autonomy: --auto, effective level safe (refactor cap): plan recorded here in lieu of the Plan-Mode hold per PyAutoBrain/AUTONOMY.md. Behaviour-preservation witness: test_autoreduce. Merge stays human.

[Jammy2211]

Library PR created — run ends at PR-open

PR: #49 (pending-release; 10 files, +112/−116 — net negative, as a consolidation should be).

Ship gate: tests 229 passed / 3 skipped, identical to the pre-refactor baseline (the behaviour-preservation witness) · smoke n/a · review CLEAN (one disclosed diagnostic-only delta: shared moment_fwhm clips negative pixels) · Heart RED — six pre-existing unrelated reasons, human-acknowledged contemporaneously (drift count noted growing 2→4→6 today).

Workspace impact: none (option iii). Internal-only moves; the one removed module (noise/jwst_rms) had no users outside the repo.

Riders shipped with it: .gitignore for the inject-recovery cache; the relative-path fix the first real-data injection-recovery run flagged (drizzle combine chdir broke relative cache paths). The recovery run itself is re-running now; result will be posted on #46.

Merge stays human.

[Jammy2211]

Merged: PR #49. Consolidation on main; the adapter seam is ready for the ground-based instruments feature (next up). Closing.