Dear Music Player group
I have some feedback regarding the week 11 assignment feedback from another group task.
-If you don't need a file e.g. PlaybackFunction.py I would suggest to remove it instead of commenting it out. (And if you want to comment several lines I suggest to use """ """ instead of a # on every line. This way all the code inside the """ code """ gets commented out.
-I had sometimes a hard time understanding the reason for a function (for example in Player and GUI. You could implement comments like this
"""
What function does,
:param a
:param b
return:
"""
(I do really like your function naming. I think most functions are already clear and understandable this way.)
-you have a lot of commented out functions for example in song.py. I would suggest to remove them instead of commenting them out.
Dear Music Player group
I have some feedback regarding the week 11 assignment feedback from another group task.
-If you don't need a file e.g. PlaybackFunction.py I would suggest to remove it instead of commenting it out. (And if you want to comment several lines I suggest to use """ """ instead of a # on every line. This way all the code inside the """ code """ gets commented out.
-I had sometimes a hard time understanding the reason for a function (for example in Player and GUI. You could implement comments like this
"""
What function does,
:param a
:param b
return:
"""
(I do really like your function naming. I think most functions are already clear and understandable this way.)
-you have a lot of commented out functions for example in song.py. I would suggest to remove them instead of commenting them out.