Skip to content

Commit d657453

Browse files
rustyconoverclaude
andcommitted
Fix README SQL examples: drop redundant AS, quote TYPE, qualify calls as easter.easter_date()
The ATTACH alias was redundant (the database is already named 'easter') and the bare easter_date(...) calls don't resolve; verified the corrected forms against the real vgi extension. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 9930f3d commit d657453

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

README.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@ that computes the date of **Western (Gregorian) Easter Sunday** for a given year
55
and exposes it to DuckDB as a SQL scalar function.
66

77
```sql
8-
ATTACH 'easter' AS easter (TYPE vgi, LOCATION 'uvx vgi-easter');
8+
ATTACH 'easter' (TYPE 'vgi', LOCATION 'uvx vgi-easter');
99

10-
SELECT easter_date(2025);
10+
SELECT easter.easter_date(2025);
1111
-- 2025-04-20
1212

13-
SELECT year, easter_date(year) AS easter
13+
SELECT year, easter.easter_date(year) AS easter
1414
FROM range(2020, 2031) t(year);
1515
-- 2020 2020-04-12
1616
-- 2021 2021-04-04
@@ -78,8 +78,8 @@ server to manage — point the LOCATION at the installed command (or `uvx
7878
vgi-easter` to fetch it on demand):
7979

8080
```sql
81-
ATTACH 'easter' AS easter (TYPE vgi, LOCATION 'uvx vgi-easter');
82-
SELECT easter_date(2025);
81+
ATTACH 'easter' (TYPE 'vgi', LOCATION 'uvx vgi-easter');
82+
SELECT easter.easter_date(2025);
8383
DETACH easter;
8484
```
8585

@@ -95,8 +95,8 @@ VGI_SIGNING_KEY=dev vgi-easter-http --host 0.0.0.0 --port 8000
9595
Then attach over HTTP (the VGI extension auto-loads `httpfs`):
9696

9797
```sql
98-
ATTACH 'easter' AS easter (TYPE vgi, LOCATION 'http://localhost:8000');
99-
SELECT easter_date(2025);
98+
ATTACH 'easter' (TYPE 'vgi', LOCATION 'http://localhost:8000');
99+
SELECT easter.easter_date(2025);
100100
```
101101

102102
### From a source checkout

0 commit comments

Comments
 (0)