Make this a proper fpcalc wrapper

[geecko86]

The following fpcalc options

"Options:\n"
"  -format NAME   Set the input format name\n"
"  -rate NUM      Set the sample rate of the input audio\n"
"  -channels NUM  Set the number of channels in the input audio\n"
"  -length SECS   Restrict the duration of the processed input audio (default 120)\n"
"  -chunk SECS    Split the input audio into chunks of this duration\n"
"  -algorithm NUM Set the algorigthm method (default 2)\n"
"  -overlap       Overlap the chunks slightly to make sure audio on the edges is fingerprinted\n"
"  -ts            Output UNIX timestamps for chunked results, useful when fingerprinting real-time audio stream\n"
"  -raw           Output fingerprints in the uncompressed format\n"
"  -json          Print the output in JSON format\n"
"  -text          Print the output in text format\n"
"  -plain         Print the just the fingerprint in text format\n"
 "  -version       Print version information\n"

currently need to be inputted via the one String[] argv parameter. The library should have java methods for each of those options.

[svenoaks]

Those aren't fpcalc options, fpcalc only has one public function fpcalc_main which takes the string[]. A whole JNI wrapper for chromaprint would probably not be very useful as most people are probably just going to want to use fpcalc, and if they're going to use chromaprint directly will probably do it in c++ anyway.

[geecko86]

Those are the options fpcalc lists when I execute fpcalc on my machine with no path to an audio file.

For instance in QuickLyric we use -length x, and we need to use a String[] to do that. I just think it's not very clean. LIke I said earlier, it's not exactly a priority but I think it would be better.

[svenoaks]

That's a lot of work, rewriting fpcalc, managing instances of things and so on. Not very much benefit, you can pass any of the options to the String[].

[geecko86]

We'll talk about this during the call.

I'm talking about something which takes 5 minutes to write. A simple java wrapper so that you don't need to create your String[] params.

Instead of:

String[] args = {"-length", "100", path};
String output = FpCalc.fpCalc(args);

You would have something like:

String output = new FpcalcConfig().setLength(100).setRaw(true).run();

Where setLength() and setRaw() add their stuff to a String[] field and the only thing run() does is to execute your static method with the specified parameters.

Another reason why we might want to do that is because right now it's possible to input anything in the params argument, which would trigger an exception, which isn't handled by the library.

We aren't talking about rewriting fpcalc or about managing instances. This is just about making a Java library feel like Java.

[svenoaks]

Oh yeah you could use a builder to set the parameters as needed and then execute

[svenoaks]

But then you could get into parsing the result, and so on too.