Improve goto definition lookup speed on first call

[PMassicotte]

The gd is expected to be a bit slow on the first call. I will try to improve that.

Part of the information that you need may already be cached. The list of all functions from all libraries is always loaded in rnvimserver memory. The list of all objects in the .GlobalEnv is also in rnvimserver memory.

Originally posted by @jalvesaq in #505

[PMassicotte]

@jalvesaq which code formatter are you using for C? I will use the same so the incoming PR does not look too ugly :)

[PMassicotte]

Is it ok if I add .clang-format file in this PR?

BasedOnStyle: LLVM
IndentWidth: 4
ColumnLimit: 80
PointerAlignment: Right
SpaceAfterCStyleCast: false

This is the closest I could come to match your formatting style.

[jalvesaq]

My conform config is this:

require("conform").setup({
    formatters_by_ft = {
        lua = { "stylua" },
        quarto = { "injected" },
        rmd = { "injected" },
        r = { "air" },
        c = { "clang-format" },
    },
    format_on_save = {
        lsp_format = "fallback",
        timeout_ms = 500,
    },
    formatters = {
        clang_format = {
            prepend_args = {
                "--style={BasedOnStyle: llvm, IndentWidth: 4, SortIncludes: Never}",
            },
        },
    },
})

The option SortIncludes: Never is critically important. If the headers are sorted, the C code will not compile on all platforms.

I also have this compile_commands.json in my ~/src directory, where I keep R.nvim:

[
    {
        "directory": "/home/aquino/src/R.nvim/nvimcom/src",
        "command": "/usr/bin/clang -I /home/aquino/software/R-4.5.2/include -DNDEBUG -fpic -O3 -Wall -pedantic -Wformat -Wstrict-prototypes -mtune=native -c",
        "file": "*"
    },
    {
        "directory": "/home/aquino/src/R.nvim/nvimcom/src/apps",
        "command": "/usr/bin/clang -O3 -Wall -pedantic -Wformat -Wstrict-prototypes -mtune=native -c",
        "file": "*"
    },
    {
        "directory": "*",
        "command": "/usr/bin/clang -O3 -Wall -pedantic -Wformat -mtune=native -c",
        "file": "*"
    }
]

And I have vim.lsp.enable({"clangd")} in Neovim config.

[PMassicotte]

Good, got it working. The only thing I have issue with is some line wrapping.

diff --git a/nvimcom/src/apps/rnvimserver.c b/nvimcom/src/apps/rnvimserver.c
index a8e0e25..c959dd2 100644
--- a/nvimcom/src/apps/rnvimserver.c
+++ b/nvimcom/src/apps/rnvimserver.c
@@ -459,7 +459,8 @@ static void handle_implementation(const char *id) {
     send_cmd_to_nvim(i_cmd);
 }
 
-// Generic function to handle location-based LSP responses (definition, references, implementation)
+// Generic function to handle location-based LSP responses (definition,
+// references, implementation)
 static void send_location_result(const char *params) {
     // IMPORTANT: Search for ALL fields BEFORE calling cut_json_* functions,
     // because those functions NULL-terminate and modify the params string!
@@ -486,22 +487,26 @@ static void send_location_result(const char *params) {
         size_t result_size = 4096;
         char *result = (char *)malloc(result_size);
         char *p = result;
-        p += snprintf(p, result_size, "{\"jsonrpc\":\"2.0\",\"id\":%s,\"result\":[", id);
+        p += snprintf(p, result_size,
+                      "{\"jsonrpc\":\"2.0\",\"id\":%s,\"result\":[", id);
 
         char *loc = arr_start + 1;
         int first = 1;
         while (loc < arr_end) {
             char *obj_start = strchr(loc, '{');
-            if (!obj_start || obj_start >= arr_end) break;
+            if (!obj_start || obj_start >= arr_end)
+                break;
 
             char *obj_end = strchr(obj_start, '}');
-            if (!obj_end || obj_end > arr_end) break;
+            if (!obj_end || obj_end > arr_end)
+                break;
 
             char *file = strstr(obj_start, "\"file\":\"");
             char *line = strstr(obj_start, "\"line\":");
             char *col = strstr(obj_start, "\"col\":");
 
-            if (file && line && col && file < obj_end && line < obj_end && col < obj_end) {
+            if (file && line && col && file < obj_end && line < obj_end &&
+                col < obj_end) {
                 file += 8;
                 char *file_end = strchr(file, '"');
                 if (file_end && file_end < obj_end) {
@@ -521,9 +526,12 @@ static void send_location_result(const char *params) {
                     first = 0;
 
                     p += snprintf(p, result_size - (p - result),
-                        "{\"uri\":\"file://%s\",\"range\":{\"start\":{\"line\":%d,\"character\":%d},"
-                        "\"end\":{\"line\":%d,\"character\":%d}}}",
-                        file_str, line_num, col_num, line_num, col_num);
+                                  "{\"uri\":\"file://"
+                                  "%s\",\"range\":{\"start\":{\"line\":%d,"
+                                  "\"character\":%d},"
+                                  "\"end\":{\"line\":%d,\"character\":%d}}}",
+                                  file_str, line_num, col_num, line_num,
+                                  col_num);
 
                     free(file_str);
                 }
@@ -545,14 +553,16 @@ static void send_location_result(const char *params) {
         cut_json_int(&col_field, 6);
 
         // Build the LSP Location response
-        const char *fmt =
-            "{\"jsonrpc\":\"2.0\",\"id\":%s,\"result\":"
-            "{\"uri\":\"%s\",\"range\":{\"start\":{\"line\":%s,\"character\":%s},"
-            "\"end\":{\"line\":%s,\"character\":%s}}}}";
+        const char *fmt = "{\"jsonrpc\":\"2.0\",\"id\":%s,\"result\":"
+                          "{\"uri\":\"%s\",\"range\":{\"start\":{\"line\":%s,"
+                          "\"character\":%s},"
+                          "\"end\":{\"line\":%s,\"character\":%s}}}}";
 
-        size_t len = strlen(uri) + strlen(id) + strlen(line_field) * 2 + strlen(col_field) * 2 + 256;
+        size_t len = strlen(uri) + strlen(id) + strlen(line_field) * 2 +
+                     strlen(col_field) * 2 + 256;
         char *res = (char *)malloc(len);
-        snprintf(res, len - 1, fmt, id, uri, line_field, col_field, line_field, col_field);
+        snprintf(res, len - 1, fmt, id, uri, line_field, col_field, line_field,
+                 col_field);
         send_ls_response(id, res);
         free(res);
     }
@@ -585,8 +595,9 @@ static void send_document_symbols_result(const char *params) {
         return;
     }
 
-    // Build the result - we'll pass through the symbols array as-is since Lua already formatted it correctly
-    // The Lua code sends DocumentSymbol objects with all required fields
+    // Build the result - we'll pass through the symbols array as-is since Lua
+    // already formatted it correctly The Lua code sends DocumentSymbol objects
+    // with all required fields
     size_t result_size = (arr_end - arr_start) + 256;
     char *result = (char *)malloc(result_size);
 
@@ -596,7 +607,9 @@ static void send_document_symbols_result(const char *params) {
     strncpy(array_content, arr_start, array_len);
     array_content[array_len] = '\0';
 
-    snprintf(result, result_size, "{\"jsonrpc\":\"2.0\",\"id\":%s,\"result\":%s}", id, array_content);
+    snprintf(result, result_size,
+             "{\"jsonrpc\":\"2.0\",\"id\":%s,\"result\":%s}", id,
+             array_content);
 
     send_ls_response(id, result);
     free(array_content);

[PMassicotte]

clang-format --version
clang-format version 22.1.0

[PMassicotte]

Is it possible that there is an issue with

  c = { "clang-format" }

That should be

c = { "clang_format" },

[jalvesaq]

Maybe something with ColumnLimit: 80 ?

[jalvesaq]

Now, I have found this file. Perhaps, we could create a copy of it (or part of it) in the R.nvim directory:

~/src/.clang-format:

---
Language:        Cpp
AccessModifierOffset: -2
AlignAfterOpenBracket: Align
AlignArrayOfStructures: None
AlignConsecutiveAssignments:
  Enabled:         false
  AcrossEmptyLines: false
  AcrossComments:  false
  AlignCompound:   false
  AlignFunctionPointers: false
  PadOperators:    true
AlignConsecutiveBitFields:
  Enabled:         false
  AcrossEmptyLines: false
  AcrossComments:  false
  AlignCompound:   false
  AlignFunctionPointers: false
  PadOperators:    false
AlignConsecutiveDeclarations:
  Enabled:         false
  AcrossEmptyLines: false
  AcrossComments:  false
  AlignCompound:   false
  AlignFunctionPointers: false
  PadOperators:    false
AlignConsecutiveMacros:
  Enabled:         false
  AcrossEmptyLines: false
  AcrossComments:  false
  AlignCompound:   false
  AlignFunctionPointers: false
  PadOperators:    false
AlignConsecutiveShortCaseStatements:
  Enabled:         false
  AcrossEmptyLines: false
  AcrossComments:  false
  AlignCaseArrows: false
  AlignCaseColons: false
AlignConsecutiveTableGenBreakingDAGArgColons:
  Enabled:         false
  AcrossEmptyLines: false
  AcrossComments:  false
  AlignCompound:   false
  AlignFunctionPointers: false
  PadOperators:    false
AlignConsecutiveTableGenCondOperatorColons:
  Enabled:         false
  AcrossEmptyLines: false
  AcrossComments:  false
  AlignCompound:   false
  AlignFunctionPointers: false
  PadOperators:    false
AlignConsecutiveTableGenDefinitionColons:
  Enabled:         false
  AcrossEmptyLines: false
  AcrossComments:  false
  AlignCompound:   false
  AlignFunctionPointers: false
  PadOperators:    false
AlignEscapedNewlines: Right
AlignOperands:   Align
AlignTrailingComments:
  Kind:            Always
  OverEmptyLines:  0
AllowAllArgumentsOnNextLine: true
AllowAllParametersOfDeclarationOnNextLine: true
AllowBreakBeforeNoexceptSpecifier: Never
AllowShortBlocksOnASingleLine: Never
AllowShortCaseExpressionOnASingleLine: true
AllowShortCaseLabelsOnASingleLine: false
AllowShortCompoundRequirementOnASingleLine: true
AllowShortEnumsOnASingleLine: true
AllowShortFunctionsOnASingleLine: All
AllowShortIfStatementsOnASingleLine: Never
AllowShortLambdasOnASingleLine: All
AllowShortLoopsOnASingleLine: false
AlwaysBreakAfterDefinitionReturnType: None
AlwaysBreakBeforeMultilineStrings: false
AttributeMacros:
  - __capability
BinPackArguments: true
BinPackParameters: true
BitFieldColonSpacing: Both
BraceWrapping:
  AfterCaseLabel:  false
  AfterClass:      false
  AfterControlStatement: Never
  AfterEnum:       false
  AfterExternBlock: false
  AfterFunction:   false
  AfterNamespace:  false
  AfterObjCDeclaration: false
  AfterStruct:     false
  AfterUnion:      false
  BeforeCatch:     false
  BeforeElse:      false
  BeforeLambdaBody: false
  BeforeWhile:     false
  IndentBraces:    false
  SplitEmptyFunction: true
  SplitEmptyRecord: true
  SplitEmptyNamespace: true
BreakAdjacentStringLiterals: true
BreakAfterAttributes: Leave
BreakAfterJavaFieldAnnotations: false
BreakAfterReturnType: None
BreakArrays:     true
BreakBeforeBinaryOperators: None
BreakBeforeConceptDeclarations: Always
BreakBeforeBraces: Attach
BreakBeforeInlineASMColon: OnlyMultiline
BreakBeforeTernaryOperators: true
BreakConstructorInitializers: BeforeColon
BreakFunctionDefinitionParameters: false
BreakInheritanceList: BeforeColon
BreakStringLiterals: true
BreakTemplateDeclarations: MultiLine
ColumnLimit:     80
CommentPragmas:  '^ IWYU pragma:'
CompactNamespaces: false
ConstructorInitializerIndentWidth: 4
ContinuationIndentWidth: 4
Cpp11BracedListStyle: true
DerivePointerAlignment: false
DisableFormat:   false
EmptyLineAfterAccessModifier: Never
EmptyLineBeforeAccessModifier: LogicalBlock
ExperimentalAutoDetectBinPacking: false
FixNamespaceComments: true
ForEachMacros:
  - foreach
  - Q_FOREACH
  - BOOST_FOREACH
IfMacros:
  - KJ_IF_MAYBE
IncludeBlocks:   Preserve
IncludeCategories:
  - Regex:           '^"(llvm|llvm-c|clang|clang-c)/'
    Priority:        2
    SortPriority:    0
    CaseSensitive:   false
  - Regex:           '^(<|"(gtest|gmock|isl|json)/)'
    Priority:        3
    SortPriority:    0
    CaseSensitive:   false
  - Regex:           '.*'
    Priority:        1
    SortPriority:    0
    CaseSensitive:   false
IncludeIsMainRegex: '(Test)?$'
IncludeIsMainSourceRegex: ''
IndentAccessModifiers: false
IndentCaseBlocks: false
IndentCaseLabels: false
IndentExternBlock: AfterExternBlock
IndentGotoLabels: true
IndentPPDirectives: None
IndentRequiresClause: true
IndentWidth:     4
IndentWrappedFunctionNames: false
InsertBraces:    false
InsertNewlineAtEOF: false
InsertTrailingCommas: None
IntegerLiteralSeparator:
  Binary:          0
  BinaryMinDigits: 0
  Decimal:         0
  DecimalMinDigits: 0
  Hex:             0
  HexMinDigits:    0
JavaScriptQuotes: Leave
JavaScriptWrapImports: true
KeepEmptyLines:
  AtEndOfFile:     false
  AtStartOfBlock:  true
  AtStartOfFile:   true
LambdaBodyIndentation: Signature
LineEnding:      DeriveLF
MacroBlockBegin: ''
MacroBlockEnd:   ''
MainIncludeChar: Quote
MaxEmptyLinesToKeep: 1
NamespaceIndentation: None
ObjCBinPackProtocolList: Auto
ObjCBlockIndentWidth: 2
ObjCBreakBeforeNestedBlockParam: true
ObjCSpaceAfterProperty: false
ObjCSpaceBeforeProtocolList: true
PackConstructorInitializers: BinPack
PenaltyBreakAssignment: 2
PenaltyBreakBeforeFirstCallParameter: 19
PenaltyBreakComment: 300
PenaltyBreakFirstLessLess: 120
PenaltyBreakOpenParenthesis: 0
PenaltyBreakScopeResolution: 500
PenaltyBreakString: 1000
PenaltyBreakTemplateDeclaration: 10
PenaltyExcessCharacter: 1000000
PenaltyIndentedWhitespace: 0
PenaltyReturnTypeOnItsOwnLine: 60
PointerAlignment: Right
PPIndentWidth:   -1
QualifierAlignment: Leave
ReferenceAlignment: Pointer
ReflowComments:  true
RemoveBracesLLVM: false
RemoveParentheses: Leave
RemoveSemicolon: false
RequiresClausePosition: OwnLine
RequiresExpressionIndentation: OuterScope
SeparateDefinitionBlocks: Leave
ShortNamespaceLines: 1
SkipMacroDefinitionBody: false
SortIncludes:    Never
SortJavaStaticImport: Before
SortUsingDeclarations: LexicographicNumeric
SpaceAfterCStyleCast: false
SpaceAfterLogicalNot: false
SpaceAfterTemplateKeyword: true
SpaceAroundPointerQualifiers: Default
SpaceBeforeAssignmentOperators: true
SpaceBeforeCaseColon: false
SpaceBeforeCpp11BracedList: false
SpaceBeforeCtorInitializerColon: true
SpaceBeforeInheritanceColon: true
SpaceBeforeJsonColon: false
SpaceBeforeParens: ControlStatements
SpaceBeforeParensOptions:
  AfterControlStatements: true
  AfterForeachMacros: true
  AfterFunctionDefinitionName: false
  AfterFunctionDeclarationName: false
  AfterIfMacros:   true
  AfterOverloadedOperator: false
  AfterPlacementOperator: true
  AfterRequiresInClause: false
  AfterRequiresInExpression: false
  BeforeNonEmptyParentheses: false
SpaceBeforeRangeBasedForLoopColon: true
SpaceBeforeSquareBrackets: false
SpaceInEmptyBlock: false
SpacesBeforeTrailingComments: 1
SpacesInAngles:  Never
SpacesInContainerLiterals: true
SpacesInLineCommentPrefix:
  Minimum:         1
  Maximum:         -1
SpacesInParens:  Never
SpacesInParensOptions:
  ExceptDoubleParentheses: false
  InCStyleCasts:   false
  InConditionalStatements: false
  InEmptyParentheses: false
  Other:           false
SpacesInSquareBrackets: false
Standard:        Latest
StatementAttributeLikeMacros:
  - Q_EMIT
StatementMacros:
  - Q_UNUSED
  - QT_REQUIRE_VERSION
TableGenBreakInsideDAGArg: DontBreak
TabWidth:        8
UseTab:          Never
VerilogBreakBetweenInstancePorts: true
WhitespaceSensitiveMacros:
  - BOOST_PP_STRINGIZE
  - CF_SWIFT_NAME
  - NS_SWIFT_NAME
  - PP_STRINGIZE
  - STRINGIZE
...

[PMassicotte]

Yes that would be perfect. Want to commit it and I will rebase main into my incoming PR.

[jalvesaq]

Please, include it in your pull request...

[jalvesaq]

Looking again, I see that there are lines that we obviously don't need, such as the options for Objective-C, and QT...

[PMassicotte]

Looking again, I see that there are lines that we obviously don't need, such as the options for Objective-C, and QT...

I will propose something, you can validate if ok with you.