From 96855509a779ef52f8bf2b65b2d80876e210cdc4 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 13 Jan 2026 15:58:16 +0000 Subject: [PATCH 1/2] Initial plan From f032a02b829522f0e6026fe4ec96f54b52aedff2 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 13 Jan 2026 16:01:59 +0000 Subject: [PATCH 2/2] Fix workflow syntax: use env vars instead of secrets in if conditions Co-authored-by: R00S <1279537+R00S@users.noreply.github.com> --- .github/workflows/build-apk.yml | 34 ++++++++++++++++++--------------- 1 file changed, 19 insertions(+), 15 deletions(-) diff --git a/.github/workflows/build-apk.yml b/.github/workflows/build-apk.yml index b581f4aa..2a4b6f32 100644 --- a/.github/workflows/build-apk.yml +++ b/.github/workflows/build-apk.yml @@ -62,24 +62,28 @@ jobs: continue-on-error: true - name: Setup signing keystore - if: ${{ secrets.KEYSTORE_BASE64 != '' }} + env: + KEYSTORE_BASE64: ${{ secrets.KEYSTORE_BASE64 }} + KEYSTORE_PASSWORD: ${{ secrets.KEYSTORE_PASSWORD }} + KEY_PASSWORD: ${{ secrets.KEY_PASSWORD }} + KEY_ALIAS: ${{ secrets.KEY_ALIAS }} run: | - # Decode keystore from secret (persistent key for consistent signatures) - echo "${{ secrets.KEYSTORE_BASE64 }}" | base64 -d > android/app/upload-keystore.jks - - # Create key.properties file - cat > android/key.properties << EOF - storePassword=${{ secrets.KEYSTORE_PASSWORD }} - keyPassword=${{ secrets.KEY_PASSWORD }} - keyAlias=${{ secrets.KEY_ALIAS }} + if [ -n "$KEYSTORE_BASE64" ]; then + echo "Setting up signing keystore..." + # Decode keystore from secret (persistent key for consistent signatures) + echo "$KEYSTORE_BASE64" | base64 -d > android/app/upload-keystore.jks + + # Create key.properties file + cat > android/key.properties << EOF + storePassword=$KEYSTORE_PASSWORD + keyPassword=$KEY_PASSWORD + keyAlias=$KEY_ALIAS storeFile=upload-keystore.jks EOF - - - name: Note about signing - if: ${{ secrets.KEYSTORE_BASE64 == '' }} - run: | - echo "⚠️ No signing keystore configured - APK will be signed with debug key" - echo "This is normal for forks. The APK will still work for testing." + else + echo "⚠️ No signing keystore configured - APK will be signed with debug key" + echo "This is normal for forks. The APK will still work for testing." + fi - name: Build APK run: |