Skip to content

Adds WaitFor & WaitForMultiple as extensions for IList<IMessage>#184

Closed
joshkempner wants to merge 4 commits into
masterfrom
joshkempner/wait-for
Closed

Adds WaitFor & WaitForMultiple as extensions for IList<IMessage>#184
joshkempner wants to merge 4 commits into
masterfrom
joshkempner/wait-for

Conversation

@joshkempner

@joshkempner joshkempner commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

What does this pull request do?
Improve backward compatibility with unit tests that rely on DispatcherSpecification and MockRepositorySpecification

How does this pull request accomplish that goal?

  • Adds WaitFor and WaitForMultiple as extensions methods for IList<IMessage>. This improves backward compatibility with existing unit tests.
  • The lists of messages exposed by the CapturingSubscribableBus are no longer read-only.

Why is this pull request important?
This reduces the effort involved in updating to the latest version of ReactiveDomain

Link to any issues that this resolves
This does not address any open issues.

Checklist

  • All unit tests in the solution must pass on all versions of .NET that the solution supports
  • Any new code must be covered by at least one unit test
  • All public methods must be documented with XML comments

@joshkempner joshkempner requested a review from condron March 18, 2026 16:19
@joshkempner joshkempner self-assigned this Mar 18, 2026
@joshkempner joshkempner requested a review from a team as a code owner March 18, 2026 16:19
@joshkempner joshkempner changed the title Adds WaitFor/Multiple as extension for IList<IMessage> Adds WaitFor & WaitForMultiple as extensions for IList<IMessage> Mar 18, 2026
@joshkempner joshkempner force-pushed the joshkempner/wait-for branch from b4d3aea to d6bd26e Compare March 18, 2026 16:22
- Adds WaitFor and WaitForMultiple as extensions methods for IList<IMessage>. This improves backward compatibility with existing unit tests.
- The lists of messages exposed by the CapturingSubscribableBus are no longer read-only.
@joshkempner joshkempner force-pushed the joshkempner/wait-for branch from d6bd26e to 58decd5 Compare March 18, 2026 16:26
@joshkempner joshkempner marked this pull request as draft March 18, 2026 16:27
@joshkempner

Copy link
Copy Markdown
Contributor Author

Abandoning this since it shouldn't be needed. With the TestQueue being updated synchronously, we should never have to wait for a message to appear on the test queue. If we do, then the test is using multiple threads, which it shouldn't do.

@joshkempner joshkempner deleted the joshkempner/wait-for branch March 18, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant