Skip to content

Commit a9f843e

Browse files
committed
fix(release): push git commit and tags after nx release
1 parent 627e9f6 commit a9f843e

5 files changed

Lines changed: 23 additions & 6 deletions

File tree

.github/actions/release/action.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,4 +32,12 @@ runs:
3232
# See: https://github.com/nrwl/nx/blob/5ea2e47acfa9d175546daa922ce40905533f1074/packages/nx/src/utils/package-manager.ts#L207-L213
3333
npm_config_legacy_peer_deps: false
3434
run: npx nx release --yes
35+
- name: Push release commit and tags
36+
shell: bash
37+
# nx release (unified command) creates the git commit and tags locally but does not push them,
38+
# regardless of the release.git.push setting in nx.json. It only pushes automatically when
39+
# createRelease (GitHub/GitLab releases) is enabled. Since we use createReleaseInGitHub: false,
40+
# we push manually here so that the version bumps in package.json reach the remote and
41+
# nacho-bot can create PRs in consuming repos.
42+
run: git push --follow-tags
3543

nx.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@
5858
"git": {
5959
"commit": true,
6060
"tag": true,
61-
"push": true,
6261
"commitMessage": "chore(release): publish\n\n{releaseNotes}"
6362
},
6463
"version": {

package-lock.json

Lines changed: 13 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/host-inventory/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@redhat-cloud-services/host-inventory-client",
3-
"version": "4.1.7",
3+
"version": "5.0.0",
44
"description": "",
55
"main": "./index.js",
66
"typings": "./index.d.ts",

packages/rbac/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@redhat-cloud-services/rbac-client",
3-
"version": "6.0.1",
3+
"version": "7.0.0",
44
"description": "JavaScript client for Red Hat Insights RBAC service",
55
"main": "./index.js",
66
"typings": "./index.d.ts",

0 commit comments

Comments
 (0)